From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 16BAACA9EB5 for ; Mon, 4 Nov 2019 19:22:38 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DFBFB2084D for ; Mon, 4 Nov 2019 19:22:37 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="RfThgQx9"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="Bc7u55gE" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DFBFB2084D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=SADIUyGSAh2w9cEv5r3ialNoAXCiG5DkbrRKb6rsoc4=; b=RfThgQx9R5u2da c7NMFq+QoHKaPUo0vwCBxeQF8ZLw80lAXqr6MMSNpTvHQUrToKN/Axx8o3MvYPA4a+O93Q68DXCPN sh4Ac+Z2O9VzTem0N+LaTavZNKE3x2JnV93GW00V9W7sPdPxE+DS5aAYnz7DJp3e4k6+UrfxavgKo p2ol907PKX6IJmJZ+NBG1hVTxmTRTjKfwKnCcwsfZZevunRXDXoHmRekZxCJlNUhgJ+lwYWjItuGA EDC0Yetoutw56X5puulFqydH6nqmwH840mSANYKuaf4GpZIpd0exLUvIOGNO4zlLp5D6gRX65cYqB G/5in1s2rnetgYUOffHA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iRhvw-0006kq-Ho; Mon, 04 Nov 2019 19:22:36 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iRhvt-0006kV-FV for linux-arm-kernel@lists.infradead.org; Mon, 04 Nov 2019 19:22:34 +0000 Received: from willie-the-truck (236.31.169.217.in-addr.arpa [217.169.31.236]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 4D90F2084D; Mon, 4 Nov 2019 19:22:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1572895353; bh=MhG1SjLYJ/MiCKm1KPNAmPokTvBcbqXpuiAnoMPPBg0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Bc7u55gEFoctioL006Je3W8RgfHRUpFfA9UoJApZvIElhrrOUsSsjCNy/gH5aQkpm 9yNVmC9s2tVzfw0qUFjsGxrRENo3JRZpY3EynkP4lDpT83SvzkGyNwfhPT3Lz2T1b/ fUyWki51LJYGZb8NIBDxQOQaYOK3XIQ6KGeClhv0= Date: Mon, 4 Nov 2019 19:22:29 +0000 From: Will Deacon To: Robin Murphy Subject: Re: [PATCH v2 00/10] iommu/io-pgtable: Cleanup and prep for split tables Message-ID: <20191104192228.GL24909@willie-the-truck> References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191104_112233_541902_DE22F1F0 X-CRM114-Status: GOOD ( 15.59 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: iommu@lists.linux-foundation.org, jcrouse@codeaurora.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Robin, On Fri, Oct 25, 2019 at 07:08:29PM +0100, Robin Murphy wrote: > Since the flawed first attempt, I've reworked things with an abstracted > TCR and an explicit TTBR1 quirk. I originally envisaged the need to pass > the quirk all the way down to the TLBI calls, hence getting diverted > into trying to make the parameter passing less cluttered in general, but > in the end it turned out fairly neat to just fix the indexing such that > we can always just pass around the original unmodified IOVA. Most of the > new patches come from staring at that indexing code for long enough to > see the subtle inefficiencies that were worth ironing out, plus a bit of > random cleanup which doesn't feel worth posting separately. > > Note that these patches depend on the fixes already queued in -rc4, > otherwise there will be conflicts in arm_mali_lpae_alloc_pgtable(). > > Robin. > > > Robin Murphy (10): > iommu/io-pgtable: Make selftest gubbins consistently __init > iommu/io-pgtable-arm: Rationalise size check > iommu/io-pgtable-arm: Simplify bounds checks > iommu/io-pgtable-arm: Simplify start level lookup > iommu/io-pgtable-arm: Simplify PGD size handling > iommu/io-pgtable-arm: Simplify level indexing > iommu/io-pgtable-arm: Rationalise MAIR handling > iommu/io-pgtable-arm: Rationalise TTBRn handling > iommu/io-pgtable-arm: Rationalise TCR handling > iommu/io-pgtable-arm: Prepare for TTBR1 usage Overall, this looks really good to me. There's a bit more work to do (see my comments) and I'd like Jordan to have a look as well, but on the whole it's a big improvement. Thanks. Will _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel