* [PATCH] ARM: dts: imx6ul: imx6ul-14x14-evk.dtsi: Fix SPI NOR probing
@ 2019-11-05 7:34 Stefan Roese
2019-11-05 7:41 ` Schrempf Frieder
2019-11-05 12:52 ` Fabio Estevam
0 siblings, 2 replies; 3+ messages in thread
From: Stefan Roese @ 2019-11-05 7:34 UTC (permalink / raw)
To: linux-arm-kernel; +Cc: Shawn Guo, Fabio Estevam, Frieder Schrempf
Without this "jedec,spi-nor" compatible property, probing of the SPI NOR
does not work on the NXP i.MX6ULL EVK. Fix this by adding this
compatible property to the DT.
Signed-off-by: Stefan Roese <sr@denx.de>
Cc: Fabio Estevam <festevam@gmail.com>
Cc: Frieder Schrempf <frieder.schrempf@kontron.de>
Cc: Shawn Guo <shawnguo@kernel.org>
---
arch/arm/boot/dts/imx6ul-14x14-evk.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/imx6ul-14x14-evk.dtsi b/arch/arm/boot/dts/imx6ul-14x14-evk.dtsi
index c2a9dd57e56a..aa86341adaaa 100644
--- a/arch/arm/boot/dts/imx6ul-14x14-evk.dtsi
+++ b/arch/arm/boot/dts/imx6ul-14x14-evk.dtsi
@@ -215,7 +215,7 @@
flash0: n25q256a@0 {
#address-cells = <1>;
#size-cells = <1>;
- compatible = "micron,n25q256a";
+ compatible = "micron,n25q256a", "jedec,spi-nor";
spi-max-frequency = <29000000>;
spi-rx-bus-width = <4>;
spi-tx-bus-width = <4>;
--
2.24.0
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] ARM: dts: imx6ul: imx6ul-14x14-evk.dtsi: Fix SPI NOR probing
2019-11-05 7:34 [PATCH] ARM: dts: imx6ul: imx6ul-14x14-evk.dtsi: Fix SPI NOR probing Stefan Roese
@ 2019-11-05 7:41 ` Schrempf Frieder
2019-11-05 12:52 ` Fabio Estevam
1 sibling, 0 replies; 3+ messages in thread
From: Schrempf Frieder @ 2019-11-05 7:41 UTC (permalink / raw)
To: Stefan Roese, linux-arm-kernel@lists.infradead.org
Cc: Fabio Estevam, Shawn Guo
On 05.11.19 08:34, Stefan Roese wrote:
> Without this "jedec,spi-nor" compatible property, probing of the SPI NOR
> does not work on the NXP i.MX6ULL EVK. Fix this by adding this
> compatible property to the DT.
>
> Signed-off-by: Stefan Roese <sr@denx.de>
> Cc: Fabio Estevam <festevam@gmail.com>
> Cc: Frieder Schrempf <frieder.schrempf@kontron.de>
> Cc: Shawn Guo <shawnguo@kernel.org>
Reviewed-by: Frieder Schrempf <frieder.schrempf@kontron.de>
> ---
> arch/arm/boot/dts/imx6ul-14x14-evk.dtsi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/imx6ul-14x14-evk.dtsi b/arch/arm/boot/dts/imx6ul-14x14-evk.dtsi
> index c2a9dd57e56a..aa86341adaaa 100644
> --- a/arch/arm/boot/dts/imx6ul-14x14-evk.dtsi
> +++ b/arch/arm/boot/dts/imx6ul-14x14-evk.dtsi
> @@ -215,7 +215,7 @@
> flash0: n25q256a@0 {
> #address-cells = <1>;
> #size-cells = <1>;
> - compatible = "micron,n25q256a";
> + compatible = "micron,n25q256a", "jedec,spi-nor";
> spi-max-frequency = <29000000>;
> spi-rx-bus-width = <4>;
> spi-tx-bus-width = <4>;
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] ARM: dts: imx6ul: imx6ul-14x14-evk.dtsi: Fix SPI NOR probing
2019-11-05 7:34 [PATCH] ARM: dts: imx6ul: imx6ul-14x14-evk.dtsi: Fix SPI NOR probing Stefan Roese
2019-11-05 7:41 ` Schrempf Frieder
@ 2019-11-05 12:52 ` Fabio Estevam
1 sibling, 0 replies; 3+ messages in thread
From: Fabio Estevam @ 2019-11-05 12:52 UTC (permalink / raw)
To: Stefan Roese
Cc: Shawn Guo, Frieder Schrempf,
moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE
Hi Stefan,
On Tue, Nov 5, 2019 at 4:34 AM Stefan Roese <sr@denx.de> wrote:
>
> Without this "jedec,spi-nor" compatible property, probing of the SPI NOR
> does not work on the NXP i.MX6ULL EVK. Fix this by adding this
> compatible property to the DT.
>
> Signed-off-by: Stefan Roese <sr@denx.de>
> Cc: Fabio Estevam <festevam@gmail.com>
> Cc: Frieder Schrempf <frieder.schrempf@kontron.de>
> Cc: Shawn Guo <shawnguo@kernel.org>
Thanks for the fix.
Please add a Fixes tag so that it can be backported to older kernels.
Then you can also add:
Reviewed-by: Fabio Estevam <festevam@gmail.com>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-11-05 12:52 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-11-05 7:34 [PATCH] ARM: dts: imx6ul: imx6ul-14x14-evk.dtsi: Fix SPI NOR probing Stefan Roese
2019-11-05 7:41 ` Schrempf Frieder
2019-11-05 12:52 ` Fabio Estevam
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox