* [PATCH v2] rtc: brcmstb-waketimer: add missed clk_disable_unprepare
@ 2019-11-05 16:00 Chuhong Yuan
2019-11-05 17:04 ` Florian Fainelli
2019-11-05 17:18 ` Alexandre Belloni
0 siblings, 2 replies; 3+ messages in thread
From: Chuhong Yuan @ 2019-11-05 16:00 UTC (permalink / raw)
Cc: linux-rtc, Alessandro Zummo, Alexandre Belloni, Florian Fainelli,
Chuhong Yuan, linux-kernel, bcm-kernel-feedback-list,
linux-arm-kernel
This driver forgets to disable and unprepare clock when remove.
Add a call to clk_disable_unprepare to fix it.
Fixes: c4f07ecee22e ("rtc: brcmstb-waketimer: Add Broadcom STB wake-timer")
Signed-off-by: Chuhong Yuan <hslester96@gmail.com>
---
Changes in v2:
- Remove the check for timer->clk and add fixes tag.
drivers/rtc/rtc-brcmstb-waketimer.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/rtc/rtc-brcmstb-waketimer.c b/drivers/rtc/rtc-brcmstb-waketimer.c
index 3e9800f9878a..82d2ab0b3e9c 100644
--- a/drivers/rtc/rtc-brcmstb-waketimer.c
+++ b/drivers/rtc/rtc-brcmstb-waketimer.c
@@ -277,6 +277,7 @@ static int brcmstb_waketmr_remove(struct platform_device *pdev)
struct brcmstb_waketmr *timer = dev_get_drvdata(&pdev->dev);
unregister_reboot_notifier(&timer->reboot_notifier);
+ clk_disable_unprepare(timer->clk);
return 0;
}
--
2.23.0
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v2] rtc: brcmstb-waketimer: add missed clk_disable_unprepare
2019-11-05 16:00 [PATCH v2] rtc: brcmstb-waketimer: add missed clk_disable_unprepare Chuhong Yuan
@ 2019-11-05 17:04 ` Florian Fainelli
2019-11-05 17:18 ` Alexandre Belloni
1 sibling, 0 replies; 3+ messages in thread
From: Florian Fainelli @ 2019-11-05 17:04 UTC (permalink / raw)
To: Chuhong Yuan
Cc: linux-rtc, Alessandro Zummo, Alexandre Belloni, linux-kernel,
bcm-kernel-feedback-list, linux-arm-kernel
On 11/5/19 8:00 AM, Chuhong Yuan wrote:
> This driver forgets to disable and unprepare clock when remove.
> Add a call to clk_disable_unprepare to fix it.
>
> Fixes: c4f07ecee22e ("rtc: brcmstb-waketimer: Add Broadcom STB wake-timer")
> Signed-off-by: Chuhong Yuan <hslester96@gmail.com>
Acked-by: Florian Fainelli <f.fainelli@gmail.com>
--
Florian
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v2] rtc: brcmstb-waketimer: add missed clk_disable_unprepare
2019-11-05 16:00 [PATCH v2] rtc: brcmstb-waketimer: add missed clk_disable_unprepare Chuhong Yuan
2019-11-05 17:04 ` Florian Fainelli
@ 2019-11-05 17:18 ` Alexandre Belloni
1 sibling, 0 replies; 3+ messages in thread
From: Alexandre Belloni @ 2019-11-05 17:18 UTC (permalink / raw)
To: Chuhong Yuan
Cc: linux-rtc, Alessandro Zummo, Florian Fainelli, linux-kernel,
bcm-kernel-feedback-list, linux-arm-kernel
On 06/11/2019 00:00:43+0800, Chuhong Yuan wrote:
> This driver forgets to disable and unprepare clock when remove.
> Add a call to clk_disable_unprepare to fix it.
>
> Fixes: c4f07ecee22e ("rtc: brcmstb-waketimer: Add Broadcom STB wake-timer")
> Signed-off-by: Chuhong Yuan <hslester96@gmail.com>
> ---
> Changes in v2:
> - Remove the check for timer->clk and add fixes tag.
>
> drivers/rtc/rtc-brcmstb-waketimer.c | 1 +
> 1 file changed, 1 insertion(+)
>
Applied, thanks.
--
Alexandre Belloni, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-11-05 17:18 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-11-05 16:00 [PATCH v2] rtc: brcmstb-waketimer: add missed clk_disable_unprepare Chuhong Yuan
2019-11-05 17:04 ` Florian Fainelli
2019-11-05 17:18 ` Alexandre Belloni
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).