From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4FDADC5DF62 for ; Wed, 6 Nov 2019 04:07:04 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1250C21882 for ; Wed, 6 Nov 2019 04:07:04 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="RV+yVT4W" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1250C21882 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=ZFylILKrmuOV1udGT6wdKlMJMEVoWMWsuVHVMO8PvwM=; b=RV+yVT4WEUUaNS BQIdqgYWE1wuwq/Czbncumwwe/7FlVgJRYUG6YZX/nFIEq9fHrEZE7llHCAI7Kn+9/AYXB93Tp5D8 r/dteNVfH18a3r8fisUmgSrWDSoUPpQRzolIf6bxROtP9GBLmpLxTliHFWhlewGd9k0FO1myKUsHB bA8qUVEAwETb0C0angv6WqVnu6mzwcy044zSmQhXeaWsMZHZbrlY/eJlQ60kLRwiccdaG3yokb6Nn mf28E+PlvdYA1IOXqav0UaZwbRvS2ldGzZk7zTSdvcxC3ojhLJCoVOXKF9WIw94Wp3bCHJ3ReuRLL LECmFb6XcwGCFVwucLYg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iSCb1-0003Zo-N0; Wed, 06 Nov 2019 04:07:03 +0000 Received: from mail-oi1-f195.google.com ([209.85.167.195]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iSCay-0003Z3-4t for linux-arm-kernel@lists.infradead.org; Wed, 06 Nov 2019 04:07:01 +0000 Received: by mail-oi1-f195.google.com with SMTP id e9so15860462oif.8 for ; Tue, 05 Nov 2019 20:07:00 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=pbXWYeEjjc1tNeD8Va0Rn7W5q8WImyzirMTHLiEKYGY=; b=QB5XC8km2dKf4dAWhWJdJpS8q8hjMdEclZTthTtro4F83uzVY81HkyGiX1m3jagpwc 7AbJHglvj7XxJ/AG7PPuBHoLcwwLQF9AkP/bSWPA7VQ2Y/Mxr5YOAELTmpM/bDH3x9RY 9mnDFZ3iWshyQWV9uZFCVq5zn0mLTQzij4fuWSFQJD/S9zO61tsbGjYPAAYC24Wzj5Ir BFPYSFEdRnCsWZEE2U2SBHWQkKG0SQaNzk6Gfl6bIDorUpyYBQfeh0LKVtPMMV3B+T6z K8XrfEevoHXSXMlq7w3so0n5ZTRCf2oL0grYqavZfmbebLX73hMyfE9JIAIwtHO+DjEB 2zbA== X-Gm-Message-State: APjAAAVZFWdWMx5eGeezF7/m+6YRpmii7qPx75rhVvehkxKwJdUZp3j0 0Bnxn/ewy4j8nox3uffU9w== X-Google-Smtp-Source: APXvYqwe0beNgeLE8gya+f9XdJ7ynxnQMAtyk6u+v0005b8KLbqtym2m20lGy9EYFxREtXyxePD27Q== X-Received: by 2002:aca:f18b:: with SMTP id p133mr406122oih.22.1573013219216; Tue, 05 Nov 2019 20:06:59 -0800 (PST) Received: from localhost (24-155-109-49.dyn.grandenetworks.net. [24.155.109.49]) by smtp.gmail.com with ESMTPSA id k93sm6726958otc.30.2019.11.05.20.06.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 05 Nov 2019 20:06:58 -0800 (PST) Date: Tue, 5 Nov 2019 22:06:57 -0600 From: Rob Herring To: Benjamin Gaignard Subject: Re: [PATCH 2/4] dt-bindings: iio: timer: Convert stm32 IIO trigger bindings to json-schema Message-ID: <20191106040657.GA5294@bogus> References: <20191031123040.26316-1-benjamin.gaignard@st.com> <20191031123040.26316-3-benjamin.gaignard@st.com> <20191103110841.3ad3ecfb@archlinux> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191105_200700_189700_8B10446F X-CRM114-Status: GOOD ( 22.69 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , devicetree@vger.kernel.org, Lars-Peter Clausen , Benjamin Gaignard , Linux PWM List , linux-iio@vger.kernel.org, Hartmut Knaack , Linux Kernel Mailing List , Thierry Reding , Linux ARM , Peter Meerwald-Stadler , u.kleine-koenig@pengutronix.de, Fabrice Gasnier , Lee Jones , linux-stm32@st-md-mailman.stormreply.com, Jonathan Cameron , Alexandre Torgue Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Nov 05, 2019 at 11:07:16AM +0100, Benjamin Gaignard wrote: > Le dim. 3 nov. 2019 =E0 12:08, Jonathan Cameron a =E9c= rit : > > > > On Thu, 31 Oct 2019 13:30:38 +0100 > > Benjamin Gaignard wrote: > > > > > Convert the STM32 IIO trigger binding to DT schema format using json-= schema > > > > > > Signed-off-by: Benjamin Gaignard > > I'm far from great on these as still haven't taken the time I should to= learn > > the yaml syntax properly. A few comments inline however based mostly o= n this > > doesn't quite look like other ones I've seen recently. > > > > Thanks, > > > > Jonathan > > > > > --- > > > .../bindings/iio/timer/st,stm32-timer-trigger.yaml | 44 ++++++++++++= ++++++++++ > > > .../bindings/iio/timer/stm32-timer-trigger.txt | 25 ------------ > > > 2 files changed, 44 insertions(+), 25 deletions(-) > > > create mode 100644 Documentation/devicetree/bindings/iio/timer/st,st= m32-timer-trigger.yaml > > > delete mode 100644 Documentation/devicetree/bindings/iio/timer/stm32= -timer-trigger.txt > > > > > > diff --git a/Documentation/devicetree/bindings/iio/timer/st,stm32-tim= er-trigger.yaml b/Documentation/devicetree/bindings/iio/timer/st,stm32-time= r-trigger.yaml > > > new file mode 100644 > > > index 000000000000..1c8c8b55e8cd > > > --- /dev/null > > > +++ b/Documentation/devicetree/bindings/iio/timer/st,stm32-timer-trig= ger.yaml > > > @@ -0,0 +1,44 @@ > > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > > > +%YAML 1.2 > > > +--- > > > +$id: http://devicetree.org/schemas/iio/timer/st,stm32-timer-trigger.= yaml# > > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > > + > > > +title: STMicroelectronics STM32 Timers IIO timer bindings > > > + > > > +maintainers: > > > + - Benjamin Gaignard > > > + - Fabrice Gasnier > > > + > > > +properties: > > > + $nodemane: > > > > nodename? > = > That will be in v2 No, $nodename is correct. The '$' signifies something we generate and = add in. IOW, not a real property. I guess we could have used 'name' here = and stuck with traditional OpenFirmware. > = > > > > > + pattern: "^timer@[0-9]+$" > > > + type: object > > > + > > > + description: > > > + must be a sub-node of an STM32 Timer device tree node > > > + > > > + properties: > > > + compatible: > > > + oneOf: > > > > enum is I think preferred for these. > = > as you like it will be in v2 > = > > > > > + - const: st,stm32-timer-trigger > > > + - const: st,stm32h7-timer-trigger > > > + > > > + reg: true > > > > Normally some info for what the reg value is.. > I can't put "description" on this field because the syntax doesn't allow = it. > I will add a comment in v2 to explain what reg is. items: - maximum: Rob _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel