linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: Catalin Marinas <catalin.marinas@arm.com>
To: Mark Brown <broonie@kernel.org>
Cc: Will Deacon <will@kernel.org>, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v5 4/4] arm64: Use a variable to store non-global mappings decision
Date: Wed, 6 Nov 2019 09:13:16 +0000	[thread overview]
Message-ID: <20191106091316.GD21133@arrakis.emea.arm.com> (raw)
In-Reply-To: <20191105174445.GD4500@sirena.co.uk>

On Tue, Nov 05, 2019 at 05:44:45PM +0000, Mark Brown wrote:
> On Tue, Nov 05, 2019 at 05:30:06PM +0000, Catalin Marinas wrote:
> > On Mon, Nov 04, 2019 at 07:15:24PM +0000, Mark Brown wrote:
> 
> > > +	/*
> > > +	 * If know now we are going to need KPTI then use non-global
> > > +	 * mappings from the start, avoiding the cost of rewriting
> > > +	 * everything later.
> > > +	 */
> > > +	arm64_use_ng_mappings = kaslr_requires_kpti();
> > >  }
> 
> > I think we need this even earlier in paging_init() before we start
> > creating the kernel mappings.
> 
> OK, I'll move it.  I didn't see any global mappings getting created with
> the current code but better safe than sorry.

I gave these patches a try under kvm/qemu on TX2 and most of the linear
map turns out global in ptdump.

I'll try your other series.

-- 
Catalin

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

      reply	other threads:[~2019-11-06  9:13 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-04 19:15 [PATCH v5 0/4] E0PD support Mark Brown
2019-11-04 19:15 ` [PATCH v5 1/4] arm64: Add initial support for E0PD Mark Brown
2019-11-04 19:15 ` [PATCH v5 2/4] arm64: Factor out checks for KASLR in KPTI code into separate function Mark Brown
2019-11-04 19:15 ` [PATCH v5 3/4] arm64: Don't use KPTI where we have E0PD Mark Brown
2019-11-04 19:15 ` [PATCH v5 4/4] arm64: Use a variable to store non-global mappings decision Mark Brown
2019-11-05 17:30   ` Catalin Marinas
2019-11-05 17:44     ` Mark Brown
2019-11-06  9:13       ` Catalin Marinas [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191106091316.GD21133@arrakis.emea.arm.com \
    --to=catalin.marinas@arm.com \
    --cc=broonie@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).