From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CC165C5DF61 for ; Thu, 7 Nov 2019 11:48:36 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 95FAD2166E for ; Thu, 7 Nov 2019 11:48:36 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="CVFZMhSs"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="uK/fsmOx" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 95FAD2166E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Z4UFTcwMXZVmRjTqbHb3zRYnWH7mSx1y6evO8BCuu7w=; b=CVFZMhSsuucXvk jqB00k+CRAkAWC6tZeEiaF9A9RZ6lK0V3fAcaBroNGpsl5KM5SW1WWQ6MhwggBdpAJO1eXneFKRF9 +q44VXs39b97qP0jehwkkyS9dFKmoqBt4dXSp5SAdZ5Vd73rmadL/6ilADeHEsPEzcz/WFLJaONx1 N4HhrkAkAdTKHkLFn8+BuSQsXU0bSV/C/quAoKbztU/C0Q6s34QL80ThL08U8AHb6GWkhTndU+ZxS sUUB06A9p7bZ692u6Pmg2Mad/cGY01CKKyucefro/yw2vylaQ1pkVDKqvKfVDMVoiKaQAxPnqd4mj E4aTXm9coWa4IAGJ6xbQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iSgHD-00064i-G8; Thu, 07 Nov 2019 11:48:35 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iSgH9-00064M-AQ for linux-arm-kernel@lists.infradead.org; Thu, 07 Nov 2019 11:48:32 +0000 Received: from willie-the-truck (236.31.169.217.in-addr.arpa [217.169.31.236]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 0AAAA2166E; Thu, 7 Nov 2019 11:48:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1573127311; bh=3imnQYV9vnOOyMoMuGz9bN2zW9noZspiY4wyiS3PcKw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=uK/fsmOxceO3wRwrmA+E/acdYdJ1hMVH9zmJLvufAWBxMgSmfkNFr2TIDlr+gLU6/ NjQkMPDVVode2a55bOxIBlfOkz75/s56jRj0NF69Jt9b0hecEce2c3GKY6wNXHWNZv 8P+Qtby61KbPdkqLGR+H0N7d2tVdjHlhqGH7QhlU= Date: Thu, 7 Nov 2019 11:48:26 +0000 From: Will Deacon To: Catalin Marinas , steve.capper@arm.com Subject: Re: [PATCH] arm64: Do not mask out PTE_RDONLY in pte_same() Message-ID: <20191107114826.GC11587@willie-the-truck> References: <20191106154105.15176-1-catalin.marinas@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20191106154105.15176-1-catalin.marinas@arm.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191107_034831_380156_EA8B2DC9 X-CRM114-Status: GOOD ( 12.39 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: John Stultz , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Nov 06, 2019 at 03:41:05PM +0000, Catalin Marinas wrote: > Following commit 73e86cb03cf2 ("arm64: Move PTE_RDONLY bit handling out > of set_pte_at()"), the PTE_RDONLY bit is no longer managed by > set_pte_at() but built into the PAGE_* attribute definitions. > Consequently, pte_same() must include this bit when checking two PTEs > for equality. > > Remove the arm64-specific pte_same() function, practically reverting > commit 747a70e60b72 ("arm64: Fix copy-on-write referencing in HugeTLB") > > Fixes: 73e86cb03cf2 ("arm64: Move PTE_RDONLY bit handling out of set_pte_at()") > Cc: # 4.14.x- > Cc: Will Deacon > Cc: Steve Capper > Reported-by: John Stultz > Signed-off-by: Catalin Marinas > --- > > Steve, > > Could you please check that the original problem fixed by commit > 747a70e60b72 no longer exists after reverting it in 4.14 onwards? In the meantime, I've pushed this out to for-next/fixes since the CI came back clean and it fixes John's issue (which I've confirmed locally too). Interestingly, I'm not at all sure the problem is related to the Mali driver. Some tracing suggests that the ART JIT thread is stuck on a write fault, which could be explained by a broken pte_same(). Steve -- if you could please run the libhugetlbfs test suite as described in 747a70e60b72 before tomorrow, that would be really great. Thanks, Will _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel