From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 714FFC5DF60 for ; Fri, 8 Nov 2019 10:06:21 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 46A9A214DB for ; Fri, 8 Nov 2019 10:06:21 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="d9ICJBIz"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b="c6h9rDXp" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 46A9A214DB Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=oracle.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=R/ive2s6MmCCyBunAW8h/3HTmWdYYQ6nbn7nzBb0Sck=; b=d9ICJBIzxh33Fd Is08f0XJo+QjT9mjBfYzxdZf6YBjS63SPi7m9EFwBKIYmfoWN5W+KRIVb+ExSssL7z/vhX5xWvn+2 3U6D7AxP2hgxL8AwGUAkv549ujwc+04jJeZJNlCLAuS2IXQPdJ+WhPoiYsMiaf9wkMZcUjQuQP19j B7aA+Kr/IkvmcZ/FLw2ORzzBKSFgI2ZYru9Z+RvV9CDYBYmuBIN97W5XB8FbquSsoV/FP77nrU6HN vPGn6IqAAmgAA+BW1vxQVDdyH/wundGHp9KEkzoxB8YKPUHhX+Y5WyPmHHa0os1nWABxPcc/Kmb0H WJ+XopFyLJ9d+6VyZNnQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iT19o-00017G-OH; Fri, 08 Nov 2019 10:06:20 +0000 Received: from userp2120.oracle.com ([156.151.31.85]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iT19l-00016R-89 for linux-arm-kernel@lists.infradead.org; Fri, 08 Nov 2019 10:06:18 +0000 Received: from pps.filterd (userp2120.oracle.com [127.0.0.1]) by userp2120.oracle.com (8.16.0.27/8.16.0.27) with SMTP id xA8A4x9I001795; Fri, 8 Nov 2019 10:05:56 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=date : from : to : cc : subject : message-id : references : mime-version : content-type : in-reply-to; s=corp-2019-08-05; bh=lC6Rkjy3TVUxRx/UkJEpYp4pAS/Xsi+0+ID04N6qrLk=; b=c6h9rDXpTZeTKMt/UAHRyxcJCa3LmlwbmCwd3WfWT2FHiYjk9b1XuIHdE+Q9e+VWtEa9 cBwQJ90CMjAzOilomMcgaXlZM2CcAhKXaFG9Nu6xmT/tGj6fBwqh1H908Lk6OwrZs7zU dUE9VNd2TVaBl1NGzbdqQV9MgRyaagI1EnQyq2rooCQroHr7kutic8477Jnb3E9gPOcI rha2gZSs2A8wjG0Uk011O0sGiWgX2KX/Y899/tCLcEcTkhmVjhqVSj4WhUMMiUqrtuZR s7I1Ydxoioxw7fFsMY0pYFCL1iHSK8Z0Dyz3QD3KVgQOZLnkjq/VgTk3S18UJZn8+Ao6 KA== Received: from aserp3030.oracle.com (aserp3030.oracle.com [141.146.126.71]) by userp2120.oracle.com with ESMTP id 2w41w14btb-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 08 Nov 2019 10:05:56 +0000 Received: from pps.filterd (aserp3030.oracle.com [127.0.0.1]) by aserp3030.oracle.com (8.16.0.27/8.16.0.27) with SMTP id xA8A4Iq9024070; Fri, 8 Nov 2019 10:05:55 GMT Received: from aserv0122.oracle.com (aserv0122.oracle.com [141.146.126.236]) by aserp3030.oracle.com with ESMTP id 2w41whcqwd-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 08 Nov 2019 10:05:55 +0000 Received: from abhmp0009.oracle.com (abhmp0009.oracle.com [141.146.116.15]) by aserv0122.oracle.com (8.14.4/8.14.4) with ESMTP id xA8A5rF7005134; Fri, 8 Nov 2019 10:05:54 GMT Received: from kadam (/41.57.98.10) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Fri, 08 Nov 2019 02:05:52 -0800 Date: Fri, 8 Nov 2019 13:05:40 +0300 From: Dan Carpenter To: Mathieu Poirier Subject: Re: [PATCH -next] coresight: replicator: Fix missing spin_lock_init() Message-ID: <20191108100540.GQ10409@kadam> References: <20191106115651.113943-1-weiyongjun1@huawei.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9434 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1910280000 definitions=main-1911080099 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9434 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1011 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1910280000 definitions=main-1911080099 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191108_020617_422482_6F0AE2EE X-CRM114-Status: GOOD ( 23.29 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Suzuki K Poulose , Alexander Shishkin , Yabin Cui , kernel-janitors@vger.kernel.org, Linux Kernel Mailing List , Wei Yongjun , linux-arm-kernel Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Nov 07, 2019 at 11:47:11AM -0700, Mathieu Poirier wrote: > On Wed, 6 Nov 2019 at 04:57, Wei Yongjun wrote: > > > > The driver allocates the spinlock but not initialize it. > > Use spin_lock_init() on it to initialize it correctly. > > > > This is detected by Coccinelle semantic patch. > > > > Fixes: 0093875ad129 ("coresight: Serialize enabling/disabling a link device.") > > Signed-off-by: Wei Yongjun > > --- > > drivers/hwtracing/coresight/coresight-replicator.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/drivers/hwtracing/coresight/coresight-replicator.c b/drivers/hwtracing/coresight/coresight-replicator.c > > index 43304196a1a6..e7dc1c31d20d 100644 > > --- a/drivers/hwtracing/coresight/coresight-replicator.c > > +++ b/drivers/hwtracing/coresight/coresight-replicator.c > > @@ -248,6 +248,7 @@ static int replicator_probe(struct device *dev, struct resource *res) > > } > > dev->platform_data = pdata; > > > > + spin_lock_init(&drvdata->spinlock); > > I have applied both patches but removed the "Fixes" line since the > commit is only visible in my local coresight next tree. > Unless you rebase the tree, then the Fixes tag will still be valid. (Probably local implies you rebase it I guess). regards, dan carpenter _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel