[PATCH] ARM: dts: e60k02: Pass the memory unit address

[PATCH] ARM: dts: e60k02: Pass the memory unit address

[Fabio Estevam]

The following build warning is seen with W=1: 

  DTC     arch/arm/boot/dts/imx6sll-kobo-clarahd.dtb
arch/arm/boot/dts/e60k02.dtsi:51.9-53.4: Warning (unit_address_vs_reg): /memory: node has a reg or ranges property, but no unit name

Pass the memory unit address to fix the problem.

While at it, also pass 'device_type = "memory"', which is recommended
for memory nodes.

Signed-off-by: Fabio Estevam <festevam@gmail.com>
---
 arch/arm/boot/dts/e60k02.dtsi | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/e60k02.dtsi b/arch/arm/boot/dts/e60k02.dtsi
index 6472b056a001..a9433c8432a6 100644
--- a/arch/arm/boot/dts/e60k02.dtsi
+++ b/arch/arm/boot/dts/e60k02.dtsi
@@ -48,7 +48,8 @@
 		};
 	};
 
-	memory {
+	memory@80000000 {
+		device_type = "memory";
 		reg = <0x80000000 0x20000000>;
 	};
 
-- 
2.17.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH] ARM: dts: e60k02: Pass the memory unit address

[Andreas Kemnade]

On Fri,  8 Nov 2019 11:39:36 -0300
Fabio Estevam <festevam@gmail.com> wrote:

> The following build warning is seen with W=1: 
> 
>   DTC     arch/arm/boot/dts/imx6sll-kobo-clarahd.dtb
> arch/arm/boot/dts/e60k02.dtsi:51.9-53.4: Warning (unit_address_vs_reg): /memory: node has a reg or ranges property, but no unit name
> 
> Pass the memory unit address to fix the problem.
> 
> While at it, also pass 'device_type = "memory"', which is recommended
> for memory nodes.
> 
> Signed-off-by: Fabio Estevam <festevam@gmail.com>
> ---
As expected, it sitll works, no surprises. Thanks for cleaning up.

So I can give a
Tested-by: Andreas Kemnade <andreas@kemnade.info>

Regards,
Andreas

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH] ARM: dts: e60k02: Pass the memory unit address

[Shawn Guo]

On Fri, Nov 08, 2019 at 11:39:36AM -0300, Fabio Estevam wrote:
> The following build warning is seen with W=1: 
> 
>   DTC     arch/arm/boot/dts/imx6sll-kobo-clarahd.dtb
> arch/arm/boot/dts/e60k02.dtsi:51.9-53.4: Warning (unit_address_vs_reg): /memory: node has a reg or ranges property, but no unit name
> 
> Pass the memory unit address to fix the problem.
> 
> While at it, also pass 'device_type = "memory"', which is recommended
> for memory nodes.
> 
> Signed-off-by: Fabio Estevam <festevam@gmail.com>

Applied, thanks.

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel