From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,UNWANTED_LANGUAGE_BODY,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BAD31C43331 for ; Sun, 10 Nov 2019 12:44:11 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8BBA620869 for ; Sun, 10 Nov 2019 12:44:11 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="A2m2GUJ+"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="S5tCu1Q/" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8BBA620869 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Dwdz0U3glN4zUDluOzHgADJXq/o0zA03NCeCWaHDQrE=; b=A2m2GUJ+NqaP+w x263ookRtM2Iq9/oQ4n8TKxgDqvYTZPB/RxmOBro8T2GjiHFfEt0wuTrCKl48Zy7nnB0h7tAr2eHB OBzOMYR/gcsO977JoqddKxpHuBaF4t6P+B8UgRy0keVq1MtcJ4Cw4Umq9Bi99Uq5wS6ERsnfUWEri naHPSpwmr79/UcQx8GvqsXQ/HK41mHNky+nz6sfwguBOgblPv6PBYmdO3dlt8ROfHmUS7HHxSvU2o +Ogfi95xoLA2cwuda/Ehh8u7gOsxyxqimxi5ujNzISH9eN0sACFEKI0IB4KRhKYznpG7f2JlVGDYx Ew0vOsawm2b3/kXlKiXw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iTmZd-0000os-NL; Sun, 10 Nov 2019 12:44:09 +0000 Received: from mail-lj1-x242.google.com ([2a00:1450:4864:20::242]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iTmZb-0000nf-2Z for linux-arm-kernel@lists.infradead.org; Sun, 10 Nov 2019 12:44:08 +0000 Received: by mail-lj1-x242.google.com with SMTP id y23so10826401ljh.10 for ; Sun, 10 Nov 2019 04:44:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=y83C4uV1+CMS9qXxIDGEDkXZDlFcKiUT+tBB2iKcZ/8=; b=S5tCu1Q/bUWUzoqui0dPCRpuzi6ZO6mnhyySQUfJ8Wq0Sw21KjmuAhUeqMLtXFQIgp /CuDTn6oX6LgJcIkQQW5NO0JEqDaHfh8mS2lOf/KCLK8EERkNsE44C3on2wsOQ6pOjYl H1P/W6x5qGi+QAJOrQOiqlj/I9dcvNEwyBzIkvDXGk66zCb0DfYWInfROuSUe+q3W1+o 0Q6umV52sYXfDemaam8ueHnzdPNcWnEbzjGUDisxUgqNSmQ86L8i1l5CrRSN926q04c/ CAzAkuvfZm0OCMYchvxZJG7l7F2PDMbngOIXDx+prmkP2nYs6q7J7LhtafWXJgC2yANx RzPg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=y83C4uV1+CMS9qXxIDGEDkXZDlFcKiUT+tBB2iKcZ/8=; b=TmyD6VGWrTrXUqcY7FX7ImUFTvoZHL/QA6VOa8+hxfHCGH6Wwd0k7d/CjCVDGZJhEk iPhArW+p0LAbC0oWu588WTr6SYRyG5SHlE2LFi1ymqQ/D0dqJ6FZlNHX4HE2pYukXRy2 xL6OD/UpzONQWktShA2ozI461fPatWuufx6vg8fD3eE+o6yNFfSLxIJARGi9IS5de2Lq /XVJblylk1unAsopE04KhASreUa0AF28gRkudWj1HAtr2JIVh2r7BU74T04KFFtljN8c 1i25djoYKizM4P04sX2W+5kr3UfkoeLi2orM6prmShpd24HoWAWmrJw0CqQH5siS7lvg 6+6g== X-Gm-Message-State: APjAAAX2oEa5qqJEa4FsHEHRKo72lX6m9chON2RhtSretOPafTJcRQ9H JZIVyhm7QE52Al+6LQ6NnVY= X-Google-Smtp-Source: APXvYqxUIUlp45THMZfcuhEJlbzNkjAeA1+yMttaZdWaX6nYzo2jbjepxuvD6mbt0FR9mIQCgtKtxA== X-Received: by 2002:a2e:98d4:: with SMTP id s20mr13111304ljj.128.1573389841582; Sun, 10 Nov 2019 04:44:01 -0800 (PST) Received: from localhost.localdomain (h-98-128-228-153.NA.cust.bahnhof.se. [98.128.228.153]) by smtp.gmail.com with ESMTPSA id r7sm5377486ljc.74.2019.11.10.04.43.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 10 Nov 2019 04:44:00 -0800 (PST) From: Rikard Falkeborn To: megous@megous.com Subject: [PATCH v2] phy: allwinner: Fix GENMASK misuse Date: Sun, 10 Nov 2019 13:43:55 +0100 Message-Id: <20191110124355.1569-1-rikard.falkeborn@gmail.com> X-Mailer: git-send-email 2.24.0 In-Reply-To: <20191020134229.1216351-3-megous@megous.com> References: <20191020134229.1216351-3-megous@megous.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191110_044407_144126_F792E628 X-CRM114-Status: GOOD ( 10.74 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: mark.rutland@arm.com, devicetree@vger.kernel.org, arnd@arndb.de, gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, mripard@kernel.org, kishon@ti.com, paul.kocialkowski@bootlin.com, linux-sunxi@googlegroups.com, robh+dt@kernel.org, Rikard Falkeborn , tglx@linutronix.de, wens@csie.org, linux-arm-kernel@lists.infradead.org, icenowy@aosc.io Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Arguments are supposed to be ordered high then low. Fixes: a228890f9458 ("phy: allwinner: add phy driver for USB3 PHY on Allwinner H6 SoC") Signed-off-by: Rikard Falkeborn Tested-by: Ondrej Jirman --- v1->v2: Add fixes tax. Add Ondrejs Tested-by. No functional change. drivers/phy/allwinner/phy-sun50i-usb3.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/phy/allwinner/phy-sun50i-usb3.c b/drivers/phy/allwinner/phy-sun50i-usb3.c index 1169f3e83a6f..b1c04f71a31d 100644 --- a/drivers/phy/allwinner/phy-sun50i-usb3.c +++ b/drivers/phy/allwinner/phy-sun50i-usb3.c @@ -49,7 +49,7 @@ #define SUNXI_LOS_BIAS(n) ((n) << 3) #define SUNXI_LOS_BIAS_MASK GENMASK(5, 3) #define SUNXI_TXVBOOSTLVL(n) ((n) << 0) -#define SUNXI_TXVBOOSTLVL_MASK GENMASK(0, 2) +#define SUNXI_TXVBOOSTLVL_MASK GENMASK(2, 0) struct sun50i_usb3_phy { struct phy *phy; -- 2.24.0 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.7 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_ADSP_ALL, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 83A0CC35671 for ; Sat, 22 Feb 2020 23:42:12 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4B8FA20707 for ; Sat, 22 Feb 2020 23:42:12 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="mV48iWS+"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=megous.com header.i=@megous.com header.b="E6oq+VWE" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4B8FA20707 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=megous.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=YixuNUzHiibGrktHjqkuxlSWMdGIUQDaf8kLd+XOvOA=; b=mV48iWS+07UF4b mCG0fpJ6UFb0i54oRVwD5cq7NVv67d8ZqWXRoNJ7r0E06RCNheNoSz1+/YxUzgLrczA/9VqVr7cqP VLo9OwG5/Wvg7kw5UdprFGt0Y7qKuSxh4SWkLVZ9KRo8mM81+Ml+ChUwko+NP/cBg8DHheHWo3gwc xdmmZSOZ5k1CnMEublu66LNw4sTAUOQFvMfjINAaqWpRuc0r2aUiR5bkrPafrb2cOAoI+hOSz4LY+ Ch8pQQWoFZcmH7w2NyDtchHFhmL114k9VEQz7jN9tiN1ek3b+NuRfdn2fHSUlR3aX24w1gWo4qTkX ycQsb10iKROFqgS4AAeQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1j5ePT-0001q3-GY; Sat, 22 Feb 2020 23:42:11 +0000 Received: from vps.xff.cz ([195.181.215.36]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1j5ePP-0001pk-OP for linux-arm-kernel@lists.infradead.org; Sat, 22 Feb 2020 23:42:09 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=megous.com; s=mail; t=1582414925; bh=5x/5hihgQJXkHe3WSHjYc+7DcJv1HqvoY1dyl7I4obk=; h=From:To:Cc:Subject:Date:References:From; b=E6oq+VWEN7MxhcPR5cge8u8tgafKVhJmwFh1zOOPr1g1VcUpcW3ZPdDDAvGNsPfo3 lq0cfBuYtR4Yjpo+2u5TCuWqgTlpCGC9/YdI+K0vaUec683aX90UT+pvIQfpxn0fWS JZMy3HASj9pZSn4EWvntK3yNWLMYtWrJHQFK0G2E= From: Ondrej Jirman To: linux-usb@vger.kernel.org, megous@megous.com Subject: [PATCH v2 RESEND] phy: allwinner: Fix GENMASK misuse Date: Sun, 23 Feb 2020 00:41:25 +0100 Message-Id: <20191110124355.1569-1-rikard.falkeborn@gmail.com> In-Reply-To: <20191020134229.1216351-3-megous@megous.com> References: <20191020134229.1216351-3-megous@megous.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200222_154207_966258_3CC9023E X-CRM114-Status: UNSURE ( 8.52 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: mark.rutland@arm.com, devicetree@vger.kernel.org, arnd@arndb.de, gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, Rikard Falkeborn , kishon@ti.com, paul.kocialkowski@bootlin.com, linux-sunxi@googlegroups.com, robh+dt@kernel.org, mripard@kernel.org, tglx@linutronix.de, wens@csie.org, linux-arm-kernel@lists.infradead.org, icenowy@aosc.io Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Message-ID: <20200222234125.mfOZ6Qov6SX6EmL7slqrTkDBhKU0-MpNuF6rtnatOjc@z> From: Rikard Falkeborn Arguments are supposed to be ordered high then low. Fixes: a228890f9458 ("phy: allwinner: add phy driver for USB3 PHY on Allwinner H6 SoC") Signed-off-by: Rikard Falkeborn Tested-by: Ondrej Jirman Signed-off-by: Ondrej Jirman --- v1->v2: Add fixes tax. Add Ondrejs Tested-by. No functional change. This was last sent in Nov last year. I'm resending, because it probably got forgotten. The only change is adding my SoB, which I understand is required for the sender of the patch. drivers/phy/allwinner/phy-sun50i-usb3.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/phy/allwinner/phy-sun50i-usb3.c b/drivers/phy/allwinner/phy-sun50i-usb3.c index 1169f3e83a6f..b1c04f71a31d 100644 --- a/drivers/phy/allwinner/phy-sun50i-usb3.c +++ b/drivers/phy/allwinner/phy-sun50i-usb3.c @@ -49,7 +49,7 @@ #define SUNXI_LOS_BIAS(n) ((n) << 3) #define SUNXI_LOS_BIAS_MASK GENMASK(5, 3) #define SUNXI_TXVBOOSTLVL(n) ((n) << 0) -#define SUNXI_TXVBOOSTLVL_MASK GENMASK(0, 2) +#define SUNXI_TXVBOOSTLVL_MASK GENMASK(2, 0) struct sun50i_usb3_phy { struct phy *phy; -- 2.24.0 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel