From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.9 required=3.0 tests=DATE_IN_PAST_12_24, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 554B4C43331 for ; Tue, 12 Nov 2019 20:12:21 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 23D3D2067B for ; Tue, 12 Nov 2019 20:12:21 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Pa/Gnb3o" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 23D3D2067B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=davemloft.net Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Mime-Version:References:In-Reply-To: From:Subject:To:Message-Id:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=8gxpE9ZY7yuNxevrBXqpjug/MuwGjy0Wk0UuTNsPiIs=; b=Pa/Gnb3oj2MVrG iw7zIC5gZbqYlX5fv88lm3cNuAVmWnEdmSlTqItix/8Jf0w1OapOvk77O/3vLXaBepiQN06bnliYt XpyqVwVsEwZohs5IVZrDn4yXHYK8yFWWpRwD5/Is3tx2BWD5zbJ/ifAhpMIoMYkoYQbc0uSx7UCwW ISve29ztN+L9VNM9ag6kDdQv+D7qdQlHBotmBC6rfQZipJ562L7PROa/LB4Hc8s4yEfAKS8fXG76T LiAsIezC9+4Hj2KONGiwCoRKYCWcoZ6ovwMrV06YQAvi6GocjW/YaLdg4pIe5KT65lbY688d+VPVT p4VrjWz9Evi4POEzwJ7w==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iUcWQ-00082J-5a; Tue, 12 Nov 2019 20:12:18 +0000 Received: from shards.monkeyblade.net ([2620:137:e000::1:9]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iUcWN-00081r-66 for linux-arm-kernel@lists.infradead.org; Tue, 12 Nov 2019 20:12:16 +0000 Received: from localhost (unknown [IPv6:2601:601:9f00:1e2::d71]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id D1376154D250F; Tue, 12 Nov 2019 12:12:08 -0800 (PST) Date: Mon, 11 Nov 2019 15:14:35 -0800 (PST) Message-Id: <20191111.151435.931035548376130641.davem@davemloft.net> To: clabbe@baylibre.com Subject: Re: [PATCH] net: ethernet: dwmac-sun8i: Use the correct function in exit path From: David Miller In-Reply-To: <1573385448-30282-1-git-send-email-clabbe@baylibre.com> References: <1573385448-30282-1-git-send-email-clabbe@baylibre.com> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Tue, 12 Nov 2019 12:12:09 -0800 (PST) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191112_121215_226160_444A423E X-CRM114-Status: UNSURE ( 6.96 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: alexandre.torgue@st.com, netdev@vger.kernel.org, linux-sunxi@googlegroups.com, linux-kernel@vger.kernel.org, mripard@kernel.org, wens@csie.org, joabreu@synopsys.com, stable@vger.kernel.org, peppe.cavallaro@st.com, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org From: Corentin Labbe Date: Sun, 10 Nov 2019 11:30:48 +0000 > When PHY is not powered, the probe function fail and some resource are > still unallocated. > Furthermore some BUG happens: > dwmac-sun8i 5020000.ethernet: EMAC reset timeout > ------------[ cut here ]------------ > kernel BUG at /linux-next/net/core/dev.c:9844! > > So let's use the right function (stmmac_pltfr_remove) in the error path. > > Fixes: 9f93ac8d4085 ("net-next: stmmac: Add dwmac-sun8i") > Cc: # v4.15+ > Signed-off-by: Corentin Labbe Applied. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel