From: David Miller <davem@redhat.com>
To: Mark-MC.Lee@mediatek.com
Cc: mark.rutland@arm.com, andrew@lunn.ch,
jakub.kicinski@netronome.com, devicetree@vger.kernel.org,
netdev@vger.kernel.org, sean.wang@mediatek.com,
linux-kernel@vger.kernel.org, opensource@vdorst.com,
robh+dt@kernel.org, linux-mediatek@lists.infradead.org,
john@phrozen.org, matthias.bgg@gmail.com,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH net,v2 1/3] net: ethernet: mediatek: Integrate GDM/PSE setup operations
Date: Mon, 11 Nov 2019 21:56:17 -0800 (PST) [thread overview]
Message-ID: <20191111.215617.1625420574702786179.davem@redhat.com> (raw)
In-Reply-To: <20191111065129.30078-2-Mark-MC.Lee@mediatek.com>
From: MarkLee <Mark-MC.Lee@mediatek.com>
Date: Mon, 11 Nov 2019 14:51:27 +0800
> +static void mtk_gdm_config(struct mtk_eth *eth, u32 config)
> +{
> + int i;
> +
> + for (i = 0; i < MTK_MAC_COUNT; i++) {
> + u32 val = mtk_r32(eth, MTK_GDMA_FWD_CFG(i));
> +
> + /* default setup the forward port to send frame to PDMA */
> + val &= ~0xffff;
> +
> + /* Enable RX checksum */
> + val |= MTK_GDMA_ICS_EN | MTK_GDMA_TCS_EN | MTK_GDMA_UCS_EN;
> +
> + val |= config;
> +
> + mtk_w32(eth, val, MTK_GDMA_FWD_CFG(i));
> + }
> + /*Reset and enable PSE*/
Please put spaces before and after the comment sentence, like:
/* Reset and enable PSE */
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-11-12 5:58 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-11 6:51 [PATCH net,v2 0/3] Rework mt762x GDM setup flow MarkLee
2019-11-11 6:51 ` [PATCH net, v2 1/3] net: ethernet: mediatek: Integrate GDM/PSE setup operations MarkLee
2019-11-12 5:56 ` David Miller [this message]
2019-11-12 7:12 ` [PATCH net,v2 " mtk15127
2019-11-11 6:51 ` [PATCH net, v2 2/3] net: ethernet: mediatek: Refine the timing of GDM/PSE setup MarkLee
2019-11-11 6:51 ` [PATCH net, v2 3/3] net: ethernet: mediatek: Enable GDM GDMA_DROP_ALL mode MarkLee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191111.215617.1625420574702786179.davem@redhat.com \
--to=davem@redhat.com \
--cc=Mark-MC.Lee@mediatek.com \
--cc=andrew@lunn.ch \
--cc=devicetree@vger.kernel.org \
--cc=jakub.kicinski@netronome.com \
--cc=john@phrozen.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=matthias.bgg@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=opensource@vdorst.com \
--cc=robh+dt@kernel.org \
--cc=sean.wang@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).