From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D724AC43331 for ; Tue, 12 Nov 2019 05:58:28 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A353221783 for ; Tue, 12 Nov 2019 05:58:28 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="BVEc+auW"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="PwvL1UUn" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A353221783 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Mime-Version:References:In-Reply-To: From:Subject:To:Message-Id:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=x9bQLYCUY+PFFpZPEMne8xNJP2q/VCFh4Pbs+bejOL0=; b=BVEc+auW3DWZif XKyeufCjhtDvffDesWvUjPaPHeZnb4G+Kx+31GxKtb3idVssv3/A36a2zu1T3bfpeZORD3n7ZDWNj CNeOl/aA8rkFJPXzz0/psltxbcB/kj/oTTE/B39yyFSf7eSojL6gSvlcj5zho0CDWIEWWUDHi3rct x0MT9t1eBu+V/jWldhRrQ7u+9B//WeCFRW1W8t/fcUn1unovJW21jNnHBiXEW//V2YXAVodzss5Yc lAQRIvW9wlq05+RKk0xM4fLGSMeou5EuwW+YvkUYsxrffnCsTlfsW3I/4w7P/CQ6I5q6IjZEAl0E0 C0LwFXuNFTLIbOfYnn/w==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iUPC7-0007zf-4J; Tue, 12 Nov 2019 05:58:27 +0000 Received: from us-smtp-2.mimecast.com ([205.139.110.61] helo=us-smtp-delivery-1.mimecast.com) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iUPC3-0007yc-LL for linux-arm-kernel@lists.infradead.org; Tue, 12 Nov 2019 05:58:24 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1573538302; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=t4H1BAGawGahyIzPrHbrHyHMfWVwsFAeBKzU7Z42zAo=; b=PwvL1UUnniHO4BfnMV0ZVkOcXRSvT9r5juGZpPwyTAxsysieQvkrkynD395sQX7780gImT vroC85I79HqwzdsrzKsh2BceqT3r63oxz5JIIkpUjK7XlfJ4cuxGxxufkETAe07saGcxUI Nl0TzYDSwp8jz786IP53ud1Eql97DEw= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-50-OfrAog8PPI22IT-AmCI-Nw-1; Tue, 12 Nov 2019 00:56:27 -0500 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id C3645800C61; Tue, 12 Nov 2019 05:56:24 +0000 (UTC) Received: from localhost (ovpn-112-54.rdu2.redhat.com [10.10.112.54]) by smtp.corp.redhat.com (Postfix) with ESMTP id 5D2D860852; Tue, 12 Nov 2019 05:56:18 +0000 (UTC) Date: Mon, 11 Nov 2019 21:56:17 -0800 (PST) Message-Id: <20191111.215617.1625420574702786179.davem@redhat.com> To: Mark-MC.Lee@mediatek.com Subject: Re: [PATCH net,v2 1/3] net: ethernet: mediatek: Integrate GDM/PSE setup operations From: David Miller In-Reply-To: <20191111065129.30078-2-Mark-MC.Lee@mediatek.com> References: <20191111065129.30078-1-Mark-MC.Lee@mediatek.com> <20191111065129.30078-2-Mark-MC.Lee@mediatek.com> Mime-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-MC-Unique: OfrAog8PPI22IT-AmCI-Nw-1 X-Mimecast-Spam-Score: 0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191111_215823_778458_27392924 X-CRM114-Status: UNSURE ( 7.60 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: mark.rutland@arm.com, andrew@lunn.ch, jakub.kicinski@netronome.com, devicetree@vger.kernel.org, netdev@vger.kernel.org, sean.wang@mediatek.com, linux-kernel@vger.kernel.org, opensource@vdorst.com, robh+dt@kernel.org, linux-mediatek@lists.infradead.org, john@phrozen.org, matthias.bgg@gmail.com, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org From: MarkLee Date: Mon, 11 Nov 2019 14:51:27 +0800 > +static void mtk_gdm_config(struct mtk_eth *eth, u32 config) > +{ > + int i; > + > + for (i = 0; i < MTK_MAC_COUNT; i++) { > + u32 val = mtk_r32(eth, MTK_GDMA_FWD_CFG(i)); > + > + /* default setup the forward port to send frame to PDMA */ > + val &= ~0xffff; > + > + /* Enable RX checksum */ > + val |= MTK_GDMA_ICS_EN | MTK_GDMA_TCS_EN | MTK_GDMA_UCS_EN; > + > + val |= config; > + > + mtk_w32(eth, val, MTK_GDMA_FWD_CFG(i)); > + } > + /*Reset and enable PSE*/ Please put spaces before and after the comment sentence, like: /* Reset and enable PSE */ _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel