From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9413CC43331 for ; Mon, 11 Nov 2019 05:26:33 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6934920856 for ; Mon, 11 Nov 2019 05:26:33 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="EO7iayR6"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="Id2pwHg4" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6934920856 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=nZPC5wqWxQU1rsF8UygBIp122Nyni9lYjmJLYlINAtw=; b=EO7iayR64vuHsK 2SoJoo0slGsrkmceGTPMjhf3w+VGRM3bivo4a/OASN+Zkz3cDeTXI7FchBfqXEdNP2MkfkA65oXGH ZCDuM/9L5SQ+LXKQSi1szDfg1Amtzqy5UK7eioiXb2LQmUg50wuV0CzV2e17feFIxspX2iZTPEsz5 xs47S4gfU9s1AxLDQT806/IN3mFPHVJFQbST6qHudp03jMXqKApdjqMqSWrfRzq6rKC7uso4NsnFM YeZGIYMglPlQkXcpd/y2mgV/YM7/iDD0zz0ReNyTCxDIHxUoSuB5cetjc3qI6XZARLmZgxk+YPPNB T8O3hhpIHsyqSXR9+LFQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iU2Dg-0001B9-PN; Mon, 11 Nov 2019 05:26:32 +0000 Received: from mail-pl1-x643.google.com ([2607:f8b0:4864:20::643]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iU2Dd-00019q-4q for linux-arm-kernel@lists.infradead.org; Mon, 11 Nov 2019 05:26:30 +0000 Received: by mail-pl1-x643.google.com with SMTP id w8so7331656plq.5 for ; Sun, 10 Nov 2019 21:26:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=j+5DoLx/+5d+nBT588P2rdKPpi4fh8lF1dO9cEj8nag=; b=Id2pwHg4oT/8rPULgYGnoGFCJ/96XHV7i3So7ZiqX8FDx9xxRUtyw/bMtvMWmQ2M6C KZFSXVrxv62Q05jfMm9JFmCUIC4mq4fe1hC4wl8TRyF8hETO54CSz+CeM15rZ6d3/RDp wf34F/PGXe6ZDZPEPLXgM2BA067vDkUmtZG5A+oIMopscUboWUo5319m8R6+5+K1Net1 JLuB2Vuoqgk8OThn3x23hOv8/QgXYFDKTomhC8DIznN9FuDgxq0Q9WmRHY5Y5HVJ5AJF diWZWul2JiDpSSJTY36fOyjYArnlcZwGuNan8NN8NPQz6cIrw4f+8nX9VsdMTKHDXfRT 9dIQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=j+5DoLx/+5d+nBT588P2rdKPpi4fh8lF1dO9cEj8nag=; b=MI5SPeo3+ekFe7HuPGKiXusf60xhJzJmzp+hr1k7kf2vfRzx4n+ecJtrOEXqmOWAEg nurX9Ii7417pEjqVp9fd1k8QxRoufRkLTwLjrn7BhJKpTxbw0Cm7RxqUtF/qK4NFColt l5fRLY25jVZpWEltOm9KSL/y3Myv4DSJYZkRlwxv7TPYOM4REja43rOP3IfUY/anQ8Ds 5sAWnvUM8AGxqdQyaSdxIdRCOdAvoaOEX9VmmQgjEwdFqmKA+GHDuwR/cEB/9z9uzixT DuKFhpYurpq6hIbOIWOPflOz2g7xouHYhpgHQJ2WlTGaKiPOumxbA5yNTxeNLVm/AieE U6qA== X-Gm-Message-State: APjAAAVOiwoNmN643AndRTZK8sd6cCrjCjLM6G2QzGNpAKsx+5sNZM8m fJ0bwKt8l22tDT0GZvz+a4sj X-Google-Smtp-Source: APXvYqwmHEbXyu5c91D+UGBVYPGe00SdKoaGJbfYT43txJuTVOANtSTCgCHvRZXN42W57SwBlvskWQ== X-Received: by 2002:a17:902:322:: with SMTP id 31mr13803033pld.293.1573449988238; Sun, 10 Nov 2019 21:26:28 -0800 (PST) Received: from Mani-XPS-13-9360 ([2409:4072:6309:fffb:304b:b40d:24e5:f9a8]) by smtp.gmail.com with ESMTPSA id x190sm14427837pfc.89.2019.11.10.21.26.22 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sun, 10 Nov 2019 21:26:27 -0800 (PST) Date: Mon, 11 Nov 2019 10:56:20 +0530 From: Manivannan Sadhasivam To: Kever Yang Subject: Re: [PATCH 2/3] arm64: dts: rk3399-rock960: add vdd_log Message-ID: <20191111052620.GA3858@Mani-XPS-13-9360> References: <20191111005158.25070-1-kever.yang@rock-chips.com> <20191111005158.25070-2-kever.yang@rock-chips.com> <20191111052232.GA2842@Mani-XPS-13-9360> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20191111052232.GA2842@Mani-XPS-13-9360> User-Agent: Mutt/1.9.4 (2018-02-28) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191110_212629_216718_56890ED2 X-CRM114-Status: GOOD ( 16.91 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , devicetree@vger.kernel.org, heiko@sntech.de, linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org, Rob Herring , Jagan Teki , Ezequiel Garcia , linux-arm-kernel@lists.infradead.org, Akash Gajjar Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Nov 11, 2019 at 10:52:32AM +0530, Manivannan Sadhasivam wrote: > Hi Kever, > > On Mon, Nov 11, 2019 at 08:51:57AM +0800, Kever Yang wrote: > > Add vdd_log node according to rock960 schematic V13. > > Forgot to mention that rk3399-rock960.dtsi is common for both Rock960 Model A and Ficus boards. So the commit message should mention it clearly. Otherwise people will get confused that the patch is only affecting Rock960 boards. Thanks, Mani > > Signed-off-by: Kever Yang > > --- > > > > arch/arm64/boot/dts/rockchip/rk3399-rock960.dtsi | 12 ++++++++++++ > > 1 file changed, 12 insertions(+) > > > > diff --git a/arch/arm64/boot/dts/rockchip/rk3399-rock960.dtsi b/arch/arm64/boot/dts/rockchip/rk3399-rock960.dtsi > > index c7d48d41e184..73afee257115 100644 > > --- a/arch/arm64/boot/dts/rockchip/rk3399-rock960.dtsi > > +++ b/arch/arm64/boot/dts/rockchip/rk3399-rock960.dtsi > > @@ -76,6 +76,18 @@ > > regulator-always-on; > > vin-supply = <&vcc5v0_sys>; > > }; > > + > > + vdd_log: vdd-log { > > + compatible = "pwm-regulator"; > > + pwms = <&pwm2 0 25000 1>; > > + regulator-name = "vdd_log"; > > + regulator-always-on; > > + regulator-boot-on; > > + regulator-min-microvolt = <800000>; > > + regulator-max-microvolt = <1400000>; > > + regulator-init-microvolt = <950000>; > > The default value seems to be 0.9v as per both Rock960 and Ficus schematics. > > Other than that, > Acked-by: Manivannan Sadhasivam > > Thanks, > Mani > > > + vin-supply = <&vcc_sys>; > > + }; > > }; > > > > &cpu_l0 { > > -- > > 2.17.1 > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel