From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 98D60C43331 for ; Mon, 11 Nov 2019 17:23:15 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 698A0214DB for ; Mon, 11 Nov 2019 17:23:15 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="gaJtKTSw"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="X/LzmRNI" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 698A0214DB Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=947qGLW618ECjTYIi0M8exaD2eElYPs+wjktP671Rwk=; b=gaJtKTSwxTUJSA xXNnFM/HffWFRYZl8ggaxtFUmO5KDW5k2ZeRWeR8kO2QjraBzHu/lWulP69zab19yDZsgDyydX3AW 1QwjtS1yaxjOx+aiuRzuujw0XbDv4N4bjWhkjRq6NVgGs250agmT/vpy4GPm64SDtvufLNicUSCpL YKJ5d4uVEcA17uck8qq7gkPg5nHoyYpg8wZ1ZBBUJtpuHUF7L5ewaX5o1h7ipUroZ24yBY1nwSmUa ysfQwRjdsEHtQ0sk7AhtGZp4IjIza64FGKhrCkYX3h2t75RI53Ds27mMr5UW8mG+j79q4Ok9yaEqu kuIcXjP3RJjKQ6fHEmIg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iUDPB-0006Uy-Jx; Mon, 11 Nov 2019 17:23:09 +0000 Received: from mail-pg1-x541.google.com ([2607:f8b0:4864:20::541]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iUDP9-0006U9-1k for linux-arm-kernel@lists.infradead.org; Mon, 11 Nov 2019 17:23:08 +0000 Received: by mail-pg1-x541.google.com with SMTP id z188so3923527pgb.1 for ; Mon, 11 Nov 2019 09:23:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=yAajaC8HCWYzucX9F7lpdzKRK9O4DP5SS69z8MpuzC8=; b=X/LzmRNI+PAfGCx7iOXc7jITwTbPHloj6W9cE45iZE62pceyrxHDPEHiavfj9tEFm4 3ssTDoHViE0PIaYRTxiES+N/vQ0V6XBCRSxJLkNHA5EmXVvGMUKq6TH0JVEbtbv7eJIs og7HVJoMSxXZSuRdEpfAiyzG2OcgsCx2ssepg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=yAajaC8HCWYzucX9F7lpdzKRK9O4DP5SS69z8MpuzC8=; b=oMo1QBeU3/7amtabuhZQFqZ69xpK+Tl96aCcFREC9hYtgno7UJ9sII0lJnZcCQJldv /pEsguGraDOnip86eR5xW5Bg50+fmCXn1KukOGWUPXpDzyJXA0ChHijg4iQM7olg5xgQ AUB3uRX4BMpTLHoOMoRgVm+QKRj7SeRGzqBnt9F/BJLeCtxF0AtUgP4JbJ5XVxqcfT3f Plj0T9qwgX9NM8jjwBvqlpEsU+IbLJR5kCFUIoFZmxQBfCJK6hsYnlGMz92+64tVlO6b Rvp9WDkfKC2oMio4T+FhvaTGmMFnAzEQ1GDiwStP9XbbPQKkgOIblGV9VBlGczDywP9u HkCQ== X-Gm-Message-State: APjAAAWJjb5YA/J8mTgEnYWTD++KvmDbg9jgyjTBP6eCh9ij+QFw4xUn 1Odinq8F01jI8HbdnYBpth/WYw== X-Google-Smtp-Source: APXvYqyYRSzpwUPLuEiDxWQRl2mmu7HM3K81RSwKffyFA1Sp64Zbaq8qhH85VUnK4TNVxH3gOyo1gQ== X-Received: by 2002:a17:90a:5d0e:: with SMTP id s14mr85161pji.55.1573492985697; Mon, 11 Nov 2019 09:23:05 -0800 (PST) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id o15sm22800000pgn.49.2019.11.11.09.23.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 11 Nov 2019 09:23:04 -0800 (PST) Date: Mon, 11 Nov 2019 09:23:03 -0800 From: Kees Cook To: Geert Uytterhoeven Subject: Re: [PATCH v2 11/29] vmlinux.lds.h: Replace RODATA with RO_DATA Message-ID: <201911110922.17A2112B0@keescook> References: <20191011000609.29728-1-keescook@chromium.org> <20191011000609.29728-12-keescook@chromium.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191111_092307_095103_A4C0EDEB X-CRM114-Status: GOOD ( 15.68 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Linux-Arch , linux-s390 , Michal Simek , the arch/x86 maintainers , "linux-ia64@vger.kernel.org" , linux-c6x-dev@linux-c6x.org, Arnd Bergmann , linux-xtensa@linux-xtensa.org, Michael Ellerman , Dave Hansen , Heiko Carstens , linuxppc-dev , Yoshinori Sato , Borislav Petkov , Parisc List , Andy Lutomirski , alpha , Linux Kernel Mailing List , Rick Edgecombe , Will Deacon , Linux ARM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Nov 11, 2019 at 05:58:06PM +0100, Geert Uytterhoeven wrote: > Hi Kees, > > On Fri, Oct 11, 2019 at 2:07 AM Kees Cook wrote: > > There's no reason to keep the RODATA macro: replace the callers with > > the expected RO_DATA macro. > > > > Signed-off-by: Kees Cook > > --- > > arch/alpha/kernel/vmlinux.lds.S | 2 +- > > arch/ia64/kernel/vmlinux.lds.S | 2 +- > > arch/microblaze/kernel/vmlinux.lds.S | 2 +- > > arch/mips/kernel/vmlinux.lds.S | 2 +- > > arch/um/include/asm/common.lds.S | 2 +- > > arch/xtensa/kernel/vmlinux.lds.S | 2 +- > > include/asm-generic/vmlinux.lds.h | 4 +--- > > 7 files changed, 7 insertions(+), 9 deletions(-) > > Somehow you missed: > > arch/m68k/kernel/vmlinux-std.lds: RODATA > arch/m68k/kernel/vmlinux-sun3.lds: RODATA Argh. I've sent a patch; sorry and thanks for catching this. For my own cross-build testing, which defconfig targets will hit these two linker scripts? -Kees > > Leading to build failures in next-20191111: > > /opt/cross/kisskb/gcc-4.6.3-nolibc/m68k-linux/bin/m68k-linux-ld:./arch/m68k/kernel/vmlinux.lds:29: > syntax error > make[1]: *** [/kisskb/src/Makefile:1075: vmlinux] Error 1 > > Reported-by: noreply@ellerman.id.au > http://kisskb.ellerman.id.au/kisskb/buildresult/14022846/ > > Gr{oetje,eeting}s, > > Geert > > > -- > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org > > In personal conversations with technical people, I call myself a hacker. But > when I'm talking to journalists I just say "programmer" or something like that. > -- Linus Torvalds -- Kees Cook _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel