From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 304AFC17446 for ; Mon, 11 Nov 2019 14:37:47 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 00ABB222C1 for ; Mon, 11 Nov 2019 14:37:47 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="ZR9je3+N"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="vfXZ5zZo" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 00ABB222C1 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Z632NKb5fFW3r5y6udn/+HoEPEfDDY6eoyfcc6FFNDU=; b=ZR9je3+NA6MgKj w83NlVZnG8tmZ3rHC7ZkJc6AZ/v4v+hvs9OzSkZ+qHz13uolQSk6beXAVqA53LzinThDzHHUNrL3b 8shlXhV/CivOk4FaXBUQRhzllLe7u4Nkjn9SGdhbKmMOr+AsC2sU8gFxUMczA8BxHSUaxAKAGZlPV EwlbnVnNi7RPa6tbjKVTB/yeM6S3j9IuJs9eaV4FbtzimYy+Pd5OT7h+Pu3Q57AJPKFjM/iWdLX+Z P5FQTXKmelaQPAvBP4yDRBtIfpTb7RF1bC2lcA8ZhRyKkfBAAL2XqBaK+U64WpkrK70jzAiO4z8B3 Ozpm/efSZD0re0uJTZLA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iUAp6-0007cW-6A; Mon, 11 Nov 2019 14:37:44 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iUAp2-0007bk-VB for linux-arm-kernel@lists.infradead.org; Mon, 11 Nov 2019 14:37:42 +0000 Received: from willie-the-truck (236.31.169.217.in-addr.arpa [217.169.31.236]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 956B321655; Mon, 11 Nov 2019 14:37:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1573483060; bh=zRua+W/OXpoT6rPkS0FoAqe1tWUfeIAMJIZnqn4qqxg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=vfXZ5zZoDzwQT5hwJ2MVW16ffjW1d5UUDhDCRgrE7mDMbtIXhRCyQ7immT/ZJpIPg vl88r5ejbTpLGm/AhRMEZ5CGznC1t4UG6ai2DtFCLzBCpzbLaoe2W6KztHJtf0XMnJ UnDcprY4jGSG+lXaW9Ld1kPpDSFuawDnFa6WuOGQ= Date: Mon, 11 Nov 2019 14:37:36 +0000 From: Will Deacon To: Jean-Philippe Brucker Subject: Re: [PATCH 2/2] iommu/arm-smmu: Remove duplicate error message Message-ID: <20191111143736.GB10488@willie-the-truck> References: <20191111111721.4145919-1-jean-philippe@linaro.org> <20191111111721.4145919-2-jean-philippe@linaro.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20191111111721.4145919-2-jean-philippe@linaro.org> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191111_063741_038988_016E075C X-CRM114-Status: GOOD ( 17.14 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: iommu@lists.linux-foundation.org, robin.murphy@arm.com, joro@8bytes.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Nov 11, 2019 at 12:17:21PM +0100, Jean-Philippe Brucker wrote: > Since commit 7723f4c5ecdb ("driver core: platform: Add an error message > to platform_get_irq*()"), platform_get_irq() displays an error when the > IRQ isn't found. Remove the error print from the SMMU driver. Note the > slight change of behaviour: no message is printed if platform_get_irq() > returns -EPROBE_DEFER, which probably doesn't concern the SMMU. > > Fixes: 7723f4c5ecdb ("driver core: platform: Add an error message to platform_get_irq*()") > Signed-off-by: Jean-Philippe Brucker > --- > drivers/iommu/arm-smmu.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/iommu/arm-smmu.c b/drivers/iommu/arm-smmu.c > index 7c503a6bc585..6f676686752c 100644 > --- a/drivers/iommu/arm-smmu.c > +++ b/drivers/iommu/arm-smmu.c > @@ -2062,10 +2062,8 @@ static int arm_smmu_device_probe(struct platform_device *pdev) > for (i = 0; i < num_irqs; ++i) { > int irq = platform_get_irq(pdev, i); > > - if (irq < 0) { > - dev_err(dev, "failed to get irq index %d\n", i); > + if (irq < 0) > return -ENODEV; > - } > smmu->irqs[i] = irq; > } Acked-by: Will Deacon Thanks, Will _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel