From: Denis 'GNUtoo' Carikli <GNUtoo@cyberdimension.org>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: Mark Rutland <mark.rutland@arm.com>,
Paul Kocialkowski <paul.kocialkowski@bootlin.com>,
Rob Herring <robh+dt@kernel.org>,
Simon Shields <simon@lineageos.org>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] ARM: dts: add touchkey nodes for midas
Date: Mon, 11 Nov 2019 19:52:19 +0100 [thread overview]
Message-ID: <20191111195219.768cee6d@primarylaptop.localdomain> (raw)
In-Reply-To: <CAJKOXPcuPQa-jVtFMfiseuXq3P=mxc6DecCCj_j-y2NauMqTdA@mail.gmail.com>
[-- Attachment #1.1: Type: text/plain, Size: 1172 bytes --]
On Wed, 7 Aug 2019 10:13:04 +0200
Krzysztof Kozlowski <krzk@kernel.org> wrote:
Sorry for the delay.
I had to find and buy N710x to get faster turnarounds for testing as
before I had to borrow an N7100 from a friend to do the testing there
as well.
I've addressed most of the comments and I'll send a v2 soon.
> > diff --git a/arch/arm/boot/dts/exynos4412-galaxy-s3.dtsi
> > b/arch/arm/boot/dts/exynos4412-galaxy-s3.dtsi index
> > ce87d2ff27aa..e71f103ab940 100644 ---
> > a/arch/arm/boot/dts/exynos4412-galaxy-s3.dtsi +++
> > b/arch/arm/boot/dts/exynos4412-galaxy-s3.dtsi @@ -166,5 +166,9 @@
> > &s5c73m3 {
> > standby-gpios = <&gpm0 1 GPIO_ACTIVE_LOW>; /* ISP_STANDBY
> > */ vdda-supply = <&ldo17_reg>;
> > +};
> > +
> > +&touchkey_reg {
> > + gpio = <&gpm0 0 GPIO_ACTIVE_HIGH>;
>
> You break existing code...
I didn't understand this comment.
> Let's keep the name as in schematics - "LED_VDD_3.3V"... which brings
> us to the question is it really needed for touch keys? or for display
> panel?
On I9300, I9305 and n7105 without the touchkey_reg node, the keys still
work but the keys backlight doesn't.
Denis.
[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-11-11 18:52 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-06 16:57 [PATCH] ARM: dts: add touchkey nodes for midas Denis 'GNUtoo' Carikli
2019-08-07 7:09 ` Paul Kocialkowski
2019-08-07 8:13 ` Krzysztof Kozlowski
2019-11-11 18:52 ` Denis 'GNUtoo' Carikli [this message]
2019-11-12 1:25 ` Krzysztof Kozlowski
2019-11-12 15:50 ` Denis 'GNUtoo' Carikli
2019-11-12 15:53 ` [PATCH][v2] ARM: dts: exynos: midas: add support for the touch-sensitive buttons Denis 'GNUtoo' Carikli
2019-11-13 13:18 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191111195219.768cee6d@primarylaptop.localdomain \
--to=gnutoo@cyberdimension.org \
--cc=krzk@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=paul.kocialkowski@bootlin.com \
--cc=robh+dt@kernel.org \
--cc=simon@lineageos.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox