From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E0A8DC43331 for ; Tue, 12 Nov 2019 05:36:46 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id AF7D62084F for ; Tue, 12 Nov 2019 05:36:46 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="hEw+BP4o"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="sP/sZWa6" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AF7D62084F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=xzFd5MGKN7eVr5Ce2aQmABpWQtZTmWa4N4vjDJjCgpM=; b=hEw+BP4oICG1Su B5P/Vh7hSuLYi4Vi5kuOLZjOrSHe10mc7bL6wcCE59pENSl1Y2Euv3BiQXREXUm+7Zbouz6sa/Z8R xaHY/xH/tMY5Z9jCL7qGWLoBbD45o21A3v7+XKZz4JGY6uXDTTqpRS+DK9UbweSr5njuR4/VMFzqZ CwS7EZdfkQ2Qlr9+lOmDG0HSdfx+rsT4UwvfZBBW4nIXf5CV+Ac79v/oMPJnJI7NpBxjKH9y4sj7P 3BsZGKM6aaKorLMHmJriM/JwmPWPPEcHJd3Nk2yngl/LzlEwpV++8blXCbldFU1I/Pn2pZ7R1cFtJ YKsNmBBpJ2sqDnjzER4A==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iUOr7-0007yC-Jf; Tue, 12 Nov 2019 05:36:45 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iUOqo-0007ig-JD for linux-arm-kernel@lists.infradead.org; Tue, 12 Nov 2019 05:36:28 +0000 Received: from localhost (unknown [122.167.70.123]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 6960321783; Tue, 12 Nov 2019 05:36:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1573536986; bh=YDjjnafho2uCvMpxMXlnLJhhfTeoSuyoFzfDVXn7/m4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=sP/sZWa6JWAiI7hq87AEWqr9AfSulRdI9YTrCKxSrQ9hoL4y7OXcCBvFDo6lhJO0f FeJ/Vqsm9SzcuKMOUI1LrLDl4Fp3KOIMDqB1bOIZf5z1Xn5+3hQ0ld7AfxnpvhMfIT NS+jfbiH+eK3W0HryxKa7RJk06UWxK51nrET6tF0= Date: Tue, 12 Nov 2019 11:06:21 +0530 From: Vinod Koul To: Peter Ujfalusi Subject: Re: [PATCH v4 12/15] dmaengine: ti: New driver for K3 UDMA - split#4: dma_device callbacks 1 Message-ID: <20191112053621.GW952516@vkoul-mobl> References: <20191101084135.14811-1-peter.ujfalusi@ti.com> <20191101084135.14811-13-peter.ujfalusi@ti.com> <20191111060943.GQ952516@vkoul-mobl> <6d73f6e1-6d85-d468-2e69-47d36ed75807@ti.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <6d73f6e1-6d85-d468-2e69-47d36ed75807@ti.com> User-Agent: Mutt/1.12.1 (2019-06-15) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191111_213626_723158_70191412 X-CRM114-Status: UNSURE ( 9.93 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: nm@ti.com, devicetree@vger.kernel.org, grygorii.strashko@ti.com, lokeshvutla@ti.com, j-keerthy@ti.com, linux-kernel@vger.kernel.org, t-kristo@ti.com, tony@atomide.com, robh+dt@kernel.org, ssantosh@kernel.org, dmaengine@vger.kernel.org, dan.j.williams@intel.com, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 11-11-19, 12:29, Peter Ujfalusi wrote: > On 11/11/2019 8.09, Vinod Koul wrote: > > On 01-11-19, 10:41, Peter Ujfalusi wrote: > >> +static enum dma_status udma_tx_status(struct dma_chan *chan, > >> + dma_cookie_t cookie, > >> + struct dma_tx_state *txstate) > >> +{ > >> + struct udma_chan *uc = to_udma_chan(chan); > >> + enum dma_status ret; > >> + unsigned long flags; > >> + > >> + spin_lock_irqsave(&uc->vc.lock, flags); > >> + > >> + ret = dma_cookie_status(chan, cookie, txstate); > >> + > >> + if (!udma_is_chan_running(uc)) > >> + ret = DMA_COMPLETE; > > > > so a paused channel will result in dma complete status? > > The channel is still enabled (running), the pause only sets a bit in the > channel's real time control register. Okay and which cases will channel not be running i.e., you return DMA_COMPLETE above? -- ~Vinod _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel