From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 30C49C43331 for ; Tue, 12 Nov 2019 14:53:13 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 04BA420656 for ; Tue, 12 Nov 2019 14:53:12 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="AHA9VSsG"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=emlid.com header.i=@emlid.com header.b="x4rwdkLh" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 04BA420656 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=emlid.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=tbudAnwxN+2gE+RA5kmzhrBU2PM0FfTBsnXa1R7Cf5g=; b=AHA9VSsGzoT0Wm ZkwiD5MQRQ/BvRXTI+IihYiVkZ4j8Jk11G4tHM/xcxrpE3BV3fSCUizacRrL4gjdcsGbCj+iWscWf 5cSmR+o+DaLV17859WXsKu1CLZAwjU2awu4f4vD9GHRXwOKHvInsvuLJRmoNPAMK4TOJFx9RGoL6f kvVHDtcAS92WooBmqbpzx8QxGRXBAnYJDleHiueZ+PdPDWWHb5NVojHeiUFlvFOY+aLLYVZz8/bT2 bBMVvmX97fGzQJAht2mOyaXH1V7Qtqz/HpWZfS/fTnkgKTJ4CFdb+2pxZcAuYp0iCrbQTrzFz2ANZ bRXCZduCfXZ7Kxjks7zA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iUXXc-0001QH-EN; Tue, 12 Nov 2019 14:53:12 +0000 Received: from forward106o.mail.yandex.net ([2a02:6b8:0:1a2d::609]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iUXXW-0001PP-Tb for linux-arm-kernel@lists.infradead.org; Tue, 12 Nov 2019 14:53:10 +0000 Received: from mxback16g.mail.yandex.net (mxback16g.mail.yandex.net [IPv6:2a02:6b8:0:1472:2741:0:8b7:316]) by forward106o.mail.yandex.net (Yandex) with ESMTP id 1A4425061C92; Tue, 12 Nov 2019 17:52:58 +0300 (MSK) Received: from sas2-44d129ed7200.qloud-c.yandex.net (sas2-44d129ed7200.qloud-c.yandex.net [2a02:6b8:c08:ff0a:0:640:44d1:29ed]) by mxback16g.mail.yandex.net (nwsmtp/Yandex) with ESMTP id SwALCUodYR-qvwaMIoN; Tue, 12 Nov 2019 17:52:58 +0300 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=emlid.com; s=mail; t=1573570378; bh=nJd0QZf/zaK4AYwVeNbtQGugkagOugqSjNxvqmGOLUQ=; h=In-Reply-To:Subject:Cc:To:From:References:Date:Message-ID; b=x4rwdkLhN7Ci4+tWF+Gz36mv5L/nuR75VHzrDVw6k945kna7XwdQOa+l4Njk6293S 7Igs89T1TQV1ZrmltwHAvfw24oBrxNBXIroALQ5a4qFaQYHAoJY0Dp/zuA37a8Xt8a 5lLrU3UNO181Uo4acOqRbY7xVbSQj1c75c21cAZk= Authentication-Results: mxback16g.mail.yandex.net; dkim=pass header.i=@emlid.com Received: by sas2-44d129ed7200.qloud-c.yandex.net (smtp/Yandex) with ESMTPSA id pyNTTv5nTB-qu0atVp8; Tue, 12 Nov 2019 17:52:56 +0300 (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client certificate not present) Date: Tue, 12 Nov 2019 17:52:55 +0300 From: Georgii Staroselskii To: Maxime Ripard Subject: Re: [PATCH 2/2] arm: dts: sunxi: Add Neutis N5H3 support Message-ID: <20191112145255.GA3812@softcrasher> References: <1573048998-8913-1-git-send-email-georgii.staroselskii@emlid.com> <1573048998-8913-3-git-send-email-georgii.staroselskii@emlid.com> <20191112121558.GZ4345@gilmour.lan> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20191112121558.GZ4345@gilmour.lan> User-Agent: Mutt/1.5.24 (2015-08-30) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191112_065307_340272_39A1B6C0 X-CRM114-Status: GOOD ( 23.29 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: mark.rutland@arm.com, linux-sunxi@googlegroups.com, georgii.staroselskii@emlid.com, wens@csie.org, robh+dt@kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Nov 12, 2019 at 01:15:58PM +0100, Maxime Ripard wrote: > Hi, > Hi! > On Wed, Nov 06, 2019 at 05:03:18PM +0300, Georgii Staroselskii wrote: > > Emlid Neutis N5H3 is a version of Emlid Neutis SoM with H3 instead of H5 > > inside. > > > > 6eeb4180d4b9 ("ARM: dts: sunxi: h3-h5: Add Bananapi M2+ v1.2 device") > > was used as reference. > > > > Signed-off-by: Georgii Staroselskii > > --- > > arch/arm/boot/dts/Makefile | 1 + > > .../dts/sun8i-h3-emlid-neutis-n5h3-devboard.dts | 61 ++++++++++++++++++++++ > > arch/arm/boot/dts/sun8i-h3-emlid-neutis-n5h3.dtsi | 11 ++++ > > 3 files changed, 73 insertions(+) > > create mode 100644 arch/arm/boot/dts/sun8i-h3-emlid-neutis-n5h3-devboard.dts > > create mode 100644 arch/arm/boot/dts/sun8i-h3-emlid-neutis-n5h3.dtsi > > > > diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile > > index 3f13b88..c997b0c 100644 > > --- a/arch/arm/boot/dts/Makefile > > +++ b/arch/arm/boot/dts/Makefile > > @@ -1119,6 +1119,7 @@ dtb-$(CONFIG_MACH_SUN8I) += \ > > sun8i-h3-orangepi-plus2e.dtb \ > > sun8i-h3-orangepi-zero-plus2.dtb \ > > sun8i-h3-rervision-dvk.dtb \ > > + sun8i-h3-emlid-neutis-n5h3-devboard.dtb \ > > There's no need to duplicate the H3 in the name, we can just call it > > sun8i-h3-emlid-neutis-n5-devboard.dts > > Unless you expect some other boards named in a similar matter? > The thing is that Neutis N5H3 is the name of the board. So I guess it makes sense to let this name be the part of the dts as well. > > sun8i-r16-bananapi-m2m.dtb \ > > sun8i-r16-nintendo-nes-classic.dtb \ > > sun8i-r16-nintendo-super-nes-classic.dtb \ > > diff --git a/arch/arm/boot/dts/sun8i-h3-emlid-neutis-n5h3-devboard.dts b/arch/arm/boot/dts/sun8i-h3-emlid-neutis-n5h3-devboard.dts > > new file mode 100644 > > index 00000000..3b68750 > > --- /dev/null > > +++ b/arch/arm/boot/dts/sun8i-h3-emlid-neutis-n5h3-devboard.dts > > @@ -0,0 +1,61 @@ > > +// SPDX-License-Identifier: GPL-2.0-or-later OR MIT > > +/* > > + * DTS for Emlid Neutis N5 Dev board. > > + * > > + * Copyright (C) 2019 Georgii Staroselskii > > + */ > > + > > +/dts-v1/; > > + > > +#include "sun8i-h3-emlid-neutis-n5h3.dtsi" > > + > > +/ { > > + model = "Emlid Neutis N5H3 Developer board"; > > + compatible = "emlid,neutis-n5h3-devboard", > > + "emlid,neutis-n5h3", > > + "allwinner,sun8i-h3"; > > Same remarks for the compatible, we have the h3 compatible here to > differentiate between the two. > > You should also document this combination to > Documentation/devicetree/bindings/arm/sunxi.yaml. > Thanks, will do. > > + > > + vdd_cpux: gpio-regulator { > > + compatible = "regulator-gpio"; > > + regulator-name = "vdd-cpux"; > > + regulator-type = "voltage"; > > + regulator-boot-on; > > + regulator-always-on; > > + regulator-min-microvolt = <1100000>; > > + regulator-max-microvolt = <1300000>; > > + regulator-ramp-delay = <50>; /* 4ms */ > > + gpios = <&r_pio 0 6 GPIO_ACTIVE_HIGH>; /* PL6 */ > > + gpios-states = <0x1>; > > + states = <1100000 0x0 > > + 1300000 0x1>; > > While DTC outputs the same thing, and it works, you should make this > an array of 2 items of 2 cells, instead of a array of 1 item of 4 > cells. > > Like this: states = <1100000 0x0>, <1300000 0x1>; > > While this doesn't change anything with DTC, other cases (like DT > validation) care about this. > Thank you! > Look good otherwise. I have spotted a couple of issues with the DTSI that I'm going to address in V2. Thanks for the review. > Maxime _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel