From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EAF93C43331 for ; Wed, 13 Nov 2019 09:48:16 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C01DB20818 for ; Wed, 13 Nov 2019 09:48:16 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="hA/Z6OwC" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C01DB20818 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=huawei.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=DWm3L3c6cg76+gbW15VK0ytaH1+pX6bNJ9lRmLrWawM=; b=hA/Z6OwCjfACk+ msZmfEbFsQYISx/2169RBG7GHasoOEaZQtrjoSFadDfarE8GgNSelYpkShHOooSVBOLXnOrbFBufm V3XzTtihugfEhhRwjn6WrcfD96eFUwqBBV2BND/8FmT+0AqmqnMcUt0X4Dpqu9qoCYSvQroZT8yf3 +tysKYa8LXy9RRMOa08/pkkJZ9MAlmDCX9iTt2THEHRq451Caybfv1xizmZ43kBJtE7jMXTBRaVSO S5FoDmr744o2RxzZSvPRUAXPVTRqpccC1jtSK78yDlK/lT96a3q2NSMTc9iRDHMsNuLaZf8j+H3FE vgJigHJEpXdFsYQQN23g==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iUpG0-0003ul-H6; Wed, 13 Nov 2019 09:48:12 +0000 Received: from szxga06-in.huawei.com ([45.249.212.32] helo=huawei.com) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iUpFu-0003sO-07 for linux-arm-kernel@lists.infradead.org; Wed, 13 Nov 2019 09:48:10 +0000 Received: from DGGEMS402-HUB.china.huawei.com (unknown [172.30.72.58]) by Forcepoint Email with ESMTP id 6CD6BC08E7C566C8E8DB; Wed, 13 Nov 2019 17:47:57 +0800 (CST) Received: from localhost (10.202.226.61) by DGGEMS402-HUB.china.huawei.com (10.3.19.202) with Microsoft SMTP Server id 14.3.439.0; Wed, 13 Nov 2019 17:47:49 +0800 Date: Wed, 13 Nov 2019 09:47:42 +0000 From: Jonathan Cameron To: Dan Williams Subject: Re: [PATCH V5 1/4] ACPI: Support Generic Initiator only domains Message-ID: <20191113094742.00000dc4@huawei.com> In-Reply-To: References: <20191004114330.104746-1-Jonathan.Cameron@huawei.com> <20191004114330.104746-2-Jonathan.Cameron@huawei.com> Organization: Huawei X-Mailer: Claws Mail 3.17.4 (GTK+ 2.24.32; i686-w64-mingw32) MIME-Version: 1.0 X-Originating-IP: [10.202.226.61] X-CFilter-Loop: Reflected X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191113_014809_000687_5BCEA7AD X-CRM114-Status: GOOD ( 19.02 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Linux ACPI , Tao Xu , X86 ML , "Rafael J . Wysocki" , Linux Kernel Mailing List , Linuxarm , Keith Busch , Linux MM , =?ISO-8859-1?Q?J=E9r=F4me?= Glisse , Andrew Morton , Linux ARM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, 12 Nov 2019 09:55:17 -0800 Dan Williams wrote: > [ add Tao Xu ] > > On Fri, Oct 4, 2019 at 4:45 AM Jonathan Cameron > wrote: > > > > Generic Initiators are a new ACPI concept that allows for the > > description of proximity domains that contain a device which > > performs memory access (such as a network card) but neither > > host CPU nor Memory. > > > > This patch has the parsing code and provides the infrastructure > > for an architecture to associate these new domains with their > > nearest memory processing node. > > Thanks for this Jonathan. May I ask how this was tested? Tao has been > working on qemu support for HMAT [1]. I have not checked if it already > supports generic initiator entries, but it would be helpful to include > an example of how the kernel sees these configurations in practice. > > [1]: http://patchwork.ozlabs.org/cover/1096737/ Tested against qemu with SRAT and SLIT table overrides from an initrd to actually create the node and give it distances (those all turn up correctly in the normal places). DSDT override used to move an emulated network card into the GI numa node. That currently requires the PCI patch referred to in the cover letter. On arm64 tested both on qemu and real hardware (overrides on tables even for real hardware as I can't persuade our BIOS team to implement Generic Initiators until an OS is actually using them.) Main real requirement is memory allocations then occur from one of the nodes at the minimal distance when you are do a devm_ allocation from a device assigned. Also need to be able to query the distances to allow load balancing etc. All that works as expected. It only has a fairly tangential connection to HMAT in that HMAT can provide information on GI nodes. Given HMAT code is quite happy with memoryless nodes anyway it should work. QEMU doesn't currently have support to create GI SRAT entries let alone HMAT using them. Whilst I could look at adding such support to QEMU, it's not exactly high priority to emulate something we can test easily by overriding the tables before the kernel reads them. I'll look at how hard it is to build an HMAT tables for my test configs based on the ones I used to test your HMAT patches a while back. Should be easy if tedious. Jonathan _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel