linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: Claudiu Beznea <claudiu.beznea@microchip.com>
Cc: alexandre.belloni@bootlin.com, linux-kernel@vger.kernel.org,
	linux@armlinux.org.uk, ludovic.desroches@microchip.com,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 01/13] ARM: at91: Kconfig: add sam9x60 pll config flag
Date: Wed, 13 Nov 2019 11:09:38 +0100	[thread overview]
Message-ID: <20191113110938.5e7ee5cd@windsurf> (raw)
In-Reply-To: <1573635069-30883-2-git-send-email-claudiu.beznea@microchip.com>

On Wed, 13 Nov 2019 10:50:57 +0200
Claudiu Beznea <claudiu.beznea@microchip.com> wrote:

> Add SAM9X60's pll config flag.
> 
> Signed-off-by: Claudiu Beznea <claudiu.beznea@microchip.com>

You should explain why this flag is needed, because as it is, this flag
is here, then selected in your PATCH 2/13, but not used anywhere.

Could you clarify this ?

Thanks,

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2019-11-13 10:09 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-13  8:50 [PATCH 00/13] add defconfig support for SAM9X60 Claudiu Beznea
2019-11-13  8:50 ` [PATCH 01/13] ARM: at91: Kconfig: add sam9x60 pll config flag Claudiu Beznea
2019-11-13 10:09   ` Thomas Petazzoni [this message]
2019-11-13 10:41     ` Claudiu.Beznea
2019-11-13  8:50 ` [PATCH 02/13] ARM: at91: Kconfig: add config flag for SAM9X60 SoC Claudiu Beznea
2019-11-13  8:50 ` [PATCH 03/13] ARM: at91/defconfig: use savedefconfig Claudiu Beznea
2019-11-13  8:51 ` [PATCH 04/13] ARM: at91/defconfig: add config option for SAM9X60 SoC Claudiu Beznea
2019-11-13  8:51 ` [PATCH 05/13] ARM: at91/defconfig: enable atmel maxtouch Claudiu Beznea
2019-11-13  8:51 ` [PATCH 06/13] ARM: at91/defconfig: enable SAMA5D2's SHDWC Claudiu Beznea
2019-11-13  8:51 ` [PATCH 07/13] ARM: at91/defconfig: enable flexcom Claudiu Beznea
2019-11-13  8:51 ` [PATCH 08/13] ARM: at91/defconfig: enable XDMAC Claudiu Beznea
2019-11-13  8:51 ` [PATCH 09/13] ARM: at91/defconfig: Add I2S Multi-channel driver Claudiu Beznea
2019-11-13  8:51 ` [PATCH 10/13] ARM: at91/defconfig: Add driver for Audio PROTO board Claudiu Beznea
2019-11-13  8:51 ` [PATCH 11/13] ARM: at91/defconfig: enable AT91_SAMA5D2_ADC Claudiu Beznea
2019-11-13  8:51 ` [PATCH 12/13] ARM: at91/defconfig: enable ATMEL_QUADSPI Claudiu Beznea
2019-11-13  8:51 ` [PATCH 13/13] ARM: at91/defconfig: enable CLASSD Claudiu Beznea
2019-11-13 11:15 ` [PATCH 00/13] add defconfig support for SAM9X60 Claudiu.Beznea

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191113110938.5e7ee5cd@windsurf \
    --to=thomas.petazzoni@bootlin.com \
    --cc=alexandre.belloni@bootlin.com \
    --cc=claudiu.beznea@microchip.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=ludovic.desroches@microchip.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).