From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D12EBC17447 for ; Wed, 13 Nov 2019 11:45:33 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9390E2245A for ; Wed, 13 Nov 2019 11:45:33 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="XXomnSMW"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=armlinux.org.uk header.i=@armlinux.org.uk header.b="zwqfCn0v" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9390E2245A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=armlinux.org.uk Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=x7lu03qUni/ED9oOD8ezk1mX90d2PuY0mueIBi4tSo8=; b=XXomnSMWjnnDCw LSBGqRb0pfM8yOk5qI+FMwgZ2ysIaRQqQnBZMLz79wxHXtmj5iP5cqE2tQdV3bbLXcgpdyh03K2oC 1fsBlkLL/e/Ol0XeW1i+vuDoNWkLCgmIju2PtQD2O16tzvLTY1Y1WfKKl4cOMbyTemrkWFuhlc6uF jHY4DR1b3fk7dTqcfgsjOnwY8KAosn/1tamp7HKYga+NlVOZ0hnlKrTom/P4aOzSuHFOrNm+udK/7 qDdWnWXolLzLG9VT0fXJrf1H20Rb0RE8x9u/AtebcEjPOzJFnICQOZPeiNx17ef+LVc/7msDmQhyn /sIFD8jx4UlKi7HchnTQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iUr5Y-0004Ps-HG; Wed, 13 Nov 2019 11:45:32 +0000 Received: from pandora.armlinux.org.uk ([2001:4d48:ad52:3201:214:fdff:fe10:1be6]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iUr5V-0004P6-4V for linux-arm-kernel@lists.infradead.org; Wed, 13 Nov 2019 11:45:30 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=MRSKd3LXrq6EXkXxAZKL+S6+5ayk867BwDtWpuS9mz8=; b=zwqfCn0vRZA0CM6CtyrLz/+9V +lWhkic3YRH6CABAvhwerSJ/cOAVIoJTjcRSgMPry6XwiPMJjdyuVBNZs4vm7kXOJRUQM4EQtBrZw Pj/kdLrJgwrzFgKw/KkBeya9XRHim4+a8pnxwJtfFbzuQ+El5/VOhGYLur05jBBgQJ0oLxDhHLgaE 4cnVSithXvAqeuBnqKjk1NHMnknYWe7QBooMn6Pcf4cRwn9ouCwBe3lw7LiQwMThCJL4pWvAzaIEv 693n/MWTjJZ12t5RN7DNaNYM5SkmSdJXS7cJoSln/vCAqNOCRG/xSKU6oa7GdxI9oZxr5RrTYwbJy bEVQ++kHw==; Received: from shell.armlinux.org.uk ([2001:4d48:ad52:3201:5054:ff:fe00:4ec]:55652) by pandora.armlinux.org.uk with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.90_1) (envelope-from ) id 1iUr5L-0003xa-6p; Wed, 13 Nov 2019 11:45:19 +0000 Received: from linux by shell.armlinux.org.uk with local (Exim 4.92) (envelope-from ) id 1iUr5K-0002Qk-0R; Wed, 13 Nov 2019 11:45:18 +0000 Date: Wed, 13 Nov 2019 11:45:17 +0000 From: Russell King - ARM Linux admin To: Masahiro Yamada Subject: Re: [PATCH] ARM: don't export unused return_address() Message-ID: <20191113114517.GO25745@shell.armlinux.org.uk> References: <20190906154706.2449696-1-arnd@arndb.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191113_034529_180161_80E00655 X-CRM114-Status: GOOD ( 19.41 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Arnd Bergmann , Linux Kernel Mailing List , Geert Uytterhoeven , Thomas Gleixner , Enrico Weigelt , Linux ARM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Nov 13, 2019 at 08:40:39PM +0900, Masahiro Yamada wrote: > On Tue, Oct 1, 2019 at 11:31 PM Geert Uytterhoeven wrote: > > > > Hi Arnd, > > > > On Fri, Sep 6, 2019 at 5:47 PM Arnd Bergmann wrote: > > > Without the frame pointer enabled, return_address() is an inline > > > function and does not need to be exported, as shown by this warning: > > > > > > WARNING: "return_address" [vmlinux] is a static EXPORT_SYMBOL_GPL > > > > > > Move the EXPORT_SYMBOL_GPL() into the #ifdef as well. > > > > > > Signed-off-by: Arnd Bergmann > > > > Thanks for your patch! > > > > Tested-by: Geert Uytterhoeven > > > > > --- a/arch/arm/kernel/return_address.c > > > +++ b/arch/arm/kernel/return_address.c > > > @@ -53,6 +53,7 @@ void *return_address(unsigned int level) > > > return NULL; > > > } > > > > > > > Checkpatch doesn't like the empty line above: > > > > WARNING: EXPORT_SYMBOL(foo); should immediately follow its function/variable > > > > > +EXPORT_SYMBOL_GPL(return_address); > > > + > > > #endif /* if defined(CONFIG_FRAME_POINTER) && !defined(CONFIG_ARM_UNWIND) */ > > > > > > -EXPORT_SYMBOL_GPL(return_address); > > > > Gr{oetje,eeting}s, > > > > Geert > > > > -- > > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org > > > > In personal conversations with technical people, I call myself a hacker. But > > when I'm talking to journalists I just say "programmer" or something like that. > > -- Linus Torvalds > > > > What has happened to this patch? > > I still see this warning. Simple - it got merged, it caused build regressions, it got dropped. A new version is pending me doing another round of patch merging. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTC broadband for 0.8mile line in suburbia: sync at 12.1Mbps down 622kbps up According to speedtest.net: 11.9Mbps down 500kbps up _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel