From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 595DEC432C3 for ; Wed, 13 Nov 2019 17:03:36 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2CD0D206D5 for ; Wed, 13 Nov 2019 17:03:35 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="q0HBX9fE"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=armlinux.org.uk header.i=@armlinux.org.uk header.b="dD6+CSQ/" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2CD0D206D5 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=armlinux.org.uk Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=+trKzj31cgcdTZe1+umgtCZdKDic5GLs1dsyYg7Wq/g=; b=q0HBX9fEeZyKs1 J6wYOibO5+P8Xugyd+yKjOI852Cixnob2u7XvumWzVZdqA/WsRkStMYDqIpp4bvcOYuMM5z8iY5fP uicbPhTjI64sA2zQI/mABiA9f5PRSn7YcczF+FievyjCfAnD534CotRdIsrcxLbDln97MiKgkBQJn 235c4Fq+0UYCg/CZkZT7I4X+JoM2mMf+8AhMJhDj2MZgFX1K9xD+4Q5aMd/w9LcFFV0pNCQFUeDK0 FnIePtz8oNpDxSzVHvN3b1k5Sv8H/ii/lTvHuzLMUORQhlFG4aGhwK+zybtg1XlKTkm3356oSVObU 58fz3Z4XO/k9HBcg7INw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iUw3L-0002bE-NQ; Wed, 13 Nov 2019 17:03:35 +0000 Received: from pandora.armlinux.org.uk ([2001:4d48:ad52:3201:214:fdff:fe10:1be6]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iUw3G-0002T2-V5 for linux-arm-kernel@lists.infradead.org; Wed, 13 Nov 2019 17:03:33 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=WQADSNrI4d/HxzMxBtQ+iwGnK4AsKuPRvo12BLZ2hYY=; b=dD6+CSQ/oWdT8C4qLFqsDE0HV dzp2WMa/ykoPKGfI05NSUeIQ+iabkCgAM4fJTJfRioHfdk/Uvp9zA3QUFH/h5g5g9bJxUKbgsV8tb q0yD4DgGXvvwf2hCbQeo0Nq4KkDMbkql0xiyDXMFSZ2QUAmvO7uC/U4+x410VSM3xs++hQ2MKguQV 4k/jdBjPcrynl8RtDX8K8lrB3uDv4LulPiB4KQ4lFYZ2HNkynl1Uga58/xzSD1YRTQyPeX5rcYG98 NfnJv75jyVDK436ZZ5LwLHRMnhsiDuA1Ocv05Xv1gV/4ENT7xE9QkT7OFejCUzWFHfliMLIds8Awo Zv8VRqbYw==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:39168) by pandora.armlinux.org.uk with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.90_1) (envelope-from ) id 1iUw0s-0005cw-MT; Wed, 13 Nov 2019 17:01:02 +0000 Received: from linux by shell.armlinux.org.uk with local (Exim 4.92) (envelope-from ) id 1iUw0o-0002bS-Np; Wed, 13 Nov 2019 17:00:58 +0000 Date: Wed, 13 Nov 2019 17:00:58 +0000 From: Russell King - ARM Linux admin To: Geert Uytterhoeven Subject: Re: [PATCH] ARM: don't export unused return_address() Message-ID: <20191113170058.GP25745@shell.armlinux.org.uk> References: <20190906154706.2449696-1-arnd@arndb.de> <20191113114517.GO25745@shell.armlinux.org.uk> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191113_090331_001357_4ED95C58 X-CRM114-Status: GOOD ( 20.11 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Arnd Bergmann , Linux Kernel Mailing List , Masahiro Yamada , Thomas Gleixner , Enrico Weigelt , Linux ARM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Nov 13, 2019 at 02:15:00PM +0100, Geert Uytterhoeven wrote: > Hi Russell, > > On Wed, Nov 13, 2019 at 12:45 PM Russell King - ARM Linux admin > wrote: > > On Wed, Nov 13, 2019 at 08:40:39PM +0900, Masahiro Yamada wrote: > > > On Tue, Oct 1, 2019 at 11:31 PM Geert Uytterhoeven wrote: > > > > On Fri, Sep 6, 2019 at 5:47 PM Arnd Bergmann wrote: > > > > > Without the frame pointer enabled, return_address() is an inline > > > > > function and does not need to be exported, as shown by this warning: > > > > > > > > > > WARNING: "return_address" [vmlinux] is a static EXPORT_SYMBOL_GPL > > > > > > > > > > Move the EXPORT_SYMBOL_GPL() into the #ifdef as well. > > > > > > > > > > Signed-off-by: Arnd Bergmann > > > > > > > > Thanks for your patch! > > > > > > > > Tested-by: Geert Uytterhoeven > > > > > > > > > --- a/arch/arm/kernel/return_address.c > > > > > +++ b/arch/arm/kernel/return_address.c > > > > > @@ -53,6 +53,7 @@ void *return_address(unsigned int level) > > > > > return NULL; > > > > > } > > > > > > > > > > > > > Checkpatch doesn't like the empty line above: > > > > > > > > WARNING: EXPORT_SYMBOL(foo); should immediately follow its function/variable > > > > > > > > > +EXPORT_SYMBOL_GPL(return_address); > > > > > + > > > > > #endif /* if defined(CONFIG_FRAME_POINTER) && !defined(CONFIG_ARM_UNWIND) */ > > > > > > > > > > -EXPORT_SYMBOL_GPL(return_address); > > > > What has happened to this patch? > > > > > > I still see this warning. > > > > Simple - it got merged, it caused build regressions, it got dropped. > > A new version is pending me doing another round of patch merging. > > I believe that was not Arnd's patch, but Ben Dooks' alternative solution[*]? I don't keep track of who did what, sorry. > > [*] Commit 0b0617e5a610fe12 ("ARM: 8918/1: only build return_address() if > needed"), which I discovered in next-20191031 when checking if Arnd's > patch was applied.... -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTC broadband for 0.8mile line in suburbia: sync at 12.1Mbps down 622kbps up According to speedtest.net: 11.9Mbps down 500kbps up _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel