From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C30D9C432C3 for ; Wed, 13 Nov 2019 23:41:36 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1B52C2068D for ; Wed, 13 Nov 2019 23:41:37 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="QYJwD2TN" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1B52C2068D Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=etezian.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=WwklKh1riYx47el+NXn9jBk72w2RXIo9yYYU9ARN6/w=; b=QYJwD2TNYxGUY0 5nH91dwW5/ptsrGspCtnNhrm+SUC2UdvY7H1k1306kJkhGmTrSLqELr/o4hnAZOpfYLP6DbHFhvQJ Ritgjrag4JGF5xbvp4A/amBs35jqIaBjvPv5qslQA8sdPj+h3XQGt6bmhDAGp+E0GmLQR747oojUW SdOkDBUwYg2bZUtFIc0TXoqwhCuMbhAFXli2FrPZDZ5c7sfSpMKD57Q+kad0ePYUR5RY/gzTk+3BJ vqz3xfVVy9ICyM+gbcBijh3vMwIFeSuk/DWXe5rbSiV01JK6rEQIohJdNwYOChwbsf7ErSiS1Uaom +xJS3VJf74LLHVcl5aIw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iV2GQ-0007Sq-Id; Wed, 13 Nov 2019 23:41:30 +0000 Received: from 10.mo173.mail-out.ovh.net ([46.105.74.148]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iV2GM-0007RV-Ol for linux-arm-kernel@lists.infradead.org; Wed, 13 Nov 2019 23:41:28 +0000 Received: from player758.ha.ovh.net (unknown [10.108.54.217]) by mo173.mail-out.ovh.net (Postfix) with ESMTP id A9DCB11D6C6 for ; Thu, 14 Nov 2019 00:41:14 +0100 (CET) Received: from etezian.org (81-175-223-118.bb.dnainternet.fi [81.175.223.118]) (Authenticated sender: andi@etezian.org) by player758.ha.ovh.net (Postfix) with ESMTPSA id 17468C1C43CF; Wed, 13 Nov 2019 23:40:50 +0000 (UTC) Date: Thu, 14 Nov 2019 01:40:49 +0200 From: Andi Shyti To: Peter Ujfalusi Subject: Re: [PATCH 7/9] spi: s3c64xx: Use dma_request_chan() directly for channel request Message-ID: <20191113234049.GA1249@jack.zhora.eu> References: <20191113094256.1108-1-peter.ujfalusi@ti.com> <20191113094256.1108-8-peter.ujfalusi@ti.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20191113094256.1108-8-peter.ujfalusi@ti.com> User-Agent: Mutt/1.12.2 (2019-09-21) X-Ovh-Tracer-Id: 10707589591967711931 X-VR-SPAMSTATE: OK X-VR-SPAMSCORE: -100 X-VR-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgedufedrudefvddgudefucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuqfggjfdqfffguegfifdpvefjgfevmfevgfenuceurghilhhouhhtmecuhedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujfgurhepfffhvffukfhfgggtuggjfgesthdtredttdervdenucfhrhhomheptehnughiucfuhhihthhiuceorghnughisegvthgviihirghnrdhorhhgqeenucfkpheptddrtddrtddrtddpkedurddujeehrddvvdefrdduudeknecurfgrrhgrmhepmhhouggvpehsmhhtphdqohhuthdphhgvlhhopehplhgrhigvrhejheekrdhhrgdrohhvhhdrnhgvthdpihhnvghtpedtrddtrddtrddtpdhmrghilhhfrhhomheprghnughisegvthgviihirghnrdhorhhgpdhrtghpthhtoheplhhinhhugidqrghrmhdqkhgvrhhnvghlsehlihhsthhsrdhinhhfrhgruggvrggurdhorhhgnecuvehluhhsthgvrhfuihiivgeptd X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191113_154126_950549_AC09A574 X-CRM114-Status: UNSURE ( 6.69 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linus.walleij@linaro.org, kgene@kernel.org, alexandre.belloni@bootlin.com, linux-arm-msm@vger.kernel.org, radu_nicolae.pirea@upb.ro, linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org, krzk@kernel.org, bjorn.andersson@linaro.org, vkoul@kernel.org, agross@kernel.org, ldewangan@nvidia.com, broonie@kernel.org, andi@etezian.org, linux-tegra@vger.kernel.org, thierry.reding@gmail.com, jonathanh@nvidia.com, shawnguo@kernel.org, s.hauer@pengutronix.de, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Peter, > if (!is_polling(sdd)) { > /* Acquire DMA channels */ > - sdd->rx_dma.ch = dma_request_slave_channel_reason(&pdev->dev, > - "rx"); > + sdd->rx_dma.ch = dma_request_chan(&pdev->dev, "rx"); I have a little concern here. We have two funcions 'dma_request_chan' and 'dma_request_channel' don't we end up making some confusion here? Wouldn't it make more sense renaming 'dma_request_chan' to 'dma_request_slave_channel_reason'? Thanks, Andi _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel