From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7C996C432C3 for ; Thu, 14 Nov 2019 05:51:00 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6A038206DA for ; Thu, 14 Nov 2019 05:51:00 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="knNHquE/"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="1n08guEV" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6A038206DA Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Message-Id:Date:Subject:From:To: References:In-Reply-To:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=PAJEAooaUpMNNq44bsRtFwcJTDteBjpcSCisAhpiMNQ=; b=knNHquE/gYMFI5 PieHk7gyLt6Kvrn1v8+SzZ6wz6JQyKSYYNvHdNZq8aNpsqzNJKCx56eYP8JaMwpsp3J5d9v8VpRHF wQzve6RO969atftRYZUJFplB8MPF/K5gZzMRgAf39OonLus4APVOSLAizHcngJNquXJCQHrOlps5I ctuT2txAN6OPRCkRlRVGCSu7+wJ8WYK5uOxJScKTaOgH4waeNBfQ1pVQsSQ+azcueQQjwUIROabAa 0jEhUqpAfFZ1K0G61meo16GaQfrBTUbcSkND1bzX3M/VRtnARIv6AI7o1HoxY0zsA2Azi5o+JFzSj gaKnKiZ5QgAZfAj/x1gw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iV81z-0008IU-Ea; Thu, 14 Nov 2019 05:50:59 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iV81w-0008Hz-6t for linux-arm-kernel@lists.infradead.org; Thu, 14 Nov 2019 05:50:57 +0000 Received: from kernel.org (unknown [104.132.0.74]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id C280F206DA; Thu, 14 Nov 2019 05:50:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1573710654; bh=4A75EbHYfhyoJ0lhDbgLRn70lmtQcL0MNpem0+VHKtk=; h=In-Reply-To:References:Cc:To:From:Subject:Date:From; b=1n08guEVhPb8UK6CAVnBSbKcdr1bhzFAIYzVKmdZyTwg3cLFLt/y/po33Fzs3Z23j yU5A9GSYX5vYnxlWu6QZ9iRnSMh+HDgucz/akSpMXc4HslM/XwnjgTN5+GeY37Hl5d db1fLr78Pu6s7rG92jverAQAFSl9D1Y5Dz/cIgDU= MIME-Version: 1.0 In-Reply-To: <20191114053404.GA8459@mani> References: <20191026110253.18426-1-manivannan.sadhasivam@linaro.org> <20191113222116.E5E9B206E3@mail.kernel.org> <20191114053404.GA8459@mani> To: Manivannan Sadhasivam From: Stephen Boyd Subject: Re: [PATCH v6 0/7] Add Bitmain BM1880 clock driver User-Agent: alot/0.8.1 Date: Wed, 13 Nov 2019 21:50:53 -0800 Message-Id: <20191114055054.C280F206DA@mail.kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191113_215056_275410_92304FFC X-CRM114-Status: GOOD ( 12.05 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, mturquette@baylibre.com, linux-kernel@vger.kernel.org, darren.tsao@bitmain.com, robh+dt@kernel.org, haitao.suo@bitmain.com, fisher.cheng@bitmain.com, alec.lin@bitmain.com, linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Quoting Manivannan Sadhasivam (2019-11-13 21:34:04) > On Wed, Nov 13, 2019 at 02:21:15PM -0800, Stephen Boyd wrote: > > Quoting Manivannan Sadhasivam (2019-10-26 04:02:46) > > > Hello, > > > > > > This patchset adds common clock driver for Bitmain BM1880 SoC clock > > > controller. The clock controller consists of gate, divider, mux > > > and pll clocks with different compositions. Hence, the driver uses > > > composite clock structure in place where multiple clocking units are > > > combined together. > > > > > > This patchset also removes UART fixed clock and sources clocks from clock > > > controller for Sophon Edge board where the driver has been validated. > > > > > > > Are you waiting for review here? I see some kbuild reports so I assumed > > you would fix and resend. > > I'll fix it but I was expecting some review from you so that I can send the > next revision incorporating all comments. > Ok. I'm glad I broke the silence then. Can you please resend without any dts changes? Those don't go through clk tree. I think otherwise the patches look OK, although I was hoping you could register clks by using the new way of specifying parents. Is that possible? _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel