From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4EDD1C432C3 for ; Thu, 14 Nov 2019 14:01:06 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1FBF9206F4 for ; Thu, 14 Nov 2019 14:01:06 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="NzkaWQ4S"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=ti.com header.i=@ti.com header.b="Mpbs4fWC" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1FBF9206F4 Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=ti.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=RydPlrG79ShHIsnYYekucoYs4PytVuRYwqaF/v1wsEE=; b=NzkaWQ4StjBzGE A2xWlg8cmAgQXOzVAkpIXYM0AZxesrK1x/02wtunNk17cef1q6lK8uk3td6lpsQ4cn37BFAK/Hm0N gxXcNLWnTPo1KoDPsRpPMOLgdKHL+l6nkLLwZjhcNHLwwadiAftF3jITQeM/b5ctY3MVr/UJkHOce n+p5TyKR744lX/NQDkoAgdFsSAYocbQLwC8gXHDAF7hqTbaw0Lcrqm5tuOToPh2q6xRzpDCEipzjd LX5PcWo6Jy2hCp55yl6HebDwHYioUjMNTZIFOe7CP+HkZAN+eEYyNpRu6cHf0FiW25fSXB2UzKgC/ tX/JZ3v7CXpHTa9FpqBQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iVFgA-00088j-U0; Thu, 14 Nov 2019 14:00:59 +0000 Received: from lelv0142.ext.ti.com ([198.47.23.249]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iVFfy-0007yL-TP; Thu, 14 Nov 2019 14:00:48 +0000 Received: from fllv0035.itg.ti.com ([10.64.41.0]) by lelv0142.ext.ti.com (8.15.2/8.15.2) with ESMTP id xAEE0HuM113268; Thu, 14 Nov 2019 08:00:17 -0600 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1573740017; bh=mg4UFFS2ESh3A7IuctheIaBbXKxvehMGp07JMFKAlm0=; h=Date:From:To:CC:Subject:References:In-Reply-To; b=Mpbs4fWCHa2MujEWCR63FGFbtu7sEjAJx80a0Ie3U5gJrSh3wfAFT6V6CCCnse642 ys+4ZwuS5AssKdj7NNk9DtoG1yhneDQGeDKK+yPRdcYOzOzy/47gmxnvex8/A/JEEJ O7RgDe6d2D6COjEaDcBw8754s23pS/NkxNYRndBA= Received: from DLEE102.ent.ti.com (dlee102.ent.ti.com [157.170.170.32]) by fllv0035.itg.ti.com (8.15.2/8.15.2) with ESMTP id xAEE0H5B116509; Thu, 14 Nov 2019 08:00:17 -0600 Received: from DLEE107.ent.ti.com (157.170.170.37) by DLEE102.ent.ti.com (157.170.170.32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1847.3; Thu, 14 Nov 2019 08:00:17 -0600 Received: from fllv0039.itg.ti.com (10.64.41.19) by DLEE107.ent.ti.com (157.170.170.37) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1847.3 via Frontend Transport; Thu, 14 Nov 2019 08:00:17 -0600 Received: from localhost (ileax41-snat.itg.ti.com [10.172.224.153]) by fllv0039.itg.ti.com (8.15.2/8.15.2) with ESMTP id xAEE0HRI130585; Thu, 14 Nov 2019 08:00:17 -0600 Date: Thu, 14 Nov 2019 08:02:34 -0600 From: Bin Liu To: Greg Kroah-Hartman Subject: Re: [PATCH v2 05/13] usb: musb: create debugfs directory under usb root Message-ID: <20191114140234.GB5853@uda0271908> Mail-Followup-To: Bin Liu , Greg Kroah-Hartman , Chunfeng Yun , Felipe Balbi , Laurent Pinchart , Mauro Carvalho Chehab , Peter Chen , Minas Harutyunyan , Cristian Birsan , Nicolas Ferre , Alexandre Belloni , Ludovic Desroches , Kevin Cernekee , Florian Fainelli , bcm-kernel-feedback-list@broadcom.com, Daniel Mack , Haojian Zhuang , Robert Jarzmik , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Matthias Brugger , Stephen Boyd , Yoshihiro Shimoda , Colin Ian King , Biju Das , Fabrizio Castro , "Gustavo A. R. Silva" , Yangtao Li , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org References: <1573541519-28488-1-git-send-email-chunfeng.yun@mediatek.com> <1573541519-28488-5-git-send-email-chunfeng.yun@mediatek.com> <20191112152857.GA5853@uda0271908> <20191114032018.GA122287@kroah.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20191114032018.GA122287@kroah.com> User-Agent: Mutt/1.9.4 (2018-02-28) X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191114_060047_061730_B65CF226 X-CRM114-Status: GOOD ( 17.17 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Chen , Alexandre Belloni , "Gustavo A. R. Silva" , Yangtao Li , linux-kernel@vger.kernel.org, Minas Harutyunyan , Laurent Pinchart , Fabio Estevam , Florian Fainelli , Robert Jarzmik , Kevin Cernekee , Ludovic Desroches , bcm-kernel-feedback-list@broadcom.com, NXP Linux Team , Chunfeng Yun , Cristian Birsan , linux-media@vger.kernel.org, Fabrizio Castro , Sascha Hauer , Haojian Zhuang , Stephen Boyd , linux-mediatek@lists.infradead.org, Matthias Brugger , Mauro Carvalho Chehab , linux-arm-kernel@lists.infradead.org, Biju Das , Felipe Balbi , Yoshihiro Shimoda , linux-usb@vger.kernel.org, Pengutronix Kernel Team , Colin Ian King , Shawn Guo , Daniel Mack Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Nov 14, 2019 at 11:20:18AM +0800, Greg Kroah-Hartman wrote: > On Tue, Nov 12, 2019 at 09:28:57AM -0600, Bin Liu wrote: > > Hi, > > > > On Tue, Nov 12, 2019 at 02:51:51PM +0800, Chunfeng Yun wrote: > > > Now the USB gadget subsystem can use the USB debugfs root directory, > > > so move musb's directory from the root of the debugfs filesystem into > > > the root of usb > > > > My opinion is this move is unnecessary. I breaks existing debug tools or > > documentation which is already published on Internet. > > Having a "root" directory for a single random driver seems like you are > making your driver a "very important" thing in the overall scheme of the > kernel, right? What's wrong with using the usb subdirectory like all Agree, it wasn't the right thing to do at the first place. But now changing it adds support burden, because people very often refer to the old information on the internet which no longer matches to the new location. Basically, it is a cost of ABI change. > other USB drivers use (after this patch series is merged)? That feels > like a much more "sane" way to handle the wide-open debugfs namespace. Though I commented on this musb patch, my opinion is for this whole series, either drop the whole series or apply the whole series. > Yes, there are no rules when it comes to debugfs file names and > locations, but let's try to be sane please. Fine with me. I can still support questions such as "can't open /sys/kernel/debug/musb-hdrc.0/testmode: No such file or directory". -Bin. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel