From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B91CCC43215 for ; Thu, 14 Nov 2019 16:08:24 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8ED532071F for ; Thu, 14 Nov 2019 16:08:24 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="pXvYPgTT"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ooW5Ua4E" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8ED532071F Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=roeck-us.net Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=b+l9PJw9P3yjsVGXh+fVVD3OEmsTjIQN0P14KgK19hQ=; b=pXvYPgTTf6NH2F x4Wk8KqkyLUELMRL+xkIuVk+TqWIFOllXrILwntUC92Aq8wJVbky1b57fjZ2eOwMbfFIKdfpqssWN dq8P+JVOsObT6oAJgMbaQyybGGZR1PiGM+LkX+CrkAhjlK4YJy7tcN3m6qNj2uGVqtDN0n6Dz+UTs WP7Bp5XIvQyO/aub6/YfMoTiQ1ZrkF/GwB+xCGkt1STGiYl5DtShPC4F+LkWQMpIiEoqA6ZoiZq6O Movd1tB/1WT/xK0liOzcLcX+81SgLjkUFcDTMd24BCj3lxU9OqX3Ba0gsbW1itCH1nES43f9H+/QW K07d6bxax/ybS8JcKKoQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iVHfT-0000L7-SL; Thu, 14 Nov 2019 16:08:23 +0000 Received: from mail-pf1-x442.google.com ([2607:f8b0:4864:20::442]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iVHfQ-0000Kc-SW for linux-arm-kernel@lists.infradead.org; Thu, 14 Nov 2019 16:08:22 +0000 Received: by mail-pf1-x442.google.com with SMTP id c13so4545568pfp.5 for ; Thu, 14 Nov 2019 08:08:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=ayAVj6XklJJBJPKHbdoumjHnfHk65xz206ddr7YvVB0=; b=ooW5Ua4E4EOqBaLeWVLobQoOF6HaU61zJ2P4lJPsXX735kybv1kRnmqogrM2jVOw2i C1sg3K0QAMdnkowcVTNVO+LpoRz4pOFXkoxgSYF0N6jLHQLUJI+zp6hUFurlQKcGj+gv lZekcsWWMHmcw3qoZ767UtSXJigukhyENaOIVszLHWP9R1ef0zPTdu+DazLnijRbhYTC m4zeYIGISgrq+i3Z34IKCIRdb8ChjpPb/vM+68cSF2kvzJw+p7DXbxltbWE88JfcydQQ TQ3+0S6ovbe8BE/3Slky0QEfgAUOuPczS4BQT342YJvB6Yp9i64rNTnK5BHwfLB1zjb2 Og+Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition :content-transfer-encoding:in-reply-to:user-agent; bh=ayAVj6XklJJBJPKHbdoumjHnfHk65xz206ddr7YvVB0=; b=EP48fF7FgeOFmNVLNPLja3h7DP1Dq/nYU5KCO5016yB7E19vbYAB1DIoAfzLHNOQAk wmLmlQo8GczDFgZi1wDPJHh1A6xNt70LYuQRWDVBhtjrYnu+gHYkvku+J6rRnDmoPpFq MXpiMe2oNwMeck/cmMDJOBmcIcckvSW8+TS6pjWQOlfGJX2r2qXZy0sQU7eVl6Q0G7+r q28orvXHirFVagK19GxCA318bUqVf/aOYWR6BIPWU+7o25A2FhFzRrH33S/RO/Jr4OaC OhZxfvd7Nfh5KNihzBHLPEsVVsEagudLzl1oyatz7m3uhggMAl6iEQsSvvmJR3se3wCH Ukpg== X-Gm-Message-State: APjAAAXP3xqEAOIaOxFciCMvdp9Wr2DP9peulpu/xFhAsCQP6xn50DxQ D7EAqce/e9l/WMOzzLH37OU= X-Google-Smtp-Source: APXvYqyCmyzBlJHqpHHUz/lJupT5sWCvCMDatQwNrXhNrIxK/LqC8IZj9I4WdrOqcffBRVooMYtCbQ== X-Received: by 2002:a62:2ccf:: with SMTP id s198mr1915441pfs.42.1573747699509; Thu, 14 Nov 2019 08:08:19 -0800 (PST) Received: from localhost ([2600:1700:e321:62f0:329c:23ff:fee3:9d7c]) by smtp.gmail.com with ESMTPSA id q1sm5889789pgr.92.2019.11.14.08.08.17 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 14 Nov 2019 08:08:18 -0800 (PST) Date: Thu, 14 Nov 2019 08:08:16 -0800 From: Guenter Roeck To: Eugen.Hristev@microchip.com Subject: Re: [PATCH v3 1/3] watchdog: sama5d4_wdt: cleanup the bit definitions Message-ID: <20191114160816.GA25430@roeck-us.net> References: <1573474383-21915-1-git-send-email-eugen.hristev@microchip.com> <70ba833e-2acc-7b5a-ca29-1ae9476eb0f5@microchip.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <70ba833e-2acc-7b5a-ca29-1ae9476eb0f5@microchip.com> User-Agent: Mutt/1.9.4 (2018-02-28) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191114_080820_947223_E9EB55ED X-CRM114-Status: GOOD ( 15.49 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, alexandre.belloni@bootlin.com, linux-watchdog@vger.kernel.org, linux-kernel@vger.kernel.org, robh+dt@kernel.org, wim@linux-watchdog.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Nov 14, 2019 at 11:34:31AM +0000, Eugen.Hristev@microchip.com wrote: > = > = > On 12.11.2019 15:47, Guenter Roeck wrote: > = > > = > > On 11/11/19 4:13 AM, Eugen.Hristev@microchip.com wrote: > >> From: Eugen Hristev > >> > >> Cleanup the macro definitions to use BIT and align with two spaces. > >> > >> Signed-off-by: Eugen Hristev > >> --- > >> Changes in v3: > >> - new patch as requested from review on ML > >> > >> =A0 drivers/watchdog/at91sam9_wdt.h | 30 +++++++++++++++--------------- > >> =A0 1 file changed, 15 insertions(+), 15 deletions(-) > >> > >> diff --git a/drivers/watchdog/at91sam9_wdt.h = > >> b/drivers/watchdog/at91sam9_wdt.h > >> index 390941c..2ca5fc5 100644 > >> --- a/drivers/watchdog/at91sam9_wdt.h > >> +++ b/drivers/watchdog/at91sam9_wdt.h > >> @@ -14,23 +14,23 @@ > >> =A0 #define AT91_WDT_H > >> =A0 #define AT91_WDT_CR=A0=A0=A0=A0=A0=A0=A0 0x00=A0=A0=A0=A0=A0=A0=A0= =A0=A0=A0=A0 /* Watchdog Control = > >> Register */ > >> -#define=A0=A0=A0=A0=A0=A0=A0 AT91_WDT_WDRSTT=A0=A0=A0=A0=A0=A0=A0 (1= =A0=A0=A0 << 0)=A0=A0=A0=A0=A0=A0=A0 /* Restart */ > >> -#define=A0=A0=A0=A0=A0=A0=A0 AT91_WDT_KEY=A0=A0=A0=A0=A0=A0=A0 (0xa5 = << 24)=A0=A0=A0=A0=A0=A0=A0 /* KEY = > >> Password */ > >> +#define=A0 AT91_WDT_WDRSTT=A0=A0=A0 BIT(0)=A0=A0=A0=A0=A0=A0=A0=A0=A0= =A0=A0 /* Restart */ > > = > > Using BIT() requires including linux/bits.h. > = > = > Hi Guenter, > = > The C files include/will include the bits.h as the drivers use this = > definition header, or, you have something else in mind ? > = You are supposed to include the file where it is used. If the C file uses it again, it will need to include it again. Guenter > Thanks, > Eugen > = > > = > >> +#define=A0 AT91_WDT_KEY=A0=A0=A0=A0=A0=A0=A0 (0xa5 << 24)=A0=A0=A0=A0= =A0=A0=A0 /* KEY Password */ > >> =A0 #define AT91_WDT_MR=A0=A0=A0=A0=A0=A0=A0 0x04=A0=A0=A0=A0=A0=A0=A0= =A0=A0=A0=A0 /* Watchdog Mode Register */ > >> -#define=A0=A0=A0=A0=A0=A0=A0 AT91_WDT_WDV=A0=A0=A0=A0=A0=A0=A0 (0xfff= << 0)=A0=A0=A0=A0=A0=A0=A0 /* Counter = > >> Value */ > >> -#define=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0 AT91_WDT_SET_WDV(x)=A0=A0=A0= ((x) & AT91_WDT_WDV) > >> -#define=A0=A0=A0=A0=A0=A0=A0 AT91_WDT_WDFIEN=A0=A0=A0=A0=A0=A0=A0 (1= =A0=A0=A0=A0 << 12)=A0=A0=A0=A0=A0=A0=A0 /* Fault = > >> Interrupt Enable */ > >> -#define=A0=A0=A0=A0=A0=A0=A0 AT91_WDT_WDRSTEN=A0=A0=A0 (1=A0=A0=A0=A0= << 13)=A0=A0=A0=A0=A0=A0=A0 /* Reset = > >> Processor */ > >> -#define=A0=A0=A0=A0=A0=A0=A0 AT91_WDT_WDRPROC=A0=A0=A0 (1=A0=A0=A0=A0= << 14)=A0=A0=A0=A0=A0=A0=A0 /* Timer = > >> Restart */ > >> -#define=A0=A0=A0=A0=A0=A0=A0 AT91_WDT_WDDIS=A0=A0=A0=A0=A0=A0=A0 (1= =A0=A0=A0=A0 << 15)=A0=A0=A0=A0=A0=A0=A0 /* Watchdog = > >> Disable */ > >> -#define=A0=A0=A0=A0=A0=A0=A0 AT91_WDT_WDD=A0=A0=A0=A0=A0=A0=A0 (0xfff= << 16)=A0=A0=A0=A0=A0=A0=A0 /* Delta = > >> Value */ > >> -#define=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0 AT91_WDT_SET_WDD(x)=A0=A0=A0= (((x) << 16) & AT91_WDT_WDD) > >> -#define=A0=A0=A0=A0=A0=A0=A0 AT91_WDT_WDDBGHLT=A0=A0=A0 (1=A0=A0=A0= =A0 << 28)=A0=A0=A0=A0=A0=A0=A0 /* Debug = > >> Halt */ > >> -#define=A0=A0=A0=A0=A0=A0=A0 AT91_WDT_WDIDLEHLT=A0=A0=A0 (1=A0=A0=A0= =A0 << 29)=A0=A0=A0=A0=A0=A0=A0 /* Idle = > >> Halt */ > >> +#define=A0 AT91_WDT_WDV=A0=A0=A0=A0=A0=A0=A0 (0xfff << 0)=A0=A0=A0=A0= =A0=A0=A0 /* Counter Value */ > >> +#define=A0 AT91_WDT_SET_WDV(x)=A0=A0=A0 ((x) & AT91_WDT_WDV) > >> +#define=A0 AT91_WDT_WDFIEN=A0=A0=A0 BIT(12)=A0=A0=A0=A0=A0=A0=A0 /* F= ault Interrupt Enable */ > >> +#define=A0 AT91_WDT_WDRSTEN=A0=A0=A0 BIT(13)=A0=A0=A0=A0=A0=A0=A0 /* = Reset Processor */ > >> +#define=A0 AT91_WDT_WDRPROC=A0=A0=A0 BIT(14)=A0=A0=A0=A0=A0=A0=A0 /* = Timer Restart */ > >> +#define=A0 AT91_WDT_WDDIS=A0=A0=A0=A0=A0=A0=A0 BIT(15)=A0=A0=A0=A0=A0= =A0=A0 /* Watchdog Disable */ > >> +#define=A0 AT91_WDT_WDD=A0=A0=A0=A0=A0=A0=A0 (0xfff << 16)=A0=A0=A0= =A0=A0=A0=A0 /* Delta Value */ > >> +#define=A0 AT91_WDT_SET_WDD(x)=A0=A0=A0 (((x) << 16) & AT91_WDT_WDD) > >> +#define=A0 AT91_WDT_WDDBGHLT=A0=A0=A0 BIT(28)=A0=A0=A0=A0=A0=A0=A0 /*= Debug Halt */ > >> +#define=A0 AT91_WDT_WDIDLEHLT=A0=A0=A0 BIT(29)=A0=A0=A0=A0=A0=A0=A0 /= * Idle Halt */ > >> -#define AT91_WDT_SR=A0=A0=A0=A0=A0=A0=A0 0x08=A0=A0=A0=A0=A0=A0=A0=A0= =A0=A0=A0 /* Watchdog Status = > >> Register */ > >> -#define=A0=A0=A0=A0=A0=A0=A0 AT91_WDT_WDUNF=A0=A0=A0=A0=A0=A0=A0 (1 <= < 0)=A0=A0=A0=A0=A0=A0=A0 /* Watchdog = > >> Underflow */ > >> -#define=A0=A0=A0=A0=A0=A0=A0 AT91_WDT_WDERR=A0=A0=A0=A0=A0=A0=A0 (1 <= < 1)=A0=A0=A0=A0=A0=A0=A0 /* Watchdog = > >> Error */ > >> +#define AT91_WDT_SR=A0=A0=A0=A0=A0=A0=A0 0x08=A0=A0=A0=A0=A0=A0=A0 /*= Watchdog Status Register */ > >> +#define=A0 AT91_WDT_WDUNF=A0=A0=A0=A0=A0=A0=A0 BIT(0)=A0=A0=A0=A0=A0= =A0=A0 /* Watchdog Underflow */ > >> +#define=A0 AT91_WDT_WDERR=A0=A0=A0=A0=A0=A0=A0 BIT(1)=A0=A0=A0=A0=A0= =A0=A0 /* Watchdog Error */ > >> =A0 #endif > >> > > = _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel