Re: [PATCH 7/9] spi: s3c64xx: Use dma_request_chan() directly for channel request

Andi Shyti
2019-11-13T23:41:36Z

Hi Peter,

> if (!is_polling(sdd)) {
> /* Acquire DMA channels */
> - sdd->rx_dma.ch = dma_request_slave_channel_reason(&pdev->dev,
> - "rx");
> + sdd->rx_dma.ch = dma_request_chan(&pdev->dev, "rx");

I have a little concern here. We have two funcions
'dma_request_chan' and 'dma_request_channel' don't we end up
making some confusion here?

Wouldn't it make more sense renaming 'dma_request_chan' to
'dma_request_slave_channel_reason'?

Thanks,
Andi