From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EE1D3C43141 for ; Fri, 15 Nov 2019 13:43:47 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C319920715 for ; Fri, 15 Nov 2019 13:43:47 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="S97bxHhH"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=ti.com header.i=@ti.com header.b="fXpOKUav" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C319920715 Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=ti.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=5B/eIwBuBuhQUXPl8Kb9ggR3gnV8HjQ0kKvx2Tf4ZZc=; b=S97bxHhH0GovqR QC55OgBeZZulK6Rc9zjXVx+LLnccHJcTI3pj0FYsdGE6zFXpbZqyaoxKbONYOgvzPz0mPQe0yUP1S PxKVRiEL0ZBlDfZm0tbtBm6W7nzMg53psyHlxZIEahU2eLON2iLJknEvdSiDU6eXrW3c6kYbn4k// VX1CQaj2a2dHaH3OP3P1XDjvlir+jc01J7zTDXCVGMEw2db9q/RhnlQACqqZ3L03XN1MWjT8mWagS zS+baY9C3w8otGVPfJ+8fUEcgBHADrHBmYXQgp9LSWJYXVvob1L2zIdTvKmRfLX5ludBKzDb10q4M rjRi/19I180OYatihNmw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iVbt5-0000o1-G0; Fri, 15 Nov 2019 13:43:47 +0000 Received: from fllv0015.ext.ti.com ([198.47.19.141]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iVbt1-0000mm-Mu; Fri, 15 Nov 2019 13:43:45 +0000 Received: from lelv0266.itg.ti.com ([10.180.67.225]) by fllv0015.ext.ti.com (8.15.2/8.15.2) with ESMTP id xAFDhENw021665; Fri, 15 Nov 2019 07:43:14 -0600 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1573825394; bh=0GMF8waTlZ/mMmEu9OdTiNMpJgRZ1U+24RV0VdCAq3s=; h=Date:From:To:CC:Subject:References:In-Reply-To; b=fXpOKUavZPJUxNL9lEFn7zZNVLFYuhGojcJgORZ0h/BB4qyRFo6mrlCOsH4ERQeHs h9leKq2A0Fj6bzJ4IDPmzVMYiipwgHWHf4mYsJ2/6ss1dHgt4T7A8cxc/hktAUYZHd PabnC59jQNgb5DLLinNwWV5dTN5f0x+2iBMNsWMU= Received: from DFLE104.ent.ti.com (dfle104.ent.ti.com [10.64.6.25]) by lelv0266.itg.ti.com (8.15.2/8.15.2) with ESMTPS id xAFDhELd079797 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Fri, 15 Nov 2019 07:43:14 -0600 Received: from DFLE114.ent.ti.com (10.64.6.35) by DFLE104.ent.ti.com (10.64.6.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1847.3; Fri, 15 Nov 2019 07:43:14 -0600 Received: from lelv0326.itg.ti.com (10.180.67.84) by DFLE114.ent.ti.com (10.64.6.35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1847.3 via Frontend Transport; Fri, 15 Nov 2019 07:43:14 -0600 Received: from localhost (ileax41-snat.itg.ti.com [10.172.224.153]) by lelv0326.itg.ti.com (8.15.2/8.15.2) with ESMTP id xAFDhEow098885; Fri, 15 Nov 2019 07:43:14 -0600 Date: Fri, 15 Nov 2019 07:45:30 -0600 From: Bin Liu To: Greg Kroah-Hartman Subject: Re: [PATCH v2 05/13] usb: musb: create debugfs directory under usb root Message-ID: <20191115134530.GB12511@uda0271908> Mail-Followup-To: Bin Liu , Greg Kroah-Hartman , Chunfeng Yun , Felipe Balbi , Laurent Pinchart , Mauro Carvalho Chehab , Peter Chen , Minas Harutyunyan , Cristian Birsan , Nicolas Ferre , Alexandre Belloni , Ludovic Desroches , Kevin Cernekee , Florian Fainelli , bcm-kernel-feedback-list@broadcom.com, Daniel Mack , Haojian Zhuang , Robert Jarzmik , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Matthias Brugger , Stephen Boyd , Yoshihiro Shimoda , Colin Ian King , Biju Das , Fabrizio Castro , "Gustavo A. R. Silva" , Yangtao Li , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org References: <1573541519-28488-1-git-send-email-chunfeng.yun@mediatek.com> <1573541519-28488-5-git-send-email-chunfeng.yun@mediatek.com> <20191112152857.GA5853@uda0271908> <20191114032018.GA122287@kroah.com> <20191114140234.GB5853@uda0271908> <20191115032153.GC793701@kroah.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20191115032153.GC793701@kroah.com> User-Agent: Mutt/1.9.4 (2018-02-28) X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191115_054343_850519_67AF501F X-CRM114-Status: GOOD ( 25.49 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Chen , Alexandre Belloni , "Gustavo A. R. Silva" , Yangtao Li , linux-kernel@vger.kernel.org, Minas Harutyunyan , Laurent Pinchart , Fabio Estevam , Florian Fainelli , Robert Jarzmik , Kevin Cernekee , Ludovic Desroches , bcm-kernel-feedback-list@broadcom.com, NXP Linux Team , Chunfeng Yun , Cristian Birsan , linux-media@vger.kernel.org, Fabrizio Castro , Sascha Hauer , Haojian Zhuang , Stephen Boyd , linux-mediatek@lists.infradead.org, Matthias Brugger , Mauro Carvalho Chehab , linux-arm-kernel@lists.infradead.org, Biju Das , Felipe Balbi , Yoshihiro Shimoda , linux-usb@vger.kernel.org, Pengutronix Kernel Team , Colin Ian King , Shawn Guo , Daniel Mack Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Nov 15, 2019 at 11:21:53AM +0800, Greg Kroah-Hartman wrote: > On Thu, Nov 14, 2019 at 08:02:34AM -0600, Bin Liu wrote: > > On Thu, Nov 14, 2019 at 11:20:18AM +0800, Greg Kroah-Hartman wrote: > > > On Tue, Nov 12, 2019 at 09:28:57AM -0600, Bin Liu wrote: > > > > Hi, > > > > > > > > On Tue, Nov 12, 2019 at 02:51:51PM +0800, Chunfeng Yun wrote: > > > > > Now the USB gadget subsystem can use the USB debugfs root directory, > > > > > so move musb's directory from the root of the debugfs filesystem into > > > > > the root of usb > > > > > > > > My opinion is this move is unnecessary. I breaks existing debug tools or > > > > documentation which is already published on Internet. > > > > > > Having a "root" directory for a single random driver seems like you are > > > making your driver a "very important" thing in the overall scheme of the > > > kernel, right? What's wrong with using the usb subdirectory like all > > > > Agree, it wasn't the right thing to do at the first place. But now > > changing it adds support burden, because people very often refer to the > > old information on the internet which no longer matches to the new > > location. Basically, it is a cost of ABI change. > > What information says that /sys/kernel/debug/mdev/ is the location for > this? Is it in-kernel? No, they are not in-kernel, but many places mainly on https://e2e.ti.com and http://processors.wiki.ti.com. It basically says to get musb regdump, cat /sys/kernel/debug/musb-hdrc.{0,1}/regdump, or to enter test mode, do echo _testmode_ > /sys/kernel/debug/musb-hdrc.{0,1}/testmode... > > > other USB drivers use (after this patch series is merged)? That feels > > > like a much more "sane" way to handle the wide-open debugfs namespace. > > > > Though I commented on this musb patch, my opinion is for this whole > > series, either drop the whole series or apply the whole series. > > I've applied all but this one and 2 others that did not build properly. Okay. > > > Yes, there are no rules when it comes to debugfs file names and > > > locations, but let's try to be sane please. > > > > Fine with me. I can still support questions such as "can't open > > /sys/kernel/debug/musb-hdrc.0/testmode: No such file or directory". > > What tool looks for that? I wrote a usb diagnosis tool called chkusb.sh, which basically checks usb related information in - /proc/config.gz - /lib/modules/`uname -r`/kernel/drivers/ - /proc/device-tree/ - /sys/device/ - /sys/kernel/debug/ So whenever I got a report on e2e.ti.com saying that usb doesn't work, I just post this script and get a log which would give a clue if there was any fundamental mistake in kernel configuration or deployment. But not a big issue here for this tool regarding this patch set, I can update the script to check both locations - /sys/kernel/debug/ and /sys/kernel/debug/usb/. -Bin. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel