From: Russell King - ARM Linux admin <linux@armlinux.org.uk>
To: Nicolas Saenz Julienne <nsaenzjulienne@suse.de>
Cc: linux-arm-kernel@lists.infradead.org, f.fainelli@gmail.com,
linux-kernel@vger.kernel.org,
"kernelci.org bot" <bot@kernelci.org>,
wahrenst@gmx.net
Subject: Re: [PATCH v2] ARM: dt: check MPIDR on MP devices built without SMP
Date: Mon, 18 Nov 2019 12:55:40 +0000 [thread overview]
Message-ID: <20191118125540.GW25745@shell.armlinux.org.uk> (raw)
In-Reply-To: <5abdcb0e0e1043a101f579ea65d07a1f6b91f896.camel@suse.de>
On Mon, Nov 18, 2019 at 12:49:04PM +0100, Nicolas Saenz Julienne wrote:
> On Fri, 2019-10-04 at 17:52 +0200, Nicolas Saenz Julienne wrote:
> > On SMP builds, in order to properly link CPU devices with their
> > respective DT nodes we start by matching the boot CPU. This is achieved
> > by comparing the 'reg' property on each of the CPU DT nodes with the
> > MPIDR. The association is necessary as to validate the whole CPU logical
> > map, which ultimately links CPU devices and their DT nodes.
No, that is not the primary purpose of the CPU logical map. The CPU
logical map is there to map the CPU logical number to a hardware number,
necessary for programming hardware.
> > On setups built without SMP, no MPIDR read is performed. The only thing
> > expected is for the 'reg' property in the CPU DT node to contain the
> > value 0x0.
> >
> > This causes problems on MP setups built without SMP. As their boot CPU
> > DT node contains the relevant MPIDR as opposed to 0x0. No match is then
> > possible. This causes troubles further down the line as drivers are
> > unable to get the CPU's DT node.
So the DT is incorrect for the platform - it is not describing the
hardware. Why can't the DT be fixed? Clearly, it would have never
worked with the mainline kernel today.
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line in suburbia: sync at 12.1Mbps down 622kbps up
According to speedtest.net: 11.9Mbps down 500kbps up
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-11-18 12:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-04 15:52 [PATCH v2] ARM: dt: check MPIDR on MP devices built without SMP Nicolas Saenz Julienne
2019-11-18 11:49 ` Nicolas Saenz Julienne
2019-11-18 12:55 ` Russell King - ARM Linux admin [this message]
2019-11-18 17:45 ` Nicolas Saenz Julienne
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191118125540.GW25745@shell.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=bot@kernelci.org \
--cc=f.fainelli@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nsaenzjulienne@suse.de \
--cc=wahrenst@gmx.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).