From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4B95EC432C0 for ; Mon, 18 Nov 2019 21:23:22 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1E6D8222DD for ; Mon, 18 Nov 2019 21:23:22 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="cmQE+qI/" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1E6D8222DD Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=QKaTLIMqFJty/b7hT7y4FhYKFrkXORaAoY+UaeiIX7o=; b=cmQE+qI/7jwpuy lRMBNDXafWuVpU7w6N4cgtJs1Bh187gjH7RqkA1HSpwLd5CW7+rUbcqEwKC1nVHaY9JhNAuLIN5mP IXmpetcK5XlVp+rxfrysJh1c7FalPDUqV1eiszyt6TbNs3i2aWShVtwq2+KiCRFz1IIqyguDaYG8M DnpM0uU2OKYyismJ5vA2vk/ya8xTlMls4pbedNIUhDluFWqhTUd8rVsNiD0n4nCO062nDy65644bR jmkBHyeU0JWRchf1UYI98C00ggQ4ULQjSPv0GK6xugPVkRYgmmoApBk254j8aLWdN306VmZ4sBJ4J wIHqyynnibyGA5rv6Qww==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iWoUT-0001uD-0o; Mon, 18 Nov 2019 21:23:21 +0000 Received: from mail-oi1-f194.google.com ([209.85.167.194]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iWoUN-0001tA-Lc; Mon, 18 Nov 2019 21:23:19 +0000 Received: by mail-oi1-f194.google.com with SMTP id 14so16723663oir.12; Mon, 18 Nov 2019 13:23:14 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=aslK2Zau5UQNVUGQIY5kjkRzSDnrxpv/018CjIjj4ig=; b=Rx7detXkOcTYUxMzdmpV/O8U+kkOMKUOHBuYTOysW7zE6pL3lfV065X7kQgFJ/Kpxs WYytHqEoZvUBlJ4jxowoduMBJee4amH84VVThPyDTyjJdHdCWaWGfAz62Hv3ebXIjeK5 bVMrg4ibGTf9MrFDU4VL/3Z71lYshTlkbjOTpaQ5mv1LJTSqGILxN7IYYixJ6ebq6+Z3 vvbRvQ4oBAkGCJhhxb1qqlA6fmMnPj4i28coHPC0s0haikqlUlPmAYAb49oRfjCqm44K I9g3695/5Ilo5+ZsEDjM0uksrj/f/g+pRvcxc9THmKEEwUGxKp6n6V4G1pYd5T2XDTmt /HDw== X-Gm-Message-State: APjAAAWUNvVnoebPVS0BoKLzPC5i+A59RKW2085T/aC5pPnoqtdF5EZZ eBaQawZAsj3fn5rcTfe+hhWZu/k= X-Google-Smtp-Source: APXvYqy9vLHIfptxJOZyAdofVkBHARL4vvFxl6WV3GMXs+WxxP4W8AujWNmvKD8eIz7DkSM9Gg1LIA== X-Received: by 2002:aca:4e88:: with SMTP id c130mr895664oib.41.1574112193960; Mon, 18 Nov 2019 13:23:13 -0800 (PST) Received: from localhost (24-155-109-49.dyn.grandenetworks.net. [24.155.109.49]) by smtp.gmail.com with ESMTPSA id u18sm6575789otq.31.2019.11.18.13.23.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 18 Nov 2019 13:23:12 -0800 (PST) Date: Mon, 18 Nov 2019 15:23:12 -0600 From: Rob Herring To: Nicolas Saenz Julienne Subject: Re: [PATCH v2 2/6] dt-bindings: PCI: Add bindings for brcmstb's PCIe device Message-ID: <20191118212312.GA24969@bogus> References: <20191112155926.16476-1-nsaenzjulienne@suse.de> <20191112155926.16476-3-nsaenzjulienne@suse.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20191112155926.16476-3-nsaenzjulienne@suse.de> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191118_132315_712106_178713E9 X-CRM114-Status: GOOD ( 20.07 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , devicetree@vger.kernel.org, Florian Fainelli , maz@kernel.org, phil@raspberrypi.org, linux-kernel@vger.kernel.org, jeremy.linton@arm.com, Eric Anholt , mbrugger@suse.com, bcm-kernel-feedback-list@broadcom.com, Stefan Wahren , james.quinlan@broadcom.com, linux-pci@vger.kernel.org, Bjorn Helgaas , andrew.murray@arm.com, linux-arm-kernel@lists.infradead.org, linux-rpi-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Nov 12, 2019 at 04:59:21PM +0100, Nicolas Saenz Julienne wrote: > From: Jim Quinlan > > The DT bindings description of the brcmstb PCIe device is described. > This node can only be used for now on the Raspberry Pi 4. > > Signed-off-by: Jim Quinlan > Co-developed-by: Nicolas Saenz Julienne > Signed-off-by: Nicolas Saenz Julienne > > --- > > Changes since v1: > - Fix commit Subject > - Remove linux,pci-domain > > This was based on Jim's original submission[1], converted to yaml and > adapted to the RPi4 case. > > [1] https://patchwork.kernel.org/patch/10605937/ > > .../bindings/pci/brcm,stb-pcie.yaml | 110 ++++++++++++++++++ > 1 file changed, 110 insertions(+) > create mode 100644 Documentation/devicetree/bindings/pci/brcm,stb-pcie.yaml > > diff --git a/Documentation/devicetree/bindings/pci/brcm,stb-pcie.yaml b/Documentation/devicetree/bindings/pci/brcm,stb-pcie.yaml > new file mode 100644 > index 000000000000..4cbb18821300 > --- /dev/null > +++ b/Documentation/devicetree/bindings/pci/brcm,stb-pcie.yaml > @@ -0,0 +1,110 @@ > +# SPDX-License-Identifier: GPL-2.0 > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/pci/brcm,stb-pcie.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Brcmstb PCIe Host Controller Device Tree Bindings > + > +maintainers: > + - Nicolas Saenz Julienne > + I added a common PCI schema to dt-schema. You can reference it here: allOf: - $ref: /schemas/pci/pci-bus.yaml# > +properties: > + compatible: > + const: brcm,bcm2711-pcie # The Raspberry Pi 4 > + > + reg: > + maxItems: 1 > + > + interrupts: > + minItems: 1 > + maxItems: 2 > + items: > + - description: PCIe host controller > + - description: builtin MSI controller > + > + interrupt-names: > + minItems: 1 > + maxItems: 2 > + items: > + - const: pcie > + - const: msi > + > + "#address-cells": > + const: 3 > + > + "#size-cells": > + const: 2 > + > + "#interrupt-cells": > + const: 1 > + > + interrupt-map-mask: true > + > + interrupt-map: true Drop all these as the pci-bus.yaml will cover them. > + > + ranges: true Do you know many entries, if not, you can drop it too? > + > + dma-ranges: true Do you know many entries, if not, you can drop it too? > + > + clocks: > + maxItems: 1 > + > + clock-names: > + items: > + - const: sw_pcie > + > + msi-controller: > + description: Identifies the node as an MSI controller. > + type: boolean > + > + msi-parent: > + description: MSI controller the device is capable of using. > + $ref: /schemas/types.yaml#/definitions/phandle Assume these 2 have a type defined. > + > + brcm,enable-ssc: > + description: Indicates usage of spread-spectrum clocking. > + type: boolean > + > +required: > + - compatible > + - reg > + - "#address-cells" > + - "#size-cells" > + - "#interrupt-cells" > + - interrupt-map-mask > + - interrupt-map > + - ranges > + - dma-ranges You can drop ranges, #address-cells and #size-cells as they are required in pci-bus.yaml. Shouldn't interrupts, interrupt-names, and msi-controller all be required? > + > +additionalProperties: false This won't work having the commmon binding, but 'unevaluatedProperties: false' will (eventually when json-schema draft8 is supported). > + > +examples: > + - | > + #include > + #include > + > + scb { > + #address-cells = <2>; > + #size-cells = <1>; > + pcie0: pcie@7d500000 { > + compatible = "brcm,bcm2711-pcie"; > + reg = <0x0 0x7d500000 0x9310>; > + #address-cells = <3>; > + #size-cells = <2>; > + #interrupt-cells = <1>; > + interrupts = , > + ; > + interrupt-names = "pcie", "msi"; > + interrupt-map-mask = <0x0 0x0 0x0 0x7>; > + interrupt-map = <0 0 0 1 &gicv2 GIC_SPI 143 IRQ_TYPE_LEVEL_HIGH > + 0 0 0 2 &gicv2 GIC_SPI 144 IRQ_TYPE_LEVEL_HIGH > + 0 0 0 3 &gicv2 GIC_SPI 145 IRQ_TYPE_LEVEL_HIGH > + 0 0 0 4 &gicv2 GIC_SPI 146 IRQ_TYPE_LEVEL_HIGH>; Bracket each entry. The schema is making this stricter. Rob _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel