From: David Miller <davem@davemloft.net>
To: rmk+kernel@armlinux.org.uk
Cc: andrew@lunn.ch, nbd@openwrt.org, f.fainelli@gmail.com,
michal.simek@xilinx.com, alexandre.torgue@st.com,
netdev@vger.kernel.org, sean.wang@mediatek.com,
linux-stm32@st-md-mailman.stormreply.com,
Mark-MC.Lee@mediatek.com, joabreu@synopsys.com,
linux-mediatek@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
thomas.petazzoni@bootlin.com, john@phrozen.org,
matthias.bgg@gmail.com, peppe.cavallaro@st.com,
radhey.shyam.pandey@xilinx.com, vivien.didelot@gmail.com,
mcoquelin.stm32@gmail.com, hkallweit1@gmail.com
Subject: Re: [RFC PATCH net-next] net: phylink: rename mac_link_state() op to mac_pcs_get_state()
Date: Tue, 19 Nov 2019 18:46:04 -0800 (PST) [thread overview]
Message-ID: <20191119.184604.2256080146904190716.davem@davemloft.net> (raw)
In-Reply-To: <E1iX2jg-0005Us-6U@rmk-PC.armlinux.org.uk>
From: Russell King <rmk+kernel@armlinux.org.uk>
Date: Tue, 19 Nov 2019 12:36:00 +0000
> Rename the mac_link_state() method to mac_pcs_get_state() to make it
> clear that it should be returning the MACs PCS current state, which
> is used for inband negotiation rather than just reading back what the
> MAC has been configured for. Update the documentation to explicitly
> mention that this is for inband.
>
> We drop the return value as well; most of phylink doesn't check the
> return value and it is not clear what it should do on error - instead
> arrange for state->link to be false.
>
> Signed-off-by: Russell King <rmk+kernel@armlinux.org.uk>
> ---
> This is something I'd like to do to make it clearer what phylink expects
> of this function, and that it shouldn't just read-back how the MAC was
> configured. However, it will require some testing and review as it
> changes quite a lot, and there's some things, particularly in DSA, that
> don't seem quite right from a phylink point of view, such as messing
> with state->interface in this function.
I don't have the expertiece to look into the DSA components of these
changes and your concerns.
Andrew, Florian, etc.?
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-11-20 2:46 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-19 12:36 [RFC PATCH net-next] net: phylink: rename mac_link_state() op to mac_pcs_get_state() Russell King
2019-11-20 2:46 ` David Miller [this message]
2019-11-21 2:17 ` Andrew Lunn
2019-11-21 3:52 ` Florian Fainelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191119.184604.2256080146904190716.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=Mark-MC.Lee@mediatek.com \
--cc=alexandre.torgue@st.com \
--cc=andrew@lunn.ch \
--cc=f.fainelli@gmail.com \
--cc=hkallweit1@gmail.com \
--cc=joabreu@synopsys.com \
--cc=john@phrozen.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=matthias.bgg@gmail.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=michal.simek@xilinx.com \
--cc=nbd@openwrt.org \
--cc=netdev@vger.kernel.org \
--cc=peppe.cavallaro@st.com \
--cc=radhey.shyam.pandey@xilinx.com \
--cc=rmk+kernel@armlinux.org.uk \
--cc=sean.wang@mediatek.com \
--cc=thomas.petazzoni@bootlin.com \
--cc=vivien.didelot@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).