Re: [PATCH v2 3/3] ARM: dts: bcm2711: Enable HWRNG support

Nicolas Saenz Julienne
2019-11-19T17:25:26Z

[-- Attachment #1.1: Type: text/plain, Size: 1242 bytes --]

On Tue, 2019-11-19 at 09:09 -0800, Stephen Brennan wrote:
> Hi Nicolas,
>
> On Tue Nov 19, 2019 at 11:07 AM, Nicolas Saenz Julienne wrote:
> > Hi Stephen, thanks for the follow-up.
> >
> >
> > On Mon, 2019-11-18 at 22:14 -0800, Stephen Brennan wrote:
> > > BCM2711 features a RNG200 hardware random number generator block, which i=
> > s
> > > different from the BCM283x from which it inherits. Move the rng block fro=
> > m
> > > BCM283x into a separate common file, and update the rng declaration of
> > > BCM2711.
> > > =20
> > > Signed-off-by: Stephen Brennan <stephen@brennan.io>
> > > ---
> >
> > It's petty in this case but you should add a list of changes here too.
>
> To make sure I understand, you mean listing out the changes in each
> revision of the patch series?

What's generally expected is for the cover letter to contain an overview of the
series changes. No need to go into specific detail. Then, every patch should
list its local modifications.

Also remember to add the list of changes after the '---' line in your patch,
this way they won't show up in the final commit log.

If in doubt have a look at the kernel mailing lists, there are plenty of
examples.

Regards,
Nicolas

[-- Attachment #1.2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

[-- Attachment #2: Type: text/plain, Size: 176 bytes --]