From: Niklas Cassel <niklas.cassel@linaro.org>
To: Stanimir Varbanov <stanimir.varbanov@linaro.org>
Cc: ulf.hansson@linaro.org, Catalin Marinas <catalin.marinas@arm.com>,
sboyd@kernel.org, linux-arm-msm@vger.kernel.org,
linux-kernel@vger.kernel.org, amit.kucheria@linaro.org,
bjorn.andersson@linaro.org, vireshk@kernel.org,
Will Deacon <will@kernel.org>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v5 5/5] arm64: defconfig: enable CONFIG_ARM_QCOM_CPUFREQ_NVMEM
Date: Tue, 19 Nov 2019 15:45:18 +0100 [thread overview]
Message-ID: <20191119144518.GA17086@centauri.ideon.se> (raw)
In-Reply-To: <aed0bac0-ca9d-febd-ac57-120e60e99e0d@linaro.org>
On Fri, Nov 15, 2019 at 02:44:03PM +0200, Stanimir Varbanov wrote:
> Hi Niklas,
>
> On 11/15/19 2:15 PM, Niklas Cassel wrote:
> > Enable CONFIG_ARM_QCOM_CPUFREQ_NVMEM.
>
> Shouldn't this be selected from qcom-cpr.c Kconfig ?
Hello Stan,
I can see where this is coming from.
If e.g. CONFIG_ARM_QCOM_CPUFREQ_NVMEM is selected but
CONFIG_QCOM_CPR is not, then the cpufreq driver will
return -EPROBE_DEFER, and will never probe successfully.
However, I don't really see a difference to any other
driver using a framework that the user has not enabled.
The driver will then use that framework's stubs, which
usually only return -ENODEV or similar.
So even though these both need to be enabled to work as
intended, they can be compiled/build tested separately.
Kind regards,
Niklas
>
> >
> > Signed-off-by: Niklas Cassel <niklas.cassel@linaro.org>
> > ---
> > arch/arm64/configs/defconfig | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
> > index 4385033c0a34..09aaffd473a0 100644
> > --- a/arch/arm64/configs/defconfig
> > +++ b/arch/arm64/configs/defconfig
> > @@ -88,6 +88,7 @@ CONFIG_ACPI_CPPC_CPUFREQ=m
> > CONFIG_ARM_ARMADA_37XX_CPUFREQ=y
> > CONFIG_ARM_SCPI_CPUFREQ=y
> > CONFIG_ARM_IMX_CPUFREQ_DT=m
> > +CONFIG_ARM_QCOM_CPUFREQ_NVMEM=y
> > CONFIG_ARM_QCOM_CPUFREQ_HW=y
> > CONFIG_ARM_RASPBERRYPI_CPUFREQ=m
> > CONFIG_ARM_TEGRA186_CPUFREQ=y
> >
>
> --
> regards,
> Stan
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2019-11-19 14:45 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-15 12:15 [PATCH v5 0/5] Add support for QCOM Core Power Reduction Niklas Cassel
2019-11-15 12:15 ` [PATCH v5 4/5] arm64: defconfig: enable CONFIG_QCOM_CPR Niklas Cassel
2019-11-15 12:15 ` [PATCH v5 5/5] arm64: defconfig: enable CONFIG_ARM_QCOM_CPUFREQ_NVMEM Niklas Cassel
2019-11-15 12:44 ` Stanimir Varbanov
2019-11-19 14:45 ` Niklas Cassel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191119144518.GA17086@centauri.ideon.se \
--to=niklas.cassel@linaro.org \
--cc=amit.kucheria@linaro.org \
--cc=bjorn.andersson@linaro.org \
--cc=catalin.marinas@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sboyd@kernel.org \
--cc=stanimir.varbanov@linaro.org \
--cc=ulf.hansson@linaro.org \
--cc=vireshk@kernel.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).