From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7F88CC432C0 for ; Wed, 20 Nov 2019 09:51:38 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3849421939 for ; Wed, 20 Nov 2019 09:51:38 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="n7CqPNn/"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=armlinux.org.uk header.i=@armlinux.org.uk header.b="Jq532s45" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3849421939 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=armlinux.org.uk Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=WyZnqcIXFYZeAg8OdLtg2l8vb4LOao8F4p66ewuYRmE=; b=n7CqPNn/o8WpRg iB6WdJf6oFXRTfa3e+Mf7rok3dwhMubR30rNVc76/h6etyna+0scxb1n07+Pvd1KBIiuPyPV9SZHB SGtA3kaSCom9DFQeUMwoxwij21CkuHNmyEWScne0b1gZLC/AG0IodafBarMbqQWb7mQd/s8tnBQQ4 j9KlzlEgkLHl8NwuY7hgHUBVV5oPnUvRDoT5nNm2VCS7bdejgoRBz3YMWp9oy+VVBijojDUtr3+v1 kzZ/LFHYev03Nyfg1uj2Q9NHqsl1HMd/Beg0/sFVWULOPFIIZgZSflfdOvumPBzbR74hiwkXoTLzL aUbFmtKraVRBTQZ7HocQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iXMe9-0002MG-K1; Wed, 20 Nov 2019 09:51:37 +0000 Received: from pandora.armlinux.org.uk ([2001:4d48:ad52:3201:214:fdff:fe10:1be6]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iXMe5-0002Lf-Ti for linux-arm-kernel@lists.infradead.org; Wed, 20 Nov 2019 09:51:35 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=wGnYD9LDfkF5KeMo2TrhNRWwflDYysKV8UNx+eBfq88=; b=Jq532s45lJdDrogvc2MJF/d9O UdOThQ1w/Vi77zoM/XJ5hwCtM1MdadGQb45KdiRx7UXDRF4CEWj1z8BytR4DGIWnOgnpHC9C3e24X 2XBdxfN1JeYOFGaItZQrCehZM9Inhma090cu1V6XJBrkNfNORYHLjSdOpVsvgbnnfcXjSEPoh1JD6 oE8exm9LjFcQAVtjH4DaarHPU8q4271LHdBgcikzcEj6+C+y4W6E4hRfH5Rxt5wCLyQrKZu36cDyN QJm9bA5Bru1hZxFdPK166VbPqmw0c06GQBjklP4sXbBIS/SQJu50PpNmsQBj8yRoKI+W57mhYpLBh iE/hrRKOw==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:42120) by pandora.armlinux.org.uk with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.90_1) (envelope-from ) id 1iXMdp-0007Wm-W4; Wed, 20 Nov 2019 09:51:18 +0000 Received: from linux by shell.armlinux.org.uk with local (Exim 4.92) (envelope-from ) id 1iXMdj-0001cj-TD; Wed, 20 Nov 2019 09:51:11 +0000 Date: Wed, 20 Nov 2019 09:51:11 +0000 From: Russell King - ARM Linux admin To: Masahiro Yamada Subject: Re: [PATCH] ARM: don't export unused return_address() Message-ID: <20191120095111.GI25745@shell.armlinux.org.uk> References: <20190906154706.2449696-1-arnd@arndb.de> <20191113114517.GO25745@shell.armlinux.org.uk> <20191113170058.GP25745@shell.armlinux.org.uk> <20191120090744.GH25745@shell.armlinux.org.uk> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191120_015133_960016_7F4F9E8E X-CRM114-Status: GOOD ( 25.65 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Arnd Bergmann , Linux Kernel Mailing List , Geert Uytterhoeven , Thomas Gleixner , Enrico Weigelt , Linux ARM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Nov 20, 2019 at 06:42:52PM +0900, Masahiro Yamada wrote: > Hi Russell, > > > On Wed, Nov 20, 2019 at 6:07 PM Russell King - ARM Linux admin > wrote: > > > > On Wed, Nov 20, 2019 at 06:02:13PM +0900, Masahiro Yamada wrote: > > > Hi Arnd, > > > > > > > > > > > > On Thu, Nov 14, 2019 at 2:01 AM Russell King - ARM Linux admin > > > wrote: > > > > > > > > On Wed, Nov 13, 2019 at 02:15:00PM +0100, Geert Uytterhoeven wrote: > > > > > Hi Russell, > > > > > > > > > > On Wed, Nov 13, 2019 at 12:45 PM Russell King - ARM Linux admin > > > > > wrote: > > > > > > On Wed, Nov 13, 2019 at 08:40:39PM +0900, Masahiro Yamada wrote: > > > > > > > On Tue, Oct 1, 2019 at 11:31 PM Geert Uytterhoeven wrote: > > > > > > > > On Fri, Sep 6, 2019 at 5:47 PM Arnd Bergmann wrote: > > > > > > > > > Without the frame pointer enabled, return_address() is an inline > > > > > > > > > function and does not need to be exported, as shown by this warning: > > > > > > > > > > > > > > > > > > WARNING: "return_address" [vmlinux] is a static EXPORT_SYMBOL_GPL > > > > > > > > > > > > > > > > > > Move the EXPORT_SYMBOL_GPL() into the #ifdef as well. > > > > > > > > > > > > > > > > > > Signed-off-by: Arnd Bergmann > > > > > > > > > > > > > > > > Thanks for your patch! > > > > > > > > > > > > > > > > Tested-by: Geert Uytterhoeven > > > > > > > > > > > > > > > > > --- a/arch/arm/kernel/return_address.c > > > > > > > > > +++ b/arch/arm/kernel/return_address.c > > > > > > > > > @@ -53,6 +53,7 @@ void *return_address(unsigned int level) > > > > > > > > > return NULL; > > > > > > > > > } > > > > > > > > > > > > > > > > > > > > > > > > > Checkpatch doesn't like the empty line above: > > > > > > > > > > > > > > > > WARNING: EXPORT_SYMBOL(foo); should immediately follow its function/variable > > > > > > > > > > > > > > > > > +EXPORT_SYMBOL_GPL(return_address); > > > > > > > > > + > > > > > > > > > #endif /* if defined(CONFIG_FRAME_POINTER) && !defined(CONFIG_ARM_UNWIND) */ > > > > > > > > > > > > > > > > > > -EXPORT_SYMBOL_GPL(return_address); > > > > > > > > > > > > What has happened to this patch? > > > > > > > > > > > > > > I still see this warning. > > > > > > > > > > > > Simple - it got merged, it caused build regressions, it got dropped. > > > > > > A new version is pending me doing another round of patch merging. > > > > > > > > > > I believe that was not Arnd's patch, but Ben Dooks' alternative solution[*]? > > > > > > > > I don't keep track of who did what, sorry. > > > > > > > > > Arnd, > > > > > > I believe this patch is the correct fix. > > > Could you please put it into Russell's patch tracker? > > > (patches@arm.linux.org.uk) > > > > Is there something wrong with: > > > > fb033c95c94c ARM: 8918/2: only build return_address() if needed > > > > I haven't seen any build issues with that. > > > Sorry, I had not checked Ben's patch because you said > "Simple - it got merged, it caused build regressions, it got dropped." That was 8918/1. Ben fixed his patch, and submitted an updated version. > Yup, I've checked it right now, > and it looks good to me. > > But, I do not see that commit in the latest linux-next > (next-20191120). > > Could you really apply it if you have not. It was applied last Friday and was pushed out there and then. $ git ls-remote zeniv | grep for-next 022eb8ae8b5ee8c5c813923c69b5ebb1e9612c4c refs/heads/for-next $ git lg for-next 022eb8ae8b5e ARM: 8938/1: kernel: initialize broadcast hrtimer based clock event device ... fb033c95c94c ARM: 8918/2: only build return_address() if needed I've no idea why linux-next doesn't have it. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTC broadband for 0.8mile line in suburbia: sync at 12.1Mbps down 622kbps up According to speedtest.net: 11.9Mbps down 500kbps up _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel