[PATCH] arm64: mm: Fix column alignment for UXN in kernel_page_tables

[PATCH] arm64: mm: Fix column alignment for UXN in kernel_page_tables

[Mark Brown]

UXN is the only individual PTE bit other than the PTE_ATTRINDX_MASK ones
which doesn't have both a set and a clear value provided, meaning that the
columns in the table won't all be aligned. The PTE_ATTRINDX_MASK values
are all both mutually exclusive and longer so are listed last to make a
single final column for those values. Ensure everything is aligned by
providing a clear value for UXN.

Signed-off-by: Mark Brown <broonie@kernel.org>
---
 arch/arm64/mm/dump.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm64/mm/dump.c b/arch/arm64/mm/dump.c
index 4997ce244172..ef4b3ca1e058 100644
--- a/arch/arm64/mm/dump.c
+++ b/arch/arm64/mm/dump.c
@@ -144,6 +144,7 @@ static const struct prot_bits pte_bits[] = {
 		.mask	= PTE_UXN,
 		.val	= PTE_UXN,
 		.set	= "UXN",
+		.clear	= "   ",
 	}, {
 		.mask	= PTE_ATTRINDX_MASK,
 		.val	= PTE_ATTRINDX(MT_DEVICE_nGnRnE),
-- 
2.20.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH] arm64: mm: Fix column alignment for UXN in kernel_page_tables

[Mark Rutland]

On Thu, Nov 21, 2019 at 01:51:32PM +0000, Mark Brown wrote:
> UXN is the only individual PTE bit other than the PTE_ATTRINDX_MASK ones
> which doesn't have both a set and a clear value provided, meaning that the
> columns in the table won't all be aligned. The PTE_ATTRINDX_MASK values
> are all both mutually exclusive and longer so are listed last to make a
> single final column for those values. Ensure everything is aligned by
> providing a clear value for UXN.
> 
> Signed-off-by: Mark Brown <broonie@kernel.org>

Acked-by: Mark Rutland <mark.rutland@arm.com>

Mark.

> ---
>  arch/arm64/mm/dump.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/arch/arm64/mm/dump.c b/arch/arm64/mm/dump.c
> index 4997ce244172..ef4b3ca1e058 100644
> --- a/arch/arm64/mm/dump.c
> +++ b/arch/arm64/mm/dump.c
> @@ -144,6 +144,7 @@ static const struct prot_bits pte_bits[] = {
>  		.mask	= PTE_UXN,
>  		.val	= PTE_UXN,
>  		.set	= "UXN",
> +		.clear	= "   ",
>  	}, {
>  		.mask	= PTE_ATTRINDX_MASK,
>  		.val	= PTE_ATTRINDX(MT_DEVICE_nGnRnE),
> -- 
> 2.20.1
> 

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH] arm64: mm: Fix column alignment for UXN in kernel_page_tables

[Catalin Marinas]

On Thu, Nov 21, 2019 at 01:51:32PM +0000, Mark Brown wrote:
> UXN is the only individual PTE bit other than the PTE_ATTRINDX_MASK ones
> which doesn't have both a set and a clear value provided, meaning that the
> columns in the table won't all be aligned. The PTE_ATTRINDX_MASK values
> are all both mutually exclusive and longer so are listed last to make a
> single final column for those values. Ensure everything is aligned by
> providing a clear value for UXN.
> 
> Signed-off-by: Mark Brown <broonie@kernel.org>

Queued for 5.5-rc1. Thanks.

-- 
Catalin

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel