From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 10038C432C0 for ; Thu, 21 Nov 2019 13:57:25 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D98C42070B for ; Thu, 21 Nov 2019 13:57:24 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="pJDCvnMy" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D98C42070B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=MdTOBw84wwhJxsTchG04BFV806XHrXu6fulOtgRPAcs=; b=pJDCvnMyXqd6uM oNbqPvkvWZADifvvCqxhsSJNrSWgHRu4faN4xK6DFwGSPrj6RCvQpxNWVKmxqjbEh0oW+GJgbC3FT RL0+DjxTzcz09r0ef3oEBYRzSicLkqhRy5aQEiuP3OpIMae29137eivF4gT7ZUmanY6cjHg/f7q17 komiDWHPFMnRKFP4BR00lERQrHJVzkjn9SUS84vA8nTJst14TFnqcDXKEprInUdlNqRb0RpbKZSSx 35E6Nt8HNIXUf+maMuitb7Qy40o/4VbmwB7wJ3UxhwA45XDMaZlyJ97GzRBLAUXswe4J268nwIXiR 2zUnu/PgNO1hOOEE6K5Q==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iXmxU-0003Zq-LY; Thu, 21 Nov 2019 13:57:20 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iXmxR-0003ZS-Dc for linux-arm-kernel@lists.infradead.org; Thu, 21 Nov 2019 13:57:18 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id E0C56DA7; Thu, 21 Nov 2019 05:57:15 -0800 (PST) Received: from lakrids.cambridge.arm.com (usa-sjc-imap-foss1.foss.arm.com [10.121.207.14]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 12ADC3F703; Thu, 21 Nov 2019 05:57:14 -0800 (PST) Date: Thu, 21 Nov 2019 13:57:10 +0000 From: Mark Rutland To: Mark Brown Subject: Re: [PATCH] arm64: mm: Fix column alignment for UXN in kernel_page_tables Message-ID: <20191121135710.GA3454@lakrids.cambridge.arm.com> References: <20191121135132.22480-1-broonie@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20191121135132.22480-1-broonie@kernel.org> User-Agent: Mutt/1.11.1+11 (2f07cb52) (2018-12-01) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191121_055717_500033_619C33BE X-CRM114-Status: GOOD ( 16.19 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Catalin Marinas , Laura Abbott , Will Deacon , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Nov 21, 2019 at 01:51:32PM +0000, Mark Brown wrote: > UXN is the only individual PTE bit other than the PTE_ATTRINDX_MASK ones > which doesn't have both a set and a clear value provided, meaning that the > columns in the table won't all be aligned. The PTE_ATTRINDX_MASK values > are all both mutually exclusive and longer so are listed last to make a > single final column for those values. Ensure everything is aligned by > providing a clear value for UXN. > > Signed-off-by: Mark Brown Acked-by: Mark Rutland Mark. > --- > arch/arm64/mm/dump.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/arm64/mm/dump.c b/arch/arm64/mm/dump.c > index 4997ce244172..ef4b3ca1e058 100644 > --- a/arch/arm64/mm/dump.c > +++ b/arch/arm64/mm/dump.c > @@ -144,6 +144,7 @@ static const struct prot_bits pte_bits[] = { > .mask = PTE_UXN, > .val = PTE_UXN, > .set = "UXN", > + .clear = " ", > }, { > .mask = PTE_ATTRINDX_MASK, > .val = PTE_ATTRINDX(MT_DEVICE_nGnRnE), > -- > 2.20.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel