From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CBAD1C432C0 for ; Tue, 26 Nov 2019 20:34:57 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 91AF120684 for ; Tue, 26 Nov 2019 20:34:57 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="UYStcBNx" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 91AF120684 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=RdQ2yevV8J7fA7WGyY1Ln/ie52LGav2WRDdA2Ld18+M=; b=UYStcBNx5ldPZh PImu4a67iBolNXddkpxruzq1GjZVRC9m6+aGxCdEz09UY8XsjFUPXbzyq+mLO/j6p972ehrJFq9TF JuKOFFrz40JOt65islgnlygty03bC/HvaoymwWR8RKyOEaGB5EV6mBwTwGkL82t0X2MzfXP4UJrx7 GPXZwWBu8vjVdHeulMRE7cGbFr1K+ZCGHRTar5xErcuntE8hylLNH9rPJVKaxvqovzAQR5IU9uLcd 8GQW0XOACa4TbGEvEjn708a+qAQinHSl/Z098Yb95OTabHYRPFMxapPSGkW6dXeGrfHe6Jkcpt2Cc d/QBpBlNPu1ESwsurc2Q==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iZhXv-0002Hl-9E; Tue, 26 Nov 2019 20:34:51 +0000 Received: from mail-io1-f68.google.com ([209.85.166.68]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iZhXs-0002Gy-2S for linux-arm-kernel@lists.infradead.org; Tue, 26 Nov 2019 20:34:49 +0000 Received: by mail-io1-f68.google.com with SMTP id p12so14820999iog.10 for ; Tue, 26 Nov 2019 12:34:45 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=eCiyINJIqZQ9+c/j9O3wV96E5XzkXxVGgIEzTJ6ccpU=; b=UkffxNSSPWqsNsa+MmjDiuScFu8+Cx+JlCH1oSIxOfCP8vtXGmHwPkDJsZtq/knsqu MdynwWIHatk7Q+2cGc5Yw+vR5bjGvuerzv0wNqsVp83CY0BlAEg6+6uDprXWlPZ6X34B TxpDCXeCmhXh9nNeSBF+aHrFFE+t9T+e1q3UmG3qjlnJvYy96glmL08Q3MOEsTnhYujM +abmWzBeHmPLp0vLtiTPODEi00bJYQBZT9WcODP5q1zE3eUrcvkteAHkW3dxvkV+zc1s M9O/S8T6cm9VALOQDvCQK+RR/vAo/bJWtLMNPb2U3Bzl2Bz7w2fiSzE2l+cYzq6Ovx2U RoDA== X-Gm-Message-State: APjAAAWAu1eX3sY8KQ4eleRJmL0xm5fch0iowg4vLA+hqvxSmnf+LoZV zqW9VHQhJCFG0xhPZ67AKA== X-Google-Smtp-Source: APXvYqyNLRbXmRMw2om5THIIvUDL/2IP2aEwIaLwJGNOkUm6TYCHlgggxCi3KYF+cIwCDLGz2FM3sA== X-Received: by 2002:a6b:f317:: with SMTP id m23mr17361728ioh.303.1574800484514; Tue, 26 Nov 2019 12:34:44 -0800 (PST) Received: from localhost ([64.188.179.253]) by smtp.gmail.com with ESMTPSA id k22sm2923474iot.34.2019.11.26.12.34.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 Nov 2019 12:34:43 -0800 (PST) Date: Tue, 26 Nov 2019 13:34:42 -0700 From: Rob Herring To: Masahiro Yamada Subject: Re: [PATCH v3] libfdt: define INT32_MAX and UINT32_MAX in libfdt_env.h Message-ID: <20191126203442.GA20537@bogus> References: <20191113071202.11287-1-yamada.masahiro@socionext.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20191113071202.11287-1-yamada.masahiro@socionext.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191126_123448_115324_C03499A0 X-CRM114-Status: GOOD ( 19.28 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, Michael Ellerman , linuxppc-dev@lists.ozlabs.org, Russell King , linux-kernel@vger.kernel.org, Paul Mackerras , Benjamin Herrenschmidt , Frank Rowand , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Nov 13, 2019 at 04:12:02PM +0900, Masahiro Yamada wrote: > The DTC v1.5.1 added references to (U)INT32_MAX. > > This is no problem for user-space programs since defines > (U)INT32_MAX along with (u)int32_t. > > For the kernel space, libfdt_env.h needs to be adjusted before we > pull in the changes. > > In the kernel, we usually use s/u32 instead of (u)int32_t for the > fixed-width types. > > Accordingly, we already have S/U32_MAX for their max values. > So, we should not add (U)INT32_MAX to any more. > > Instead, add them to the in-kernel libfdt_env.h to compile the > latest libfdt. > > Signed-off-by: Masahiro Yamada > --- > > My initial plan was to change this in a series of 3 patches > since it is clean, and reduces the code. > > [1/3] https://lore.kernel.org/patchwork/patch/1147095/ > [2/3] https://lore.kernel.org/patchwork/patch/1147096/ > [3/3] https://lore.kernel.org/patchwork/patch/1147097/ > > 1/3 is stuck in the license bikeshed. > > For 2/3, I have not been able to get Ack from Russell. > > So, I chose a straight-forward fixup. > > > Changes in v3: > - Resend as a single patch > > arch/arm/boot/compressed/libfdt_env.h | 4 +++- > arch/powerpc/boot/libfdt_env.h | 2 ++ > include/linux/libfdt_env.h | 3 +++ > 3 files changed, 8 insertions(+), 1 deletion(-) Applied. Rob _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel