From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 62227C432C0 for ; Wed, 27 Nov 2019 18:19:50 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 323762070B for ; Wed, 27 Nov 2019 18:19:50 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="ccX01BZq"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="yCI00rr6" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 323762070B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Dkc7ISNrTY2iNrvb2NiaCHEi7Zcmsh3I39i2jqVuRYI=; b=ccX01BZq6JYbYv VBnH+HvKW6BEITQa5mtMHasiKbTwC6NVarEqnK/tL8Ei/FaPpplsBvEQbiH0enkNTCEBtXaQG2QZc 9nB/xpwBT86gmSN3BJGJbUjXxX2rFu3HxykJScIrTpz8GwSXRisTgufuXTGEoizBKNHO38X6izi0p VhzL2duD0GLEZEi2D9Bc+uY/reJD2aVwfvlpr5ndugfGgwOWy+1ix2cPT98YQRLCXnG/Obs9JB3R/ hmIW3WNWK9S/62Ai5dATsfhCcFuE0omC9IyXoX00yxnou0BiQipVn/UJqMoeDWQ2TNAwLKPWx9AkY xUA68fmrpU13XeQmhbvw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1ia1uj-0007hw-PZ; Wed, 27 Nov 2019 18:19:45 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1ia1uh-0007gw-5P for linux-arm-kernel@lists.infradead.org; Wed, 27 Nov 2019 18:19:44 +0000 Received: from sol.localdomain (c-24-5-143-220.hsd1.ca.comcast.net [24.5.143.220]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 3DEA72070B; Wed, 27 Nov 2019 18:19:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1574878782; bh=3z/LI0ZW+lWzsFFtnbhGfCPlI9pGPLBMxsnuKFuuTxE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=yCI00rr6Y6zcqdb8oSw3hpBOnEFRedT3VgxdgpCBrRq0CHnPg+iFvzaoFjMMou/tm lLPWW4i7EsV+xNfeARsrDmT3BPHdCbbuKt0StnvdNbWj4KfPY5Lrlcirz5leqh+QAk DLwSqC8CR65E43Xx9abjOEfXf/edj6DU1MR/MyR0= Date: Wed, 27 Nov 2019 10:19:40 -0800 From: Eric Biggers To: Sami Tolvanen Subject: Re: [PATCH v3] crypto: arm64/sha: fix function types Message-ID: <20191127181940.GB49214@sol.localdomain> References: <20191112223046.176097-1-samitolvanen@google.com> <20191119201353.2589-1-samitolvanen@google.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20191119201353.2589-1-samitolvanen@google.com> User-Agent: Mutt/1.12.2 (2019-09-21) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191127_101943_223333_C52E2EA9 X-CRM114-Status: UNSURE ( 7.88 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Herbert Xu , Ard Biesheuvel , linux-kernel@vger.kernel.org, linux-crypto@vger.kernel.org, Ard Biesheuvel , linux-arm-kernel@lists.infradead.org, Kees Cook Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Nov 19, 2019 at 12:13:53PM -0800, Sami Tolvanen wrote: > +static void __sha1_ce_transform(struct sha1_state *sst, u8 const *src, > + int blocks) > +{ > + return sha1_ce_transform(container_of(sst, struct sha1_ce_state, sst), > + src, blocks); > +} > + 'return' isn't needed in functions that return void. Likewise everywhere else in this patch. Otherwise this patch looks fine. - Eric _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel