From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.0 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 674E6C432C0 for ; Thu, 28 Nov 2019 14:36:09 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3BD9521741 for ; Thu, 28 Nov 2019 14:36:09 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="RoDjrHvX"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="RhXR0ZeX" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3BD9521741 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=8gqFmpPoREfK6DyMpYuA+x5dJlZ0tCBd/R5TXpw1ZEI=; b=RoDjrHvX7LX+Fh hT3OdmYyjBMP+xvXjdb2oq5yoTunA0DZMnla2iGVuLFUd4+IhCGi3U5aRJTP3LBk1niuDKq/E1PUe dcFIReJCfRjUv8xE0UowGQXVSFIcWsNk/TcDc2LRxmqmRfVYfnoVM+xrB3InyzBjTeSG3dxBP/NG6 QWipENIHr+29DS1p30te/Esgm2hTCK0qtxCeG3zVtrWKHNQouH0/z1XlpAgrT4EnCy0tvmn/1mkhk FKG9wZAEkop30LjrXVAkf3ebrDDE/4rUz6h1t6kEugYzoDwNdwnhNr0tn0tx2WBk/NliPvG8HOz+m l95l+Pc4iSbJQbeIlkTA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iaKts-0008QL-D4; Thu, 28 Nov 2019 14:36:08 +0000 Received: from mail-wm1-x342.google.com ([2a00:1450:4864:20::342]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iaKtp-0008Pc-7x for linux-arm-kernel@lists.infradead.org; Thu, 28 Nov 2019 14:36:07 +0000 Received: by mail-wm1-x342.google.com with SMTP id l17so11234677wmh.0 for ; Thu, 28 Nov 2019 06:36:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=RKiEZcP/L0A2rXbC8H4X5BIo7afN1A6dEGoky6fB7+8=; b=RhXR0ZeX7CH630cBBVDoTbDoIg+bfQnEe2e5PKJaG+yclednb5kM9Y8Eng7aDWJBHD FU+5IR6gwHueelOoVC5PQ9vj7rTsr6WVwO/xezZKm9KcUrDbc3Y5NXad2IRnlpsxCcqK Gss6Um5uf+b8l7ectAJJFFZnmILUBtHFPQkOue+8KkSReFVzzVWOau+8x2QV2jTKpVYL nyzYgq5pEwhmLshnmQ3nFu6lftJ7Biw967BKpgd1OE56aukGAWt0nMdm00/+wDERZqc3 DmGmmlALK+fd77in10AzgYAaYH6EW0ZfplukAUtqjF0UMXZX/qOaWtJlVTN1gUV6QRfJ 6q0A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=RKiEZcP/L0A2rXbC8H4X5BIo7afN1A6dEGoky6fB7+8=; b=ZOUH4Yl8lcZLLYYcx0Xyb8Azf/FBe2rrI9Dm46CA9UhMzJN0f2irKdTHrwjg7yOzBv FKdoA9c9uDJnOwz9ajpxHlILTsLUDqZE+EjI9f/mlNvkOfEG0UBb39eNQRACmIKZU/Hk luSUi3b/9+K3u4zPWaQWEawIdVJ9C4SB46Bz6UwKpfdcbuLM/mTIWVY0GvnlM4atkiZU kMt9HFhfcejUTaB3daE6C2Xayqjr+bDaJg32hylwlqlaUPVGKos6bs1Vj5PdTSL3xkSQ FsJCttd3YzQ470J3xndSZqsmO3R8KcmKd0yWVdWHol70Mya+aOOtrZKZrsQF60EkMKuc Sxgw== X-Gm-Message-State: APjAAAXgZgRUWlnyzThkv8MnuWSQwAVGHmuOS+Dml0xDvUYtZGl3Ig/i DFx+/KgUIwEc6caGixA3oZA= X-Google-Smtp-Source: APXvYqz92pJeCW/D9VAvn7Uh3kFxNyM3AMWtDGRKPIpvVxERBR51hrNagMQf2h4L/AmqzwtIH2/3AA== X-Received: by 2002:a7b:c95a:: with SMTP id i26mr10220347wml.41.1574951763538; Thu, 28 Nov 2019 06:36:03 -0800 (PST) Received: from localhost ([193.47.161.132]) by smtp.gmail.com with ESMTPSA id m15sm23751006wrj.52.2019.11.28.06.36.02 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 28 Nov 2019 06:36:02 -0800 (PST) Date: Thu, 28 Nov 2019 13:16:44 +0100 From: Oliver Graute To: Marc Gonzalez Subject: Re: [PATCH] arm64: defconfig: Change CONFIG_AT803X_PHY from m to y Message-ID: <20191128121644.GD2460@optiplex> References: <20191127124638.GC5108@optiplex> <1ed54a69-c29f-6008-02ae-11d16f68b265@free.fr> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1ed54a69-c29f-6008-02ae-11d16f68b265@free.fr> User-Agent: Mutt/1.9.4 (2018-02-28) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191128_063605_282524_AFA7BD7F X-CRM114-Status: GOOD ( 19.93 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Andrew Lunn , Peng Fan , Florian Fainelli , Anson Huang , =?iso-8859-1?Q?Andr=E9?= Draszik , LKML , Russell King , dl-linux-imx , Fabio Estevam , Linux ARM , Heiner Kallweit Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 28/11/19, Marc Gonzalez wrote: > On 27/11/2019 13:46, Oliver Graute wrote: > > > On 27/11/19, Marc Gonzalez wrote: > > > >> On 26/11/2019 15:54, Oliver Graute wrote: > >> > >>> this patch broke my imx8qm nfs setup. With the generic phy driver my > >>> board is booting fine. But with the AT803X_PHY=y enabled I'm running > >>> into the following phy issue. So on my side it looks inverse as on > >>> yours. What is the best proposal to fix this? > >>> > >>> [ 5.550442] fec 5b040000.ethernet eth0: Link is Up - 1Gbps/Full - flow control off > >>> [ 5.573206] Sending DHCP requests ...... timed out! > >>> [ 95.339702] IP-Config: Retrying forever (NFS root)... > >>> [ 95.348873] Atheros 8035 ethernet 5b040000.ethernet-1:06: attached PHY driver [Atheros 8035 ethernet] (mii_bus:phy_addr=5b040000.ethernet-1:06, irq=POLL) > >>> [ 99.438443] fec 5b040000.ethernet eth0: Link is Up - 1Gbps/Full - flow control off > >>> [ 99.461206] Sending DHCP requests ...... timed out! > >> > >> Which DTS are you using? > > > > I'am using this DTS which I'am currently working on: > > > > https://lists.infradead.org/pipermail/linux-arm-kernel/2019-October/689501.html > >> > >> I bet one dollar that 6d4cd041f0af triggered a latent bug in the DTS. > > > > So what should I fix in my device tree? > > In the board DTS I used to work on, I had this: > > ð0 { > phy-connection-type = "rgmii-id"; > phy-handle = <ð0_phy>; > #address-cells = <1>; > #size-cells = <0>; > > /* Atheros AR8035 */ > eth0_phy: ethernet-phy@4 { > compatible = "ethernet-phy-id004d.d072", > "ethernet-phy-ieee802.3-c22"; > interrupts = <37 IRQ_TYPE_EDGE_RISING>; > reg = <4>; > }; > }; > > In your DTS, you #include "imx8qm.dtsi" > I found no such file: > $ git ls-files | grep imx8qm yes this file is not yet added to Shawn Guos next tree. Latest patch can be found here: https://patchwork.kernel.org/patch/11248331/ > > In your patch: > https://patchwork.kernel.org/patch/11211567/ > > +&fec1 { > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_fec1>; > + phy-mode = "rgmii-txid"; > + phy-handle = <ðphy0>; > + fsl,magic-packet; > + fsl,rgmii_rxc_dly; > + status = "okay"; > + > + mdio { > + #address-cells = <1>; > + #size-cells = <0>; > + > + ethphy0: ethernet-phy@0 { > + compatible = "ethernet-phy-ieee802.3-c22"; > + reg = <4>; > + at803x,eee-disabled; > + at803x,vddio-1p8v; > + }; > + }; > +}; > > Try all possible 'phy-mode' (rgmii, rgmii-id, rgmii-rxid, rgmii-txid) > Investigate 'fsl,rgmii_rxc_dly' (it's not a standard Linux DT prop) > Documentation/devicetree/bindings/net/ethernet-controller.yaml thx for this hint. Best regards, Oliver _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel