From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.0 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FAKE_REPLY_C,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 15373C432C0 for ; Fri, 29 Nov 2019 07:57:43 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C75BB21721 for ; Fri, 29 Nov 2019 07:57:42 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="PmNZtWvj"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="oX9ygkYV" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C75BB21721 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:References: List-Owner; bh=1L7uxkcqQkpQcsWUGIwVmpo+ickBS0DTAK/kU1iQ3Mc=; b=PmNZtWvjDkpSzE PGr4EKxYbAveYiVmgdx6cIUPseBMP+iY2iRZarX6aCGUWkZcUS0zugRg9K9sgmGqHGZCeQPqBLOqX R7y8rHV3glIZ80Z5eLADxvSurGinExZzwd+dYJXhUdbh3nO7vZAR1V4PYMDueuciksdioi4/ZfnXr 0RJeNoxinURKYVpETRkaP+uCTqnpfetWQ4dWzmsT0R79SixHnfUaigyhWyApflU36JagRFHDEclGG qX418YLbTO2rmD7Wdk3qWZVlnSGnPTiokY6OmA0gnpxZxLX82NbTpROcOtNBqSIdYwOStKPhnIUBF Si4/k3hkiMqKQNcKhQyQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iab9n-0001vX-Mf; Fri, 29 Nov 2019 07:57:39 +0000 Received: from mail-wm1-x342.google.com ([2a00:1450:4864:20::342]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iab9k-0001v3-Et for linux-arm-kernel@lists.infradead.org; Fri, 29 Nov 2019 07:57:37 +0000 Received: by mail-wm1-x342.google.com with SMTP id p17so1034729wmi.3 for ; Thu, 28 Nov 2019 23:57:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:mime-version:content-disposition :in-reply-to:user-agent; bh=hClcGyZUyRAdPFEjS9zD1iTFQS5wk4UVwSxzy8NeBsE=; b=oX9ygkYVmfkmhy6yyVe5qnMqSvemShkjRnoGFQwH7OJmhzPZH5d1VXD4Z3Sx71BBfN OmqfwNUjNEazDwZ6pgmaO/EbVx2503hXI4aZwkUfbHFKJ7u1TYerNMrH/huLTXmZOojX ahP9UJAX5MYBNSC8wAEhjh8VQQNkOfelHW+79ryd+XKSJXWvarrlVQpRtemr3UMXXAUe nfgrP/MiD+QbYie1y9yVFntFeRMzyalEwWxFbCcEDJkzaGb8hWhY0jfQqg3iNHycfEhW nkOvqZs1uifx1VTdoJSQ3+RCr12fIzmD2yTuj4KqS9r1i36n7AuXtNQzR4t15BLjRQaF YXPw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:mime-version :content-disposition:in-reply-to:user-agent; bh=hClcGyZUyRAdPFEjS9zD1iTFQS5wk4UVwSxzy8NeBsE=; b=RWdXSP5CM7c+wi0OaRpZ/L+s6/mBOJT1wifxxE3OrzpQNsGQ2zPRYEKlxqx8xNq8Cz aBKSPXdprh9M4xk8XdoD4dAwTCdUCJIwJG/xRXL74OcYeFFAGtSNM31TZU6zmJsTvbu0 8CWMW0NF9jdSOmzYsheh52n6zgPOik5UTwr+3hb0frZj2fQCHfmu3oWtWSFUPnYcxs25 1SCqmhsWmqtQ52oaEJDq3xg8/cxNc2w6CHGx29DCxc2yyrd23hbyNV5DB/LC+rM8ms8H oMroif99rgN2n91IhZRa3pp/rXT1Yv1U4PHInIcL/PQ/RDtkQvRy2HFh1zaoOAXwAm0Y qxfA== X-Gm-Message-State: APjAAAXLOMonz4vfXafsR6f6dw5VQd6IqjfldWdvD/GGAvpRn2MX9WMc 5CpVQhHBXK3+XspoDZQzfUY= X-Google-Smtp-Source: APXvYqzzIc2cg6FFoHZWnQAg16nZrA34PO73gfpwf17n8oEimaxGpOKXuawypKW0iXLZZluncDmwgQ== X-Received: by 2002:a05:600c:21d6:: with SMTP id x22mr13267705wmj.126.1575014253972; Thu, 28 Nov 2019 23:57:33 -0800 (PST) Received: from localhost ([193.47.161.132]) by smtp.gmail.com with ESMTPSA id c1sm25745470wrs.24.2019.11.28.23.57.32 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 28 Nov 2019 23:57:33 -0800 (PST) Date: Fri, 29 Nov 2019 08:56:49 +0100 From: Oliver Graute To: Marc Gonzalez Subject: Re: [RFC PATCH 1/1] arm64: dts: added basic DTS for qmx8 congatec board Message-ID: <20191129075649.GE2460@optiplex> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191128_235736_499479_43CB19C0 X-CRM114-Status: GOOD ( 13.64 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: DTR , Rob Herring , "netdev@vger.kernel.org Linux ARM" , "linuxppc-dev@lists.ozlabs.org Pantelis Antoniou" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 28/11/19, Marc Gonzalez wrote: > On 28/11/2019 10:55, Oliver Graute wrote: > > > On 28/11/19, Marc Gonzalez wrote: > > > >> On 29/10/2019 13:23, Oliver Graute wrote: > >> > >>> +&fec1 { > >>> + pinctrl-names = "default"; > >>> + pinctrl-0 = <&pinctrl_fec1>; > >>> + phy-mode = "rgmii"; > >>> + phy-handle = <ðphy0>; > >>> + fsl,magic-packet; > >>> + fsl,rgmii_txc_dly; > >>> + fsl,rgmii_rxc_dly; > >>> + status = "okay"; > >> > >> The two fsl,rgmii* properties do not exist in mainline. > >> I suppose there were copied from downstream? > > > > you are right, I'll remove them. > > You should first check what the downstream driver does for them. > And check if there is an equivalent action in mainline. > These delays tend to be required for the PHY to work at all. ok as far as I see there is currently no equilant action in mainline. Downstream linux-imx use rgmii_txc_dly and rgmii_rxc_dly in fec_probe() and fec_restart() for some imx8qm-fec and imx8mq-fec PHY delay quirks. Perhaps this missing quirks are related to the random crashes in that driver I have with imx8qm. [ 129.211959] fec 5b040000.ethernet eth0: rcv is not +last [ 129.217300] fec 5b040000.ethernet eth0: rcv is not +last [ 129.222647] fec 5b040000.ethernet eth0: rcv is not +last [ 129.227966] fec 5b040000.ethernet eth0: rcv is not +last [ 129.233282] fec 5b040000.ethernet eth0: rcv is not +last Best regards, Oliver _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel