From: Andrew Lunn <andrew@lunn.ch>
To: Baruch Siach <baruch@tkos.co.il>
Cc: Gregory Clement <gregory.clement@bootlin.com>,
Jason Cooper <jason@lakedaemon.net>,
linux-arm-kernel@lists.infradead.org,
Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>
Subject: Re: [PATCH] ARM: dts: mvebu: add support for SolidRun Clearfog GTR
Date: Fri, 29 Nov 2019 18:07:17 +0100 [thread overview]
Message-ID: <20191129170717.GC28308@lunn.ch> (raw)
In-Reply-To: <3a870e11b152e2f8ffb2b3256c5ac42741658c4c.1574960406.git.baruch@tkos.co.il>
On Thu, Nov 28, 2019 at 07:00:06PM +0200, Baruch Siach wrote:
> SolidRun Clearfog GTR L8 and S4 SBCs are based on Armada 385. They
> features 8 (L8) or 4 (S4) switched Ethernet ports, 1 1Gb Ethernet port,
> 1 directly connected SFP port, 1 SFP port behind the switch (not
> currently described in DT),
Hi Baruch
Did you try to add the SFP on the switch? What problems did you have?
The general support for it should be there.
> + i2c@11100 { /* SFP */
> + pinctrl-0 = <&cf_gtr_i2c1_pins>;
> + pinctrl-names = "default";
> + status = "okay";
> + };
Since there are two SFPs, it would be a good idea to indicate which
one this is.
> + sfp: sfp {
> + compatible = "sff,sfp";
> + i2c-bus = <&i2c1>;
> + los-gpio = <&gpio1 22 GPIO_ACTIVE_HIGH>;
> + mod-def0-gpio = <&gpio0 25 GPIO_ACTIVE_LOW>;
> + tx-disable-gpio = <&gpio1 14 GPIO_ACTIVE_HIGH>;
> + };
when you get the second sfp working you are going to have naming
issue. So maybe call this sfp0?
> + led1 {
> + label = "led1";
> + gpios = <&gpio1 10 GPIO_ACTIVE_HIGH>;
> + };
> +
> + led2 {
> + label = "led2";
> + gpios = <&gpio1 20 GPIO_ACTIVE_HIGH>;
> + };
There is a naming convention of LEDS labels. This does not fit it.
> +&gpio0 {
> + pinctrl-0 = <&cf_gtr_fan_pwm>;
> + pinctrl-names = "default";
> +
> + wifi-disable {
> + gpio-hog;
> + gpios = <30 GPIO_ACTIVE_LOW>, <31 GPIO_ACTIVE_LOW>;
> + output-low;
> + line-name = "wifi-disable";
> + };
> +};
Isn't there a generic rfkill GPIO driver? Never looked, but it seems
like it should exist.
> + sar-isolation {
> + gpio-hog;
> + gpios = <15 GPIO_ACTIVE_LOW>;
> + output-low;
> + line-name = "sar-isolation";
> + };
What is SAR?
Andrew
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-11-29 17:07 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-28 17:00 [PATCH] ARM: dts: mvebu: add support for SolidRun Clearfog GTR Baruch Siach
2019-11-29 17:07 ` Andrew Lunn [this message]
2019-12-01 6:46 ` Baruch Siach
2019-12-01 17:07 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191129170717.GC28308@lunn.ch \
--to=andrew@lunn.ch \
--cc=baruch@tkos.co.il \
--cc=gregory.clement@bootlin.com \
--cc=jason@lakedaemon.net \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=sebastian.hesselbarth@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).