From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 40D9EC432C0 for ; Fri, 29 Nov 2019 17:07:44 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0BFD7215A5 for ; Fri, 29 Nov 2019 17:07:43 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="a835bn8M"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="spylNlP7" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0BFD7215A5 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lunn.ch Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=tKXu//Rx2bujzhiAPiF7abi3gLQkPmHBUa041a+upxM=; b=a835bn8MOJsZRn VJLSHqiiGz6+D/c6yXC52ixYSMe31Jv9IVTRE49g2qt+GwX/oE6yXtCyHOKe+9qwfX0x5D3NQh+OI oxM/WEBuYVBoN3DeIqOmftGQLyFDKyTF170Fs+S15QiJrf59POHsLISYVK01qxSlGk/0GbmntGW++ 9Z4S1854b30Nq6y91JUy+xvUhcuoSUhRXrBXVg+e+5XJ71MMn77Hfgt8v5PJ8T/Jl3WFtsgNOKoKh NeFkxWCRsi+B7Bs3tADN3XlwNCsWJ6pUUTsrRNv+O091XP+gJcW22ozOvElj4Jh8lP4AWNV4aM2uB d16n0Bu+IImczz5yYJeQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iajk2-0006TH-7L; Fri, 29 Nov 2019 17:07:38 +0000 Received: from vps0.lunn.ch ([185.16.172.187]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iajjy-0006SS-DD for linux-arm-kernel@lists.infradead.org; Fri, 29 Nov 2019 17:07:36 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=OmANGPrG+ng069xuXj6w2HTYAXpdCYeG+/WKBZBjW50=; b=spylNlP7M5+JdxXPyu41y2eaoz YgK3Gj93j2gWLDM/CYqont+37FSEq24HPS1vGioIgqi1pnNPZT8QgjXhOdq5N3W087kVNcbWiCDtS 6xCL6tKaa2ROJrj1o4EjQXye1y3Mn0XAFKHUwSdCbrsAhNsU8VUBF7KLwZvsZ0k9rD94=; Received: from andrew by vps0.lunn.ch with local (Exim 4.92.2) (envelope-from ) id 1iajjh-0007ki-Hv; Fri, 29 Nov 2019 18:07:17 +0100 Date: Fri, 29 Nov 2019 18:07:17 +0100 From: Andrew Lunn To: Baruch Siach Subject: Re: [PATCH] ARM: dts: mvebu: add support for SolidRun Clearfog GTR Message-ID: <20191129170717.GC28308@lunn.ch> References: <3a870e11b152e2f8ffb2b3256c5ac42741658c4c.1574960406.git.baruch@tkos.co.il> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <3a870e11b152e2f8ffb2b3256c5ac42741658c4c.1574960406.git.baruch@tkos.co.il> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191129_090734_446980_ECF1709B X-CRM114-Status: GOOD ( 12.53 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Gregory Clement , Jason Cooper , linux-arm-kernel@lists.infradead.org, Sebastian Hesselbarth Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Nov 28, 2019 at 07:00:06PM +0200, Baruch Siach wrote: > SolidRun Clearfog GTR L8 and S4 SBCs are based on Armada 385. They > features 8 (L8) or 4 (S4) switched Ethernet ports, 1 1Gb Ethernet port, > 1 directly connected SFP port, 1 SFP port behind the switch (not > currently described in DT), Hi Baruch Did you try to add the SFP on the switch? What problems did you have? The general support for it should be there. > + i2c@11100 { /* SFP */ > + pinctrl-0 = <&cf_gtr_i2c1_pins>; > + pinctrl-names = "default"; > + status = "okay"; > + }; Since there are two SFPs, it would be a good idea to indicate which one this is. > + sfp: sfp { > + compatible = "sff,sfp"; > + i2c-bus = <&i2c1>; > + los-gpio = <&gpio1 22 GPIO_ACTIVE_HIGH>; > + mod-def0-gpio = <&gpio0 25 GPIO_ACTIVE_LOW>; > + tx-disable-gpio = <&gpio1 14 GPIO_ACTIVE_HIGH>; > + }; when you get the second sfp working you are going to have naming issue. So maybe call this sfp0? > + led1 { > + label = "led1"; > + gpios = <&gpio1 10 GPIO_ACTIVE_HIGH>; > + }; > + > + led2 { > + label = "led2"; > + gpios = <&gpio1 20 GPIO_ACTIVE_HIGH>; > + }; There is a naming convention of LEDS labels. This does not fit it. > +&gpio0 { > + pinctrl-0 = <&cf_gtr_fan_pwm>; > + pinctrl-names = "default"; > + > + wifi-disable { > + gpio-hog; > + gpios = <30 GPIO_ACTIVE_LOW>, <31 GPIO_ACTIVE_LOW>; > + output-low; > + line-name = "wifi-disable"; > + }; > +}; Isn't there a generic rfkill GPIO driver? Never looked, but it seems like it should exist. > + sar-isolation { > + gpio-hog; > + gpios = <15 GPIO_ACTIVE_LOW>; > + output-low; > + line-name = "sar-isolation"; > + }; What is SAR? Andrew _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel