From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B5BC4C432C0 for ; Mon, 2 Dec 2019 08:20:08 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8A27820833 for ; Mon, 2 Dec 2019 08:20:08 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="F9XS7dPN"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="t4VYe/+O" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8A27820833 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=kTj0tU3sA6E8hjVVLJObYsAQj82cTvDPwJxV8tfL624=; b=F9XS7dPNa1nbYK hdiRnEUo/S/NMPa6L7nomN9bjmIeYL9EM/hsBk6Mi6oWcXoPohqwlJpNe3LiecXkey/GQn9uxni5Z Nq7xrCXslDOQisocoRKMND8LgwFbzqFEmbzZbQjedh9LY5LzQZrFZPcLK5L8XPSwuW/KDUOdPWwfa MKVi/O8toX3NOBNzDnOA4Wu7e/22PTJtiDEH1/DB+o97n5Z9N6oSVMo+RtMIiQl3y97ipTLmWop68 acBYbYrq3XPTOBF7E9cJv44fnLd2MYIcRqT9VtmDWZGu+pc5+6LSUW46H15JlA/47RO5QT7mTFH9s bpH8W4IxJ7ZQQWoGUmJw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1ibgw9-0004rR-DZ; Mon, 02 Dec 2019 08:20:05 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1ibgw7-0004qO-1D for linux-arm-kernel@lists.infradead.org; Mon, 02 Dec 2019 08:20:04 +0000 Received: from dragon (98.142.130.235.16clouds.com [98.142.130.235]) (using TLSv1.2 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id D6D7F20833; Mon, 2 Dec 2019 08:19:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1575274802; bh=ugPnad4csUtS5gu9gvNWiYsom6nlpl/ToMIjVCWJbZo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=t4VYe/+Oc3UZ1KYFtA1wTahHsh8T/DkBKOAjLV3QmxJ9AQZJD9FuVuoz0zBVP5cJd 6WDmgdCr0jLI3LnyltUWtEHaHuXSyO4G91iqUGfsOATVp3kxz/wVXVVS13AVMy9U59 VhUdzsyRQVt1jlLwjP9WO0TNt/hw0WpXKTJtvAd0= Date: Mon, 2 Dec 2019 16:19:49 +0800 From: Shawn Guo To: Peng Fan Subject: Re: [PATCH] clk: imx: clk-composite-8m: add lock to gate/mux Message-ID: <20191202081948.GD9767@dragon> References: <1572603166-24594-1-git-send-email-peng.fan@nxp.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1572603166-24594-1-git-send-email-peng.fan@nxp.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191202_002003_113628_45AEBEC3 X-CRM114-Status: GOOD ( 14.08 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Abel Vesa , Anson Huang , "sboyd@kernel.org" , "s.hauer@pengutronix.de" , "linux-kernel@vger.kernel.org" , dl-linux-imx , "kernel@pengutronix.de" , Leonard Crestez , "festevam@gmail.com" , "linux-clk@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , Jacky Bai Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Nov 01, 2019 at 10:16:19AM +0000, Peng Fan wrote: > From: Peng Fan > > There is a lock to diviver in the composite driver, but that's not s/diviver/divider > enought. lock to gate/mux are also needed to provide exclusive access s/enought/enough > to the register. > > Fixes: d3ff9728134e ("clk: imx: Add imx composite clock") > Signed-off-by: Peng Fan Other than above typos, Acked-by: Shawn Guo Stephen, I assume you will take it a fix. Otherwise, please let me know. Shawn > --- > drivers/clk/imx/clk-composite-8m.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/clk/imx/clk-composite-8m.c b/drivers/clk/imx/clk-composite-8m.c > index e0f25983e80f..20f7c91c03d2 100644 > --- a/drivers/clk/imx/clk-composite-8m.c > +++ b/drivers/clk/imx/clk-composite-8m.c > @@ -142,6 +142,7 @@ struct clk_hw *imx8m_clk_hw_composite_flags(const char *name, > mux->reg = reg; > mux->shift = PCG_PCS_SHIFT; > mux->mask = PCG_PCS_MASK; > + mux->lock = &imx_ccm_lock; > > div = kzalloc(sizeof(*div), GFP_KERNEL); > if (!div) > @@ -161,6 +162,7 @@ struct clk_hw *imx8m_clk_hw_composite_flags(const char *name, > gate_hw = &gate->hw; > gate->reg = reg; > gate->bit_idx = PCG_CGC_SHIFT; > + gate->lock = &imx_ccm_lock; > > hw = clk_hw_register_composite(NULL, name, parent_names, num_parents, > mux_hw, &clk_mux_ops, div_hw, > -- > 2.16.4 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel