* [PATCH 1/2] clk: imx: clk-divider-gate: typo fix
@ 2019-11-04 10:11 Peng Fan
2019-11-04 10:11 ` [PATCH 2/2] clk: imx: clk-divider-gate: drop redundant initialization Peng Fan
2019-12-02 9:00 ` [PATCH 1/2] clk: imx: clk-divider-gate: typo fix Shawn Guo
0 siblings, 2 replies; 5+ messages in thread
From: Peng Fan @ 2019-11-04 10:11 UTC (permalink / raw)
To: sboyd@kernel.org, shawnguo@kernel.org, s.hauer@pengutronix.de,
festevam@gmail.com, Abel Vesa
Cc: Aisheng Dong, Peng Fan, linux-kernel@vger.kernel.org,
dl-linux-imx, kernel@pengutronix.de, Leonard Crestez,
linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org
From: Peng Fan <peng.fan@nxp.com>
resue->reuse
Signed-off-by: Peng Fan <peng.fan@nxp.com>
---
drivers/clk/imx/clk-divider-gate.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/clk/imx/clk-divider-gate.c b/drivers/clk/imx/clk-divider-gate.c
index 2a8352a316c7..214e18eb2b22 100644
--- a/drivers/clk/imx/clk-divider-gate.c
+++ b/drivers/clk/imx/clk-divider-gate.c
@@ -167,7 +167,7 @@ static const struct clk_ops clk_divider_gate_ops = {
};
/*
- * NOTE: In order to resue the most code from the common divider,
+ * NOTE: In order to reuse the most code from the common divider,
* we also design our divider following the way that provids an extra
* clk_divider_flags, however it's fixed to CLK_DIVIDER_ONE_BASED by
* default as our HW is. Besides that it supports only CLK_DIVIDER_READ_ONLY
--
2.16.4
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 5+ messages in thread* [PATCH 2/2] clk: imx: clk-divider-gate: drop redundant initialization
2019-11-04 10:11 [PATCH 1/2] clk: imx: clk-divider-gate: typo fix Peng Fan
@ 2019-11-04 10:11 ` Peng Fan
2019-11-05 11:37 ` Abel Vesa
2019-12-02 9:02 ` Shawn Guo
2019-12-02 9:00 ` [PATCH 1/2] clk: imx: clk-divider-gate: typo fix Shawn Guo
1 sibling, 2 replies; 5+ messages in thread
From: Peng Fan @ 2019-11-04 10:11 UTC (permalink / raw)
To: sboyd@kernel.org, shawnguo@kernel.org, s.hauer@pengutronix.de,
festevam@gmail.com, Abel Vesa
Cc: Aisheng Dong, Peng Fan, linux-kernel@vger.kernel.org,
dl-linux-imx, kernel@pengutronix.de, Leonard Crestez,
linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org
From: Peng Fan <peng.fan@nxp.com>
There is no need to initialize flags as 0.
Signed-off-by: Peng Fan <peng.fan@nxp.com>
---
drivers/clk/imx/clk-divider-gate.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/clk/imx/clk-divider-gate.c b/drivers/clk/imx/clk-divider-gate.c
index 214e18eb2b22..4145594af53b 100644
--- a/drivers/clk/imx/clk-divider-gate.c
+++ b/drivers/clk/imx/clk-divider-gate.c
@@ -43,7 +43,7 @@ static unsigned long clk_divider_gate_recalc_rate(struct clk_hw *hw,
{
struct clk_divider_gate *div_gate = to_clk_divider_gate(hw);
struct clk_divider *div = to_clk_divider(hw);
- unsigned long flags = 0;
+ unsigned long flags;
unsigned int val;
spin_lock_irqsave(div->lock, flags);
@@ -75,7 +75,7 @@ static int clk_divider_gate_set_rate(struct clk_hw *hw, unsigned long rate,
{
struct clk_divider_gate *div_gate = to_clk_divider_gate(hw);
struct clk_divider *div = to_clk_divider(hw);
- unsigned long flags = 0;
+ unsigned long flags;
int value;
u32 val;
@@ -104,7 +104,7 @@ static int clk_divider_enable(struct clk_hw *hw)
{
struct clk_divider_gate *div_gate = to_clk_divider_gate(hw);
struct clk_divider *div = to_clk_divider(hw);
- unsigned long flags = 0;
+ unsigned long flags;
u32 val;
if (!div_gate->cached_val) {
@@ -127,7 +127,7 @@ static void clk_divider_disable(struct clk_hw *hw)
{
struct clk_divider_gate *div_gate = to_clk_divider_gate(hw);
struct clk_divider *div = to_clk_divider(hw);
- unsigned long flags = 0;
+ unsigned long flags;
u32 val;
spin_lock_irqsave(div->lock, flags);
--
2.16.4
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH 2/2] clk: imx: clk-divider-gate: drop redundant initialization
2019-11-04 10:11 ` [PATCH 2/2] clk: imx: clk-divider-gate: drop redundant initialization Peng Fan
@ 2019-11-05 11:37 ` Abel Vesa
2019-12-02 9:02 ` Shawn Guo
1 sibling, 0 replies; 5+ messages in thread
From: Abel Vesa @ 2019-11-05 11:37 UTC (permalink / raw)
To: Peng Fan
Cc: Aisheng Dong, sboyd@kernel.org, shawnguo@kernel.org,
s.hauer@pengutronix.de, linux-kernel@vger.kernel.org,
dl-linux-imx, kernel@pengutronix.de, Leonard Crestez,
festevam@gmail.com, linux-clk@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
On 19-11-04 10:11:37, Peng Fan wrote:
> From: Peng Fan <peng.fan@nxp.com>
>
> There is no need to initialize flags as 0.
>
> Signed-off-by: Peng Fan <peng.fan@nxp.com>
Reviewed-by: Abel Vesa <abel.vesa@nxp.com>
> ---
> drivers/clk/imx/clk-divider-gate.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/clk/imx/clk-divider-gate.c b/drivers/clk/imx/clk-divider-gate.c
> index 214e18eb2b22..4145594af53b 100644
> --- a/drivers/clk/imx/clk-divider-gate.c
> +++ b/drivers/clk/imx/clk-divider-gate.c
> @@ -43,7 +43,7 @@ static unsigned long clk_divider_gate_recalc_rate(struct clk_hw *hw,
> {
> struct clk_divider_gate *div_gate = to_clk_divider_gate(hw);
> struct clk_divider *div = to_clk_divider(hw);
> - unsigned long flags = 0;
> + unsigned long flags;
> unsigned int val;
>
> spin_lock_irqsave(div->lock, flags);
> @@ -75,7 +75,7 @@ static int clk_divider_gate_set_rate(struct clk_hw *hw, unsigned long rate,
> {
> struct clk_divider_gate *div_gate = to_clk_divider_gate(hw);
> struct clk_divider *div = to_clk_divider(hw);
> - unsigned long flags = 0;
> + unsigned long flags;
> int value;
> u32 val;
>
> @@ -104,7 +104,7 @@ static int clk_divider_enable(struct clk_hw *hw)
> {
> struct clk_divider_gate *div_gate = to_clk_divider_gate(hw);
> struct clk_divider *div = to_clk_divider(hw);
> - unsigned long flags = 0;
> + unsigned long flags;
> u32 val;
>
> if (!div_gate->cached_val) {
> @@ -127,7 +127,7 @@ static void clk_divider_disable(struct clk_hw *hw)
> {
> struct clk_divider_gate *div_gate = to_clk_divider_gate(hw);
> struct clk_divider *div = to_clk_divider(hw);
> - unsigned long flags = 0;
> + unsigned long flags;
> u32 val;
>
> spin_lock_irqsave(div->lock, flags);
> --
> 2.16.4
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH 2/2] clk: imx: clk-divider-gate: drop redundant initialization
2019-11-04 10:11 ` [PATCH 2/2] clk: imx: clk-divider-gate: drop redundant initialization Peng Fan
2019-11-05 11:37 ` Abel Vesa
@ 2019-12-02 9:02 ` Shawn Guo
1 sibling, 0 replies; 5+ messages in thread
From: Shawn Guo @ 2019-12-02 9:02 UTC (permalink / raw)
To: Peng Fan
Cc: Aisheng Dong, Abel Vesa, sboyd@kernel.org, s.hauer@pengutronix.de,
linux-kernel@vger.kernel.org, dl-linux-imx, kernel@pengutronix.de,
Leonard Crestez, festevam@gmail.com, linux-clk@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
On Mon, Nov 04, 2019 at 10:11:37AM +0000, Peng Fan wrote:
> From: Peng Fan <peng.fan@nxp.com>
>
> There is no need to initialize flags as 0.
>
> Signed-off-by: Peng Fan <peng.fan@nxp.com>
Applied, thanks.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 1/2] clk: imx: clk-divider-gate: typo fix
2019-11-04 10:11 [PATCH 1/2] clk: imx: clk-divider-gate: typo fix Peng Fan
2019-11-04 10:11 ` [PATCH 2/2] clk: imx: clk-divider-gate: drop redundant initialization Peng Fan
@ 2019-12-02 9:00 ` Shawn Guo
1 sibling, 0 replies; 5+ messages in thread
From: Shawn Guo @ 2019-12-02 9:00 UTC (permalink / raw)
To: Peng Fan
Cc: Aisheng Dong, Abel Vesa, sboyd@kernel.org, s.hauer@pengutronix.de,
linux-kernel@vger.kernel.org, dl-linux-imx, kernel@pengutronix.de,
Leonard Crestez, festevam@gmail.com, linux-clk@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
On Mon, Nov 04, 2019 at 10:11:33AM +0000, Peng Fan wrote:
> From: Peng Fan <peng.fan@nxp.com>
>
> resue->reuse
>
> Signed-off-by: Peng Fan <peng.fan@nxp.com>
Applied it after updating the subject and commit log as below.
clk: imx: clk-divider-gate: fix a typo in comment
Fix a typo in comment: resue -> reuse.
Shawn
> ---
> drivers/clk/imx/clk-divider-gate.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/clk/imx/clk-divider-gate.c b/drivers/clk/imx/clk-divider-gate.c
> index 2a8352a316c7..214e18eb2b22 100644
> --- a/drivers/clk/imx/clk-divider-gate.c
> +++ b/drivers/clk/imx/clk-divider-gate.c
> @@ -167,7 +167,7 @@ static const struct clk_ops clk_divider_gate_ops = {
> };
>
> /*
> - * NOTE: In order to resue the most code from the common divider,
> + * NOTE: In order to reuse the most code from the common divider,
> * we also design our divider following the way that provids an extra
> * clk_divider_flags, however it's fixed to CLK_DIVIDER_ONE_BASED by
> * default as our HW is. Besides that it supports only CLK_DIVIDER_READ_ONLY
> --
> 2.16.4
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2019-12-02 9:02 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-11-04 10:11 [PATCH 1/2] clk: imx: clk-divider-gate: typo fix Peng Fan
2019-11-04 10:11 ` [PATCH 2/2] clk: imx: clk-divider-gate: drop redundant initialization Peng Fan
2019-11-05 11:37 ` Abel Vesa
2019-12-02 9:02 ` Shawn Guo
2019-12-02 9:00 ` [PATCH 1/2] clk: imx: clk-divider-gate: typo fix Shawn Guo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).