From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7C4A4C432C0 for ; Mon, 2 Dec 2019 15:15:24 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 43E1620717 for ; Mon, 2 Dec 2019 15:15:24 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="ZeiyPC4a"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="U1xYwtDb" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 43E1620717 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ideasonboard.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=HqLkKnIzzv9mUs4iOS/Y6I6TcWzdneSAOvGB0MCDp0s=; b=ZeiyPC4ag+067g BsJ6ZcXYMdwG6+tM3zUkv0/I/4FeK0D2MsNft/lgGlQNCtmCyQ2nrnEDtP12VN/8gkfpInbamtpzD EjJR1wag4dv/+mUoTJgPWXwgXknShcD9+WR3Yb1XubHtcWTSgqst0/6SpqwJqT6BcKW0CbU4qQkDh YEdCZs0xxwxfx/9ZzfrA7GyaA/VubIGlHlZwJ5bRGLGISOVReAvYkPQQKg/Zy3bQ6cJtzzrWjfJWU 7cr5aJQf5qyF4i0wAhh0q5BodfJMkAWG2HESvjQg7JXmIC8IwZEuUrGiQd+WR0rbaRxVUmuY4+I82 SHxM1kuUAwcchHT6vxcg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1ibnQ3-0002h9-K6; Mon, 02 Dec 2019 15:15:23 +0000 Received: from perceval.ideasonboard.com ([213.167.242.64]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1ibnPz-0002gg-LM for linux-arm-kernel@lists.infradead.org; Mon, 02 Dec 2019 15:15:22 +0000 Received: from pendragon.ideasonboard.com (81-175-216-236.bb.dnainternet.fi [81.175.216.236]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 2E11D309; Mon, 2 Dec 2019 16:15:09 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1575299709; bh=mFGJOpuePLZrsr7Ed2VYhGQqc4JmFTNL3aKD7BB6RME=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=U1xYwtDbAaxhE1hTGuuq+kUzf8of1Su/SFJ/5CD+ND1NhkYzdxvGPjMQnU9DDAlsK xdKO2BSloawGiChK9+z+QPTq8dFBSFS9xOMecLTyobVUVAW0hmzdJDacL6+LgL0s9n PmQDet0FgRvYJiviJwNNw81lV6KlvpHYKc6AuNZc= Date: Mon, 2 Dec 2019 17:15:02 +0200 From: Laurent Pinchart To: Sean Paul Subject: Re: [PATCH v1 14/16] drm/panel: call prepare/enable only once Message-ID: <20191202151502.GA18532@pendragon.ideasonboard.com> References: <20190804201637.1240-1-sam@ravnborg.org> <20190804201637.1240-15-sam@ravnborg.org> <20190805170120.GZ104440@art_vandelay> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20190805170120.GZ104440@art_vandelay> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191202_071520_137672_3994853E X-CRM114-Status: GOOD ( 30.33 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Neil Armstrong , David Airlie , Linus Walleij , dri-devel@lists.freedesktop.org, Andrzej Hajda , Thierry Reding , Benjamin Gaignard , Fabio Estevam , Marek Vasut , Laurent Pinchart , Joonyoung Shim , Sam Ravnborg , Krzysztof Kozlowski , Jonathan Hunter , Maxime Ripard , Kukjin Kim , linux-arm-kernel@lists.infradead.org, Philipp Zabel , NXP Linux Team , Pengutronix Kernel Team , Jonas Karlman , Sascha Hauer , Alison Wang , Maarten Lankhorst , Gwan-gyeong Mun , Inki Dae , Alexios Zavras , linux-samsung-soc@vger.kernel.org, Stefan Agner , linux-tegra@vger.kernel.org, Thomas Gleixner , Vincent Abriou , Allison Randal , Jernej Skrabec , Shawn Guo , Seung-Woo Kim , Kyungmin Park , Daniel Vetter , Enrico Weigelt Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Sean, On Mon, Aug 05, 2019 at 01:01:20PM -0400, Sean Paul wrote: > On Sun, Aug 04, 2019 at 10:16:35PM +0200, Sam Ravnborg wrote: > > Many panel drivers duplicate logic to prevent prepare to be called > > for a panel that is already prepared. > > Likewise for enable. > > > > Implement this logic in drm_panel so the individual drivers > > no longer needs this. > > A panel is considered prepared/enabled only if the prepare/enable call > > succeeds. > > For disable/unprepare it is unconditionally considered > > disabled/unprepared. > > Hi Sam, > I did a similar thing a few years ago [1]. IIRC it was well received and just > needed some nits cleaned up. Unfortunately I lost interest^W^W switched to other > things and dropped it. So thanks for picking this back up! > > Fast forward to today, I still think it's a good idea but I want to make sure > this won't negatively interact with the self refresh helpers. With the helpers > in place, it's possible to call disable consecutively (ie: once to enter self > refresh and again to actually shut down). I did a quick pass and it looks like > this patch might break that behavior, so you might want to take that into > account. Is this semantics documented somewhere ? The documentation of the panel disable operation is pretty terse, and we need to explicitly state who of the caller and callee needs to track the state. > [1]- https://patchwork.freedesktop.org/series/30712/ > > > This allows calls to prepare/enable again, even if there were > > some issue disabling a regulator or similar during disable/unprepare. > > > > Signed-off-by: Sam Ravnborg > > Cc: Maarten Lankhorst > > Cc: Maxime Ripard > > Cc: Sean Paul > > Cc: Thierry Reding > > Cc: Sam Ravnborg > > Cc: David Airlie > > Cc: Daniel Vetter > > --- > > drivers/gpu/drm/drm_panel.c | 66 ++++++++++++++++++++++++++++++------- > > include/drm/drm_panel.h | 21 ++++++++++++ > > 2 files changed, 75 insertions(+), 12 deletions(-) > > > > diff --git a/drivers/gpu/drm/drm_panel.c b/drivers/gpu/drm/drm_panel.c > > index da19d5b4a2f4..0853764040de 100644 > > --- a/drivers/gpu/drm/drm_panel.c > > +++ b/drivers/gpu/drm/drm_panel.c > > @@ -66,10 +66,21 @@ EXPORT_SYMBOL(drm_panel_init); > > */ > > int drm_panel_prepare(struct drm_panel *panel) > > { > > - if (panel && panel->funcs && panel->funcs->prepare) > > - return panel->funcs->prepare(panel); > > + int ret = -ENOSYS; > > > > - return panel ? -ENOSYS : -EINVAL; > > + if (!panel) > > + return -EINVAL; > > + > > + if (panel->prepared) > > + return 0; > > + > > + if (panel->funcs && panel->funcs->prepare) > > + ret = panel->funcs->prepare(panel); > > + > > + if (ret >= 0) > > + panel->prepared = true; > > + > > + return ret; > > } > > EXPORT_SYMBOL(drm_panel_prepare); > > > > @@ -85,10 +96,21 @@ EXPORT_SYMBOL(drm_panel_prepare); > > */ > > int drm_panel_enable(struct drm_panel *panel) > > { > > - if (panel && panel->funcs && panel->funcs->enable) > > - return panel->funcs->enable(panel); > > + int ret = -ENOSYS; > > > > - return panel ? -ENOSYS : -EINVAL; > > + if (!panel) > > + return -EINVAL; > > + > > + if (panel->enabled) > > + return 0; > > + > > + if (panel->funcs && panel->funcs->enable) > > + ret = panel->funcs->enable(panel); > > + > > + if (ret >= 0) > > + panel->enabled = true; > > + > > + return ret; > > } > > EXPORT_SYMBOL(drm_panel_enable); > > > > @@ -104,10 +126,20 @@ EXPORT_SYMBOL(drm_panel_enable); > > */ > > int drm_panel_disable(struct drm_panel *panel) > > { > > - if (panel && panel->funcs && panel->funcs->disable) > > - return panel->funcs->disable(panel); > > + int ret = -ENOSYS; > > > > - return panel ? -ENOSYS : -EINVAL; > > + if (!panel) > > + return -EINVAL; > > + > > + if (!panel->enabled) > > + return 0; > > + > > + if (panel->funcs && panel->funcs->disable) > > + ret = panel->funcs->disable(panel); > > + > > + panel->enabled = false; > > + > > + return ret; > > } > > EXPORT_SYMBOL(drm_panel_disable); > > > > @@ -124,10 +156,20 @@ EXPORT_SYMBOL(drm_panel_disable); > > */ > > int drm_panel_unprepare(struct drm_panel *panel) > > { > > - if (panel && panel->funcs && panel->funcs->unprepare) > > - return panel->funcs->unprepare(panel); > > + int ret = -ENOSYS; > > > > - return panel ? -ENOSYS : -EINVAL; > > + if (!panel) > > + return -EINVAL; > > + > > + if (!panel->prepared) > > + return 0; > > + > > + if (panel->funcs && panel->funcs->unprepare) > > + ret = panel->funcs->unprepare(panel); > > + > > + panel->prepared = false; > > + > > + return ret; > > } > > EXPORT_SYMBOL(drm_panel_unprepare); > > > > diff --git a/include/drm/drm_panel.h b/include/drm/drm_panel.h > > index 624bd15ecfab..7493500fc9bd 100644 > > --- a/include/drm/drm_panel.h > > +++ b/include/drm/drm_panel.h > > @@ -65,6 +65,9 @@ struct drm_panel_funcs { > > * @prepare: > > * > > * Turn on panel and perform set up. > > + * When the panel is successfully prepared the prepare() function > > + * will not be called again until the panel has been unprepared. > > + * > > */ > > int (*prepare)(struct drm_panel *panel); > > > > @@ -72,6 +75,8 @@ struct drm_panel_funcs { > > * @enable: > > * > > * Enable panel (turn on back light, etc.). > > + * When the panel is successfully enabled the enable() function > > + * will not be called again until the panel has been disabled. > > */ > > int (*enable)(struct drm_panel *panel); > > > > @@ -79,6 +84,7 @@ struct drm_panel_funcs { > > * @disable: > > * > > * Disable panel (turn off back light, etc.). > > + * If the panel is already disabled the disable() function is not called. > > */ > > int (*disable)(struct drm_panel *panel); > > > > @@ -86,6 +92,7 @@ struct drm_panel_funcs { > > * @unprepare: > > * > > * Turn off panel. > > + * If the panel is already unprepared the unprepare() function is not called. > > */ > > int (*unprepare)(struct drm_panel *panel); > > > > @@ -145,6 +152,20 @@ struct drm_panel { > > * Panel entry in registry. > > */ > > struct list_head list; > > + > > + /** > > + * @prepared: > > + * > > + * Set to true when the panel is successfully prepared. > > + */ > > + bool prepared; > > + > > + /** > > + * @enabled: > > + * > > + * Set to true when the panel is successfully enabled. > > + */ > > + bool enabled; > > }; > > > > void drm_panel_init(struct drm_panel *panel); -- Regards, Laurent Pinchart _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel