From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2DF20C2D0B1 for ; Wed, 4 Dec 2019 07:40:53 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 32E592081B for ; Wed, 4 Dec 2019 07:31:03 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="UAWQwcFY" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 32E592081B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=huawei.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=WvLAsT3nAMEF12XyU1MSZ0suvzOKmr+qMMDlpGkC2/4=; b=UAWQwcFYyzsyVq Ax1y3PYB155wjQYlB4Z5uBoU368+or+TUd1JB8rYq9yIxQuKZQR4Q3/+tOKhQHSOuFIJJpZ0L0tEv IjkF0SltBNX6Uzq4gZszO+6gVV1DsqEEzTSDl3ldLi9Bunsr9DGMseHxEBIyNUU4kh2BrZ6JbxFCY AiE4TJOwZq1yfZ2/GiNLmjTJy2QZ2lYgHetoW50Otp63RY5SFqbye9iyG6wrnFQeOM8dDah7Bd5gI 9kh00097Azta8s05JfiW06SjDCat3wYnJFuEf7OS/uJFQUwvZJ4o8JP5433LggWZ4Rl5ec2fMQIXR 7AGrv9EBuB0RL06V2rpQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1icP7m-0002JT-D4; Wed, 04 Dec 2019 07:31:02 +0000 Received: from szxga05-in.huawei.com ([45.249.212.191] helo=huawei.com) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1icP7j-0002If-FR; Wed, 04 Dec 2019 07:31:01 +0000 Received: from DGGEMS402-HUB.china.huawei.com (unknown [172.30.72.60]) by Forcepoint Email with ESMTP id D9EB019BD49D9D2B1B99; Wed, 4 Dec 2019 15:30:54 +0800 (CST) Received: from localhost.localdomain.localdomain (10.175.113.25) by DGGEMS402-HUB.china.huawei.com (10.3.19.202) with Microsoft SMTP Server id 14.3.439.0; Wed, 4 Dec 2019 15:30:44 +0800 From: Mao Wenan To: , , , , , Subject: [PATCH v2 -next] rtc: mt6397: drop free_irq of devm_xx allocated irq Date: Wed, 4 Dec 2019 15:28:26 +0800 Message-ID: <20191204072826.117432-1-maowenan@huawei.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20191204063444.GF1765@kadam> References: <20191204063444.GF1765@kadam> MIME-Version: 1.0 X-Originating-IP: [10.175.113.25] X-CFilter-Loop: Reflected X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191203_233059_702641_BFF7811E X-CRM114-Status: UNSURE ( 7.60 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-rtc@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org, Mao Wenan , Hulk Robot , linux-mediatek@lists.infradead.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org rtc->irq is requested by devm_request_threaded_irq, and request_threaded_irq. IRQs requested with this function will be automatically freed on driver detach. This patch remove unused error label as well. Reported-by: Hulk Robot Signed-off-by: Mao Wenan --- v2: remove error label as Dan Carpenter suggest. drivers/rtc/rtc-mt6397.c | 7 ------- 1 file changed, 7 deletions(-) diff --git a/drivers/rtc/rtc-mt6397.c b/drivers/rtc/rtc-mt6397.c index 5249fc99fd5f..14f3c4915260 100644 --- a/drivers/rtc/rtc-mt6397.c +++ b/drivers/rtc/rtc-mt6397.c @@ -287,13 +287,6 @@ static int mtk_rtc_probe(struct platform_device *pdev) rtc->rtc_dev->ops = &mtk_rtc_ops; ret = rtc_register_device(rtc->rtc_dev); - if (ret) - goto out_free_irq; - - return 0; - -out_free_irq: - free_irq(rtc->irq, rtc); return ret; } -- 2.20.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel