From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 257A9C43603 for ; Mon, 9 Dec 2019 09:09:01 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E29112072D for ; Mon, 9 Dec 2019 09:09:00 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="sEU3k4VR"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="fJr+YRMo" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E29112072D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=gVey44RuDlTgIrkEii0Nhj+OFEO7m87zP/cJ52jWCw8=; b=sEU3k4VRzcsYaf qcKjis9lEuf+lNADDxzaRTfr8ulfl8RedR9LnqVe+O67AjTKzzOwcSmbO+E5CM1tLu873i99+LWry /GiF8RxmgYp0zkX98YNXvWJYnzXeIrLwzlKY58K4AomOT7Iy0VAsIohUealk+vWS9B59gMS74xz2d 3m8zBjy4Np6anzfhloLncEAQtEHLzRdgnqi1axxNB4v7tuTSxvJ4l9yRW2hyUwEFtsxDBYxJwAaL2 9EMJ4TALn/lrCQnRc3/6pjGvKZ2u649NpZ00bxKnrz1U6YvpZwCnTsDPdHj+iIXjs3ukVU4ryeySR dBvHeh9n8xfwMJr3XeSw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1ieF2K-0004LL-9P; Mon, 09 Dec 2019 09:09:00 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1ieF2G-0004Kn-Nx for linux-arm-kernel@lists.infradead.org; Mon, 09 Dec 2019 09:08:58 +0000 Received: from dragon (98.142.130.235.16clouds.com [98.142.130.235]) (using TLSv1.2 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 6EEB82072D; Mon, 9 Dec 2019 09:08:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1575882536; bh=QAsy6KYtyWoOffL4NFS3+5/Zh44sQt9mMpY2XhbERdM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=fJr+YRMo1Rnw0+vTxF6gPpMdzFTFrIfbdML67vLN6jbyh5McznFgrIX0BjK9CA7iK dYFz9iFC0H8+/ml50izL4yc8S1EpANPnuREKYX0eAc4PdGphLzymmVskHnzECr1+Mu /+hwKeGGPVnWAKfkdb21nDvtwNEbJop3/VDxkcus= Date: Mon, 9 Dec 2019 17:08:42 +0800 From: Shawn Guo To: Michael Walle , Alison Wang Subject: Re: [PATCH] arm64: dts: ls1028a: put SAIs into async mode Message-ID: <20191209090840.GL3365@dragon> References: <20191129210937.26808-1-michael@walle.cc> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20191129210937.26808-1-michael@walle.cc> User-Agent: Mutt/1.5.21 (2010-09-15) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191209_010856_799478_3BD6C6DA X-CRM114-Status: GOOD ( 16.06 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Li Yang , Rob Herring , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org + Alison Wang On Fri, Nov 29, 2019 at 10:09:37PM +0100, Michael Walle wrote: > The LS1028A SoC has only unidirectional SAIs. Therefore, it doesn't make > sense to have the RX and TX part synchronous. Even worse, the RX part > wont work out of the box because by default it is configured as > synchronous to the TX part. And as said before, the pinmux of the SoC > can only be configured to route either the RX or the TX signals to the > SAI but never both at the same time. Thus configure the asynchronous > mode by default. > > Signed-off-by: Michael Walle Alison, Leo, Looks good to you? Shawn > --- > arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi > index 379913756e90..9be33426e5ce 100644 > --- a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi > +++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi > @@ -637,6 +637,7 @@ > dma-names = "tx", "rx"; > dmas = <&edma0 1 4>, > <&edma0 1 3>; > + fsl,sai-asynchronous; > status = "disabled"; > }; > > @@ -651,6 +652,7 @@ > dma-names = "tx", "rx"; > dmas = <&edma0 1 6>, > <&edma0 1 5>; > + fsl,sai-asynchronous; > status = "disabled"; > }; > > @@ -665,6 +667,7 @@ > dma-names = "tx", "rx"; > dmas = <&edma0 1 8>, > <&edma0 1 7>; > + fsl,sai-asynchronous; > status = "disabled"; > }; > > @@ -679,6 +682,7 @@ > dma-names = "tx", "rx"; > dmas = <&edma0 1 10>, > <&edma0 1 9>; > + fsl,sai-asynchronous; > status = "disabled"; > }; > > @@ -693,6 +697,7 @@ > dma-names = "tx", "rx"; > dmas = <&edma0 1 12>, > <&edma0 1 11>; > + fsl,sai-asynchronous; > status = "disabled"; > }; > > @@ -707,6 +712,7 @@ > dma-names = "tx", "rx"; > dmas = <&edma0 1 14>, > <&edma0 1 13>; > + fsl,sai-asynchronous; > status = "disabled"; > }; > > -- > 2.20.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel