From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DE21EC43603 for ; Mon, 9 Dec 2019 16:26:56 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B4C0420692 for ; Mon, 9 Dec 2019 16:26:56 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="bqYSlSWI"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="zOU+VVGK" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B4C0420692 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=enNOZpBT0O3Ze8GihtJLIRjrMmg6KIvRYTJCogU82U4=; b=bqYSlSWIf641V+ Ww/RGwSVmIFy7i4n7VN479RkATF+F8EKKpDs2ZDAkkgbTcfiq3C3ueI2nrq9lm8kE5Gt9fe8Dg2co D6uqkYNACuBSmZcAzhQ4OVWvW4GuDAFkX0p8FW+R8+/Thau6Yhvy2ny5NYBPqzU3D3WhkWdkdScVw vToTZjzURFLqer3X165h/kPM5JsR0as2vgrvPuPAJNEHXaZ4BqQAtbFjAktWdqJSZCdtTuC/1Y+C/ a3RhqA3TUjXBX+ytT+M34ZM4fetQxwMSKPt7xBzQqlPqVKm7poARj79xQLoxX4mK3c7Zy4YSI4Rj7 2wUDUMfKmQuvAAoBSg7Q==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1ieLs8-0004rV-Ce; Mon, 09 Dec 2019 16:26:56 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1ieLs4-0004qd-I9 for linux-arm-kernel@lists.infradead.org; Mon, 09 Dec 2019 16:26:54 +0000 Received: from willie-the-truck (236.31.169.217.in-addr.arpa [217.169.31.236]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 839772080D; Mon, 9 Dec 2019 16:26:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1575908811; bh=XmMuS1tdYvjAP/dOf3MN6vwqugHg0P62ECl8srBnh14=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=zOU+VVGKwRrsQ0D+daeQ+x/xsP+ATGq5Wl9RqLMP25OEiY225038UWy37UJhw427c daPKborkT9vmKrlKEnjdHU05mgGRcG8eVRcpb/wMvX8g9vmrQcTXv0EFF7BeKw12Kf l0lhHe8IOzGxUjarOFoGOoeadP8wDld7a054/8Sc= Date: Mon, 9 Dec 2019 16:26:46 +0000 From: Will Deacon To: Andre Przywara Subject: Re: [PATCH] pcie: Add quirk for the Arm Neoverse N1SDP platform Message-ID: <20191209162645.GA7489@willie-the-truck> References: <20191209160638.141431-1-andre.przywara@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20191209160638.141431-1-andre.przywara@arm.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191209_082652_622852_07505F32 X-CRM114-Status: GOOD ( 15.97 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Lorenzo Pieralisi , Catalin Marinas , "Rafael J . Wysocki" , linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org, linux-pci@vger.kernel.org, Bjorn Helgaas , Andrew Murray , linux-arm-kernel@lists.infradead.org, Len Brown Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Dec 09, 2019 at 04:06:38PM +0000, Andre Przywara wrote: > From: Deepak Pandey > > The Arm N1SDP SoC suffers from some PCIe integration issues, most > prominently config space accesses to not existing BDFs being answered > with a bus abort, resulting in an SError. "Do as I say, not as I do"? > To mitigate this, the firmware scans the bus before boot (catching the > SErrors) and creates a table with valid BDFs, which acts as a filter for > Linux' config space accesses. > > Add code consulting the table as an ACPI PCIe quirk, also register the > corresponding device tree based description of the host controller. > Also fix the other two minor issues on the way, namely not being fully > ECAM compliant and config space accesses being restricted to 32-bit > accesses only. > > This allows the Arm Neoverse N1SDP board to boot Linux without crashing > and to access *any* devices (there are no platform devices except UART). > > Signed-off-by: Deepak Pandey > [Sudipto: extend to cover the CCIX root port as well] > Signed-off-by: Sudipto Paul > [Andre: fix coding style issues, rewrite some parts, add DT support] > Signed-off-by: Andre Przywara > --- > arch/arm64/configs/defconfig | 1 + > drivers/acpi/pci_mcfg.c | 7 + > drivers/pci/controller/Kconfig | 11 ++ > drivers/pci/controller/Makefile | 1 + > drivers/pci/controller/pcie-n1sdp.c | 196 ++++++++++++++++++++++++++++ > include/linux/pci-ecam.h | 2 + > 6 files changed, 218 insertions(+) > create mode 100644 drivers/pci/controller/pcie-n1sdp.c Where can I buy one of these? They're "unreleased" according to: https://community.arm.com/developer/tools-software/oss-platforms/w/docs/440/neoverse-n1-sdp and I don't think we should wreck upstream because of a platform that doesn't exist. Will _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel