From: Jiri Olsa <jolsa@redhat.com>
To: John Garry <john.garry@huawei.com>
Cc: mark.rutland@arm.com, peterz@infradead.org,
Linuxarm <linuxarm@huawei.com>,
Arnaldo Carvalho de Melo <arnaldo.melo@gmail.com>,
linux-kernel@vger.kernel.org,
"linux-perf-users@vger.kernel.org"
<linux-perf-users@vger.kernel.org>,
alexander.shishkin@linux.intel.com, mingo@redhat.com,
namhyung@kernel.org, will@kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: perf top for arm64?
Date: Tue, 10 Dec 2019 18:08:41 +0100 [thread overview]
Message-ID: <20191210170841.GA23357@krava> (raw)
In-Reply-To: <952dc484-2739-ee65-f41c-f0198850ab10@huawei.com>
On Tue, Dec 10, 2019 at 04:52:52PM +0000, John Garry wrote:
> On 10/12/2019 16:36, Jiri Olsa wrote:
> > On Tue, Dec 10, 2019 at 04:13:49PM +0000, John Garry wrote:
> > > Hi all,
> > >
> > > I find to my surprise that "perf top" does not work for arm64:
> > >
> > > root@ubuntu:/home/john/linux# tools/perf/perf top
> > > Couldn't read the cpuid for this machine: No such file or directory
> >
>
> Hi Jirka,
>
> > there was recent change that check on cpuid and quits:
> > 608127f73779 perf top: Initialize perf_env->cpuid, needed by the per arch annotation init routine
> >
>
> ok, this is new code. I obviously didn't check the git history...
>
> But, apart from this, there are many other places where get_cpuid() is
> called. I wonder what else we're missing out on, and whether we should still
> add it.
right, I was just wondering how come vendor events are working for you,
but realized we have get_cpuid_str being called in there ;-)
I think we should add it as you have it prepared already,
could you post it with bigger changelog that would explain
where it's being used for arm?
jirka
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-12-10 17:09 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-06 13:00 [RFC PATCH] perf tools: Fix cross compile for ARM64 John Garry
2019-11-06 14:00 ` Arnaldo Carvalho de Melo
[not found] ` <418023e7-a50d-cb6f-989f-2e6d114ce5d8@huawei.com>
2019-12-10 16:36 ` perf top for arm64? Jiri Olsa
2019-12-10 16:52 ` John Garry
2019-12-10 17:08 ` Jiri Olsa [this message]
2019-12-10 17:17 ` John Garry
2019-12-10 19:51 ` Arnaldo Carvalho de Melo
2019-12-11 13:33 ` [PATCHES] Fix 'perf top' breakage on architectures not providing get_cpuid() " Arnaldo Carvalho de Melo
2019-12-11 14:46 ` Mark Rutland
2019-12-11 15:28 ` Arnaldo Carvalho de Melo
2019-12-11 14:50 ` John Garry
2019-12-11 14:54 ` Jiri Olsa
2019-12-11 1:48 ` Joakim Zhang
2019-12-11 2:36 ` Zenghui Yu
2019-12-10 19:48 ` Arnaldo Carvalho de Melo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191210170841.GA23357@krava \
--to=jolsa@redhat.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=arnaldo.melo@gmail.com \
--cc=john.garry@huawei.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=linuxarm@huawei.com \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox