From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9084CC43603 for ; Tue, 10 Dec 2019 17:09:10 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 525742073B for ; Tue, 10 Dec 2019 17:09:10 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="uhDeFhQ0"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="IKGDEm/Z" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 525742073B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=PbvhMofhPm3MPMNFDi10EdPx3j3MRJUaJAyrVUd+6DQ=; b=uhDeFhQ0YtaLqx L/x27bwUX0M9Rnl8Cy3310nFes3nNsI5ntgAX+U6j36Bui8Px7YHOYGluLk8SJ6/sLlIj8ft3sYcB v8m2WMqxnvx5OZcepD5Fn7hSugS5o848Iw4tqyM1WiiznXVJbDxO2zwS+Q0IktxgLVR5whsWVAEPO cVm3JkSZrAl0MxFeMyQnpoBlcGgQTdJRnhp6aWIcJP5LyAZWC47imJNoukTtE1FM6pj6aovXYVcZT Fuw6KIg0r1QfGEdQkgusVlbu0jbWzWYEsuGBK/B+TnALyFQdZ0Z1tGZLx45nclNysuB5saKNPFOim +kcePUBhCLuWiwdYko8A==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iej0P-0007cG-Rq; Tue, 10 Dec 2019 17:09:01 +0000 Received: from us-smtp-delivery-1.mimecast.com ([207.211.31.120] helo=us-smtp-1.mimecast.com) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iej0I-0007RG-26 for linux-arm-kernel@lists.infradead.org; Tue, 10 Dec 2019 17:08:56 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1575997731; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=x1LxWoUCCaDfDj41e4N7lik4ufNetyUaON2Dcr5RbTo=; b=IKGDEm/ZXsyd1u38dHyNzpjYHb/gYM6GW0su5DL2zQ1fn2V9B0vzyhC+E8lV5k3DbPXbVh 6JEXth8BPhxIKKvyRUiK1nmBX5mgOV5f8XHu2GfeKA8kqKtwzTNUxyl30WlT5/82YQqhZ/ wNfwotJamSkbx+9WRzcPfmUc45/4CW8= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-69--TvSP2o4Md2hGFjEiTm_iA-1; Tue, 10 Dec 2019 12:08:47 -0500 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 8E96D800EB8; Tue, 10 Dec 2019 17:08:45 +0000 (UTC) Received: from krava (unknown [10.43.17.106]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 2CE9060BE0; Tue, 10 Dec 2019 17:08:43 +0000 (UTC) Date: Tue, 10 Dec 2019 18:08:41 +0100 From: Jiri Olsa To: John Garry Subject: Re: perf top for arm64? Message-ID: <20191210170841.GA23357@krava> References: <1573045254-39833-1-git-send-email-john.garry@huawei.com> <20191106140036.GA6259@kernel.org> <418023e7-a50d-cb6f-989f-2e6d114ce5d8@huawei.com> <20191210163655.GG14123@krava> <952dc484-2739-ee65-f41c-f0198850ab10@huawei.com> MIME-Version: 1.0 In-Reply-To: <952dc484-2739-ee65-f41c-f0198850ab10@huawei.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-MC-Unique: -TvSP2o4Md2hGFjEiTm_iA-1 X-Mimecast-Spam-Score: 0 Content-Disposition: inline X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191210_090854_293413_B93BCE36 X-CRM114-Status: GOOD ( 13.47 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: mark.rutland@arm.com, peterz@infradead.org, Linuxarm , Arnaldo Carvalho de Melo , linux-kernel@vger.kernel.org, "linux-perf-users@vger.kernel.org" , alexander.shishkin@linux.intel.com, mingo@redhat.com, namhyung@kernel.org, will@kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Dec 10, 2019 at 04:52:52PM +0000, John Garry wrote: > On 10/12/2019 16:36, Jiri Olsa wrote: > > On Tue, Dec 10, 2019 at 04:13:49PM +0000, John Garry wrote: > > > Hi all, > > > > > > I find to my surprise that "perf top" does not work for arm64: > > > > > > root@ubuntu:/home/john/linux# tools/perf/perf top > > > Couldn't read the cpuid for this machine: No such file or directory > > > > Hi Jirka, > > > there was recent change that check on cpuid and quits: > > 608127f73779 perf top: Initialize perf_env->cpuid, needed by the per arch annotation init routine > > > > ok, this is new code. I obviously didn't check the git history... > > But, apart from this, there are many other places where get_cpuid() is > called. I wonder what else we're missing out on, and whether we should still > add it. right, I was just wondering how come vendor events are working for you, but realized we have get_cpuid_str being called in there ;-) I think we should add it as you have it prepared already, could you post it with bigger changelog that would explain where it's being used for arm? jirka _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel